Fix issues reported by pychecker

src/cadence.py

@@ -16,16 +16,11 @@
 #
 # For a full copy of the GNU General Public License see the COPYING file
 
-# FIXME - py3 later
-try:
-    from commands import getoutput
-except:
-    from subprocess import getoutput
-
 # Imports (Global)
 from platform import architecture
 from PyQt4.QtCore import QThread
 from PyQt4.QtGui import QApplication, QLabel, QMainWindow, QSizePolicy
+from subprocess import getoutput
 
 # Imports (Custom Stuff)
 import ui_cadence

src/carla.py

@@ -18,7 +18,7 @@
 
 # Imports (Global)
 import json
-from PyQt4.QtCore import Qt, QThread
+from PyQt4.QtCore import QThread
 from PyQt4.QtGui import QApplication, QMainWindow, QTableWidgetItem
 
 # Imports (Custom Stuff)

src/carla_control.py

@@ -22,7 +22,7 @@ from liblo import make_method, Address, ServerError, ServerThread
 from liblo import send as lo_send
 
 # Imports (Custom)
-import ui_carla_about, ui_carla_control, ui_carla_edit, ui_carla_parameter, ui_carla_plugin
+import ui_carla_about, ui_carla_control
 from shared_carla import *
 
 global carla_name, lo_target

src/paramspinbox.py

@@ -45,7 +45,7 @@ class CustomInputDialog(QDialog, ui_inputdialog_value.Ui_Dialog):
         else:
             text = "<table>"
             for scalePoint in scalePoints:
-                text += "<tr><td align='right'>%f</td><td align='left'> - %s</td></tr>" % (scalePoint['value'], scalepoint['label'])
+                text += "<tr><td align='right'>%f</td><td align='left'> - %s</td></tr>" % (scalePoint['value'], scalePoint['label'])
             text += "</table>"
             self.textBrowser.setText(text)
             self.resize(200, 300)

src/patchcanvas_theme.py

@@ -21,7 +21,7 @@ from PyQt4.QtGui import QColor, QFont, QPen, QPixmap
 
 class Theme(object):
     # enum PortType
-    THEME_PORT_SQUARE = 0
+    THEME_PORT_SQUARE  = 0
     THEME_PORT_POLYGON = 1
 
     # enum List

src/shared_carla.py

@@ -20,7 +20,7 @@
 import platform, sys
 from copy import deepcopy
 from sip import unwrapinstance
-from PyQt4.QtCore import pyqtSlot, QSettings, QTimer
+from PyQt4.QtCore import pyqtSlot, Qt, QSettings, QTimer
 from PyQt4.QtGui import QColor, QCursor, QDialog, QFontMetrics, QFrame, QInputDialog, QMenu, QPainter, QVBoxLayout, QWidget
 from PyQt4.QtXml import QDomDocument
 

src/shared_jack.py

@@ -26,7 +26,7 @@ from shared import *
 from jacklib_helpers import *
 
 # Have JACK2 ?
-if jacklib.JACK2:
+if jacklib.JACK2 and DEBUG:
     print("Using JACK2, version %s" % cString(jacklib.get_version_string()))
 
 # Can Render ?

src/systray.py

@@ -48,7 +48,7 @@ try:
 
         TrayEngine = "AppIndicator"
 
-    elif getenv("KDE_FULL_SESSION") or getenv("DESKTOP_SESSION") == "kde-plasma":
+    elif os.getenv("KDE_FULL_SESSION") or os.getenv("DESKTOP_SESSION") == "kde-plasma":
         from PyKDE4.kdeui import KAction, KIcon, KMenu, KStatusNotifierItem
         TrayEngine = "KDE"
 
@@ -628,7 +628,6 @@ class GlobalSysTray(object):
 
 #--------------- main ------------------
 if __name__ == '__main__':
-    import sys
     from PyQt4.QtGui import QApplication, QDialog, QMessageBox
 
     class ExampleGUI(QDialog):