From 9320a50dc33db7de33ef669c4e7d86300680466e Mon Sep 17 00:00:00 2001 From: falkTX Date: Tue, 11 Sep 2012 01:57:17 +0100 Subject: [PATCH] Fix issues reported by pychecker --- src/cadence.py | 7 +------ src/carla.py | 2 +- src/carla_control.py | 2 +- src/paramspinbox.py | 2 +- src/patchcanvas_theme.py | 2 +- src/shared_carla.py | 2 +- src/shared_jack.py | 2 +- src/systray.py | 3 +-- 8 files changed, 8 insertions(+), 14 deletions(-) diff --git a/src/cadence.py b/src/cadence.py index 200c01d..23a2831 100755 --- a/src/cadence.py +++ b/src/cadence.py @@ -16,16 +16,11 @@ # # For a full copy of the GNU General Public License see the COPYING file -# FIXME - py3 later -try: - from commands import getoutput -except: - from subprocess import getoutput - # Imports (Global) from platform import architecture from PyQt4.QtCore import QThread from PyQt4.QtGui import QApplication, QLabel, QMainWindow, QSizePolicy +from subprocess import getoutput # Imports (Custom Stuff) import ui_cadence diff --git a/src/carla.py b/src/carla.py index c9cdb70..758e8c8 100755 --- a/src/carla.py +++ b/src/carla.py @@ -18,7 +18,7 @@ # Imports (Global) import json -from PyQt4.QtCore import Qt, QThread +from PyQt4.QtCore import QThread from PyQt4.QtGui import QApplication, QMainWindow, QTableWidgetItem # Imports (Custom Stuff) diff --git a/src/carla_control.py b/src/carla_control.py index 31a111a..1316f36 100755 --- a/src/carla_control.py +++ b/src/carla_control.py @@ -22,7 +22,7 @@ from liblo import make_method, Address, ServerError, ServerThread from liblo import send as lo_send # Imports (Custom) -import ui_carla_about, ui_carla_control, ui_carla_edit, ui_carla_parameter, ui_carla_plugin +import ui_carla_about, ui_carla_control from shared_carla import * global carla_name, lo_target diff --git a/src/paramspinbox.py b/src/paramspinbox.py index 6d0be29..dc5877c 100644 --- a/src/paramspinbox.py +++ b/src/paramspinbox.py @@ -45,7 +45,7 @@ class CustomInputDialog(QDialog, ui_inputdialog_value.Ui_Dialog): else: text = "" for scalePoint in scalePoints: - text += "" % (scalePoint['value'], scalepoint['label']) + text += "" % (scalePoint['value'], scalePoint['label']) text += "
%f - %s
%f - %s
" self.textBrowser.setText(text) self.resize(200, 300) diff --git a/src/patchcanvas_theme.py b/src/patchcanvas_theme.py index 73a4485..864be51 100644 --- a/src/patchcanvas_theme.py +++ b/src/patchcanvas_theme.py @@ -21,7 +21,7 @@ from PyQt4.QtGui import QColor, QFont, QPen, QPixmap class Theme(object): # enum PortType - THEME_PORT_SQUARE = 0 + THEME_PORT_SQUARE = 0 THEME_PORT_POLYGON = 1 # enum List diff --git a/src/shared_carla.py b/src/shared_carla.py index 001fc8f..91ca993 100644 --- a/src/shared_carla.py +++ b/src/shared_carla.py @@ -20,7 +20,7 @@ import platform, sys from copy import deepcopy from sip import unwrapinstance -from PyQt4.QtCore import pyqtSlot, QSettings, QTimer +from PyQt4.QtCore import pyqtSlot, Qt, QSettings, QTimer from PyQt4.QtGui import QColor, QCursor, QDialog, QFontMetrics, QFrame, QInputDialog, QMenu, QPainter, QVBoxLayout, QWidget from PyQt4.QtXml import QDomDocument diff --git a/src/shared_jack.py b/src/shared_jack.py index 7fb4f20..dd7ccd8 100644 --- a/src/shared_jack.py +++ b/src/shared_jack.py @@ -26,7 +26,7 @@ from shared import * from jacklib_helpers import * # Have JACK2 ? -if jacklib.JACK2: +if jacklib.JACK2 and DEBUG: print("Using JACK2, version %s" % cString(jacklib.get_version_string())) # Can Render ? diff --git a/src/systray.py b/src/systray.py index 777f14f..9150ae3 100644 --- a/src/systray.py +++ b/src/systray.py @@ -48,7 +48,7 @@ try: TrayEngine = "AppIndicator" - elif getenv("KDE_FULL_SESSION") or getenv("DESKTOP_SESSION") == "kde-plasma": + elif os.getenv("KDE_FULL_SESSION") or os.getenv("DESKTOP_SESSION") == "kde-plasma": from PyKDE4.kdeui import KAction, KIcon, KMenu, KStatusNotifierItem TrayEngine = "KDE" @@ -628,7 +628,6 @@ class GlobalSysTray(object): #--------------- main ------------------ if __name__ == '__main__': - import sys from PyQt4.QtGui import QApplication, QDialog, QMessageBox class ExampleGUI(QDialog):