Signed-off-by: falkTX <falktx@falktx.com>

I was sure I did this already...

Signed-off-by: falkTX <falktx@falktx.com>

Thanks for noticing

Signed-off-by: falkTX <falktx@falktx.com>

Signed-off-by: falkTX <falktx@falktx.com>

Signed-off-by: falkTX <falktx@falktx.com>

Conflicts:
	common/JackEngine.cpp
	common/JackEngine.h

aften v0.0.8 is latest released tarball.
https://downloads.sourceforge.net/aften/aften-0.0.8.tar.bz2
Travis builds for OSX use aften v0.0.8 (brew).

More recent aften code has introduced an additional parameter to aften_encode_frame().

The check in wscript compiles a small test program to see if the additional parameter is understood.
If additional parameter 'count' is available, set HAVE_AFTEN_NEW_API.

HAVE_AFTEN_NEW_API is used in common/JackAC3Encoder.cpp to call aften_encode_frame()
either with or without 'count' param.

Problem:
int res = aften_encode_frame(&fAftenContext, fAC3Buffer + SPDIF_HEADER_SIZE, fSampleBuffer);
Fails, because API is
AFTEN_API int aften_encode_frame(AftenContext *s, unsigned char *frame_buffer,const void *samples, int count)

The additional parameter 'count' was added to libaften function aften_encode_frame() here:
e1cbb66628 (diff-d4868af7d235a914aef2ec4f979fcb9fR87)

Solves https://github.com/jackaudio/jack2/issues/455

[metadata] Fix property key length to notification/callback requests.

Fix memory leak of parameter constraints.

JackTools is a part of the LGPL licenced jacklib and should not pull in
GPL licensed code.

* Fix generation of client uuid

Signed-off-by: falkTX <falktx@falktx.com>

* Remove all client properties when removed; Cleanup a few things

Signed-off-by: falkTX <falktx@falktx.com>

* Make all uuid function arguments use jack_uuid_t type; Fix warnings

Signed-off-by: falkTX <falktx@falktx.com>

* Rework uuids to never be int, more cleanup

Signed-off-by: falkTX <falktx@falktx.com>

Signed-off-by: falkTX <falktx@falktx.com>

* Solving problems while compiling jack2 on macOS X with dbus support

* Using the right function name in uptime error

Signed-off-by: falkTX <falktx@falktx.com>

Signed-off-by: falkTX <falktx@falktx.com>

Signed-off-by: falkTX <falktx@falktx.com>

For this client program, it's hard to imagine a case where
autostarting a jack server is reasonable just to query or set the bufsize.

This is in accordance with programs like jack_lsp, jack_connect
(do not start a server if none is running).

- Use jack_set_error_function() (currently no-op)

In the case of clients that use jack_options_t JackNoStartServer,
running it with no server started produces verbose output in the form:

```
Cannot connect to server socket err = No such file or directory
Cannot connect to server request channel
jack server is not running or cannot be started
JackShmReadWritePtr::~JackShmReadWritePtr - Init not done for -1, skipping unlock
JackShmReadWritePtr::~JackShmReadWritePtr - Init not done for -1, skipping unlock
JACK server not running?
```

Setting a no-op error handler before trying jack_client_open()
will hide these messages.

Checking the status allows to output a user-friendly error message.

The first string is generic for any fail of jack_client_open()

`Error: cannot connect to JACK, `
Most importantly it informs the user that there is an error.

Depending on status the string is extended with either
`server is not running.`
or
`jack_client_open() failed, status =...`
if the status indicates anything else than JackServerFailed.

Running jack_lsp or jack_connect with no server running outputs (new)
`
Error: cannot connect to JACK, server is not running.
`

More aspects of example_clients/* can be reviewed for unification.
Some do ask:
`JACK server not running?`
Others tell
`JACK server not running.`

If this commit won't show deficits: jack_client_open() sections can be
changed in all example_clients accordingly.

Note: obviously the --version option is currently a NO-OP in many client programs. This needs a closer look.

Only REG_EXTENDED regular expressions are understood.

Eg. foo_{1|2} is NOT understood.

This commit solves segfault when using invalid regular expressions.
See https://github.com/jackaudio/jack2/issues/433

Running ldd -r -u <jack_binary> should tell about unused dependencies.

Also see
https://github.com/jackaudio/jack2/issues/430

Minor changes
-set script to fail on any error
-check early for existing jackd
-add comments

* Revert "oss_driver: Use float to S32 conversion if requested"

This reverts commit c5a0f5ea1c.

* Revert "alsa_in/out: Use float to S32 conversion if requested"

This reverts commit 148c8d8e6a.

* Revert "alsa_driver: Use float to S32 conversion if requested"

This reverts commit d017e1fffe.

* Revert "memops: Provide function for float to S32 conversion"

This reverts commit bb99e09b99.

* Revert "memops: Align S24LE and S32LE to float conversion"

This reverts commit b4ea23df6a.

* Revert "memops: Provide function for S32 to float conversion"

This reverts commit 244fc27e29.

* Revert "memops: Align float to S24LE and S32LE conversion"

This reverts commit 4455fe020c.

* Revert "memops: Remove not used conversion macros"

This reverts commit a82f3f2fb4.

* Revert "memops: Use right-aligned S24LE to float conversion"

This reverts commit e753254313.

* Revert "memops: Use right-aligned float to S24LE conversion"

This reverts commit 831163e516.