falkTX
3242f135d6
Use our metadata thread-safe mutex for the new check, seems to work
Signed-off-by: falkTX <falktx@falktx.com>
3 years ago
falkTX
8ed845f733
Not so smart handling for now, jack2 meta-data is finicky..
Signed-off-by: falkTX <falktx@falktx.com>
3 years ago
falkTX
3fd7f6bea1
One more fix
Signed-off-by: falkTX <falktx@falktx.com>
3 years ago
falkTX
e5f4d02e8f
Alternative approach to deal with jack postponed events
Might fix pipewire for real now, needs testing
Signed-off-by: falkTX <falktx@falktx.com>
3 years ago
falkTX
70e41f19bc
Revert "React to jack callbacks as fast as possible, fixing pipewire usage"
This reverts commit c777cd02d9
.
3 years ago
falkTX
62a6410171
Do not set jack latency callbacks, we do nothing with them
Signed-off-by: falkTX <falktx@falktx.com>
3 years ago
falkTX
491d33f50e
One more assertion ignored for jack metadata/uuid
Signed-off-by: falkTX <falktx@falktx.com>
3 years ago
falkTX
c777cd02d9
React to jack callbacks as fast as possible, fixing pipewire usage
Closes #1348
Signed-off-by: falkTX <falktx@falktx.com>
3 years ago
falkTX
2a6a7de04f
Fix main client name for multiple carlas inside NSM
Closes #1279
Signed-off-by: falkTX <falktx@falktx.com>
3 years ago
falkTX
f87f9bebba
Set audio and midi file path as used in MOD units
3 years ago
falkTX
a1d719548f
Prevent assertion when jack driver not running in multi-client mode
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
5a9e11a242
Store the raw MIDI value in EngineControlEvent, for future use
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
47bc02a140
Fix strict build
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
6f58669c08
Fix internal client build
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
929c869731
Use a custom flag so our CV ports appear as CV right away
JACK saves those flags as-is, which is great for us.
Fixes #1045
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
c3f05e4e96
Initial implementation of MIDI learn (per plugin, not global)
Closes #26
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
2b6fd1ca6d
Fix recursion when using carla-patchbay under JACk with lv2 midnam
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
bac54233ef
Add some safeties around invalid connection-id
Need to investigate this more deeply later on
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
fda792130a
Fix missing ports if client uuid fetch fails
Error case was returning instead of continuing
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
a6aaccc6eb
Final tweaks for internal/external patchbay usage and projects
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
18554a3692
Skip graph CV source reconfigure when loading plugin state
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
88c3255786
Tweaks to loading external patchbay data into internal one
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
d951215570
Only care about client name prefix in multi-client mode
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
3e87f7dff2
Add --cnprefix arg, for client name prefix; Set it also when needed
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
d7d33f7697
Don't rely on jack metadata callback being there for positions
Since we no longer have recursion issues, having this is fine.
This ensures carla keeps working in case JACK is fixed.
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
0463d8f1b7
Better error reporting regarding missing clients during load
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
53c8f6965b
Handle client name prefix during jack client rename
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
01c1aed761
Convert from and to client name prefix as needed
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
797278456c
JACK: Be able to load canvas positions regardless of client prefix
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
c4c387ed29
Use jack client prefic when renaming clients too
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
3d767f9be8
Allow to set custom prefix for jack clients, use it under NSM
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
843bb34910
Better handle case of JACK server stop (or killed)
Fixes #1175
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
040b0b6636
Fix false positives regarding jack meta-data and internal clients
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
6ab431a469
JACK: prevent recursion on patchbay group position changes
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
6ef541d1da
Fix strict build warnings against clang
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
b02fe8ad80
Ignore one assertion regarding JACK meta-data (false positive)
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
43c3a9923a
Fix usage without jack meta-data support
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
3afa203408
Fix JACK internal client build
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
22a6006c70
Avoid comparing shared_ptr directly to nullptr
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
90a868aba6
Fix bridge build
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
f73cafcea8
Backwards compatible std::shared_ptr
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
3ab47c9481
Change the way plugins are deleted, ensure they are not being used
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
92f7396caa
Protect *all* metadata access, even in bridge mode
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
0f53835c6d
Protect jack metadata usage with a mutex; other position fixes
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
e697553406
Fix for dumb compilers
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
fe95abf309
Small fixups for jack engine
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
3a3eee4ed9
Save pluginId as part of the patchbay positions
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
de66b320a8
Fix for old compilers
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
617675c820
Listen to canvas group position changes over JACK metadata and OSC
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
c178105a15
First go at backend-side canvas positions; Safer jack callbacks
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago