JackSettings: misc fixing

src/jacksettings.py

@@ -83,8 +83,8 @@ def setSampleRate(srate):
 # Helper functions (engine)
 
 def engineHasFeature(feature):
-    feature_list = jackctl.ReadContainer(["engine"])[1]
-    return bool(dbus.String(feature) in feature_list)
+    featureList = jackctl.ReadContainer(["engine"])[1]
+    return bool(dbus.String(feature) in featureList)
 
 def getEngineParameter(parameter, fallback):
     if not engineHasFeature(parameter):
@@ -107,8 +107,8 @@ def setEngineParameter(parameter, value, optional=True):
 # Helper functions (driver)
 
 def driverHasFeature(feature):
-    feature_list = jackctl.ReadContainer(["driver"])[1]
-    return bool(dbus.String(feature) in feature_list)
+    featureList = jackctl.ReadContainer(["driver"])[1]
+    return bool(dbus.String(feature) in featureList)
 
 def getDriverParameter(parameter, fallback):
     if not driverHasFeature(parameter):
@@ -145,10 +145,12 @@ class JackSettingsW(QDialog, ui_settings_jack.Ui_JackSettingsW):
         # -------------------------------------------------------------
         # Align driver text and hide non available ones
 
-        driver_list = jackctl.ReadContainer(["drivers"])[1]
+        driverList = jackctl.ReadContainer(["drivers"])[1]
+
         for i in range(self.obj_server_driver.rowCount()):
             self.obj_server_driver.item(0, i).setTextAlignment(Qt.AlignCenter)
-            if dbus.String(self.obj_server_driver.item(0, i).text().lower()) not in driver_list:
+
+            if dbus.String(self.obj_server_driver.item(0, i).text().lower()) not in driverList:
                 self.obj_server_driver.hideRow(i)
 
         # -------------------------------------------------------------
@@ -799,7 +801,8 @@ if __name__ == '__main__':
     if dbus:
         if initBus(dbus.SessionBus()):
             QMessageBox.critical(None, app.translate("JackSettingsW", "Error"), app.translate("JackSettingsW",
-                "jackdbus is not available!\nIs not possible to configure JACK at this point."))
+                "jackdbus is not available!\n"
+                "Is not possible to configure JACK at this point."))
             sys_exit(1)
     else:
         QMessageBox.critical(None, app.translate("JackSettingsW", "Error"),

src/shared_jack.py

@@ -74,14 +74,14 @@ jack = JackObject()
 
 # Init objects
 DBus.loop = None
-DBus.bus = None
-DBus.a2j = None
+DBus.bus  = None
+DBus.a2j  = None
 DBus.jack = None
 DBus.ladish_control = None
-DBus.ladish_studio = None
-DBus.ladish_room = None
-DBus.ladish_graph = None
-DBus.ladish_app_iface = None
+DBus.ladish_studio  = None
+DBus.ladish_room    = None
+DBus.ladish_graph   = None
+DBus.ladish_app_iface  = None
 DBus.ladish_app_daemon = None
 DBus.patchbay = None
 

src/ui/settings_jack.ui

@@ -134,9 +134,6 @@
           </item>
           <item row="0" column="2">
            <widget class="QLabel" name="label_23">
-            <property name="enabled">
-             <bool>false</bool>
-            </property>
             <property name="toolTip">
              <string>Scheduler priority when running in realtime mode</string>
             </property>
@@ -150,9 +147,6 @@
           </item>
           <item row="0" column="3">
            <widget class="QSpinBox" name="obj_server_realtime_priority">
-            <property name="enabled">
-             <bool>false</bool>
-            </property>
             <property name="toolTip">
              <string>Scheduler priority when running in realtime mode</string>
             </property>