Browse Source

Clean up code and issue templates.

tags/v1.1.4
Andrew Belt 5 years ago
parent
commit
f4151bed2e
4 changed files with 4 additions and 5 deletions
  1. +0
    -0
      .github/CODE-OF-CONDUCT.md
  2. +1
    -1
      .github/ISSUE_TEMPLATE/bug_report.md
  3. +2
    -3
      src/app/ParamWidget.cpp
  4. +1
    -1
      src/engine/Engine.cpp

CODE-OF-CONDUCT.md → .github/CODE-OF-CONDUCT.md View File


+ 1
- 1
.github/ISSUE_TEMPLATE/bug_report.md View File

@@ -8,7 +8,7 @@ about: Bugs, build errors, compatibility/stability issues
To file a bug report, fill out the form below. To file a bug report, fill out the form below.
Use a descriptive title that best explains the bug in one sentence. Use a descriptive title that best explains the bug in one sentence.
Attach screenshots if the bug is visual. Attach screenshots if the bug is visual.
Attach your `<Rack user folder>/log.txt` file if something is crashing or not loading.
Attach your `<Rack user folder>/log.txt` file if Rack is crashing.
Surround terminal output with three tildes Surround terminal output with three tildes
``` ```
like this. like this.


+ 2
- 3
src/app/ParamWidget.cpp View File

@@ -226,6 +226,8 @@ void ParamWidget::resetAction() {
if (paramQuantity && paramQuantity->isBounded()) { if (paramQuantity && paramQuantity->isBounded()) {
float oldValue = paramQuantity->getValue(); float oldValue = paramQuantity->getValue();
reset(); reset();
// Here's another way of doing it, but either works.
// paramQuantity->getParam()->reset();
float newValue = paramQuantity->getValue(); float newValue = paramQuantity->getValue();


if (oldValue != newValue) { if (oldValue != newValue) {
@@ -238,9 +240,6 @@ void ParamWidget::resetAction() {
h->newValue = newValue; h->newValue = newValue;
APP->history->push(h); APP->history->push(h);
} }

// Here's another way of doing it, but either works.
// paramQuantity->getParam()->reset();
} }
} }




+ 1
- 1
src/engine/Engine.cpp View File

@@ -10,7 +10,7 @@
#include <mutex> #include <mutex>
#include <atomic> #include <atomic>
#include <tuple> #include <tuple>
#include <x86intrin.h>
#include <pmmintrin.h>




namespace rack { namespace rack {


Loading…
Cancel
Save