From f4151bed2ece0fa1eee79fe15c4ec1af883c590e Mon Sep 17 00:00:00 2001 From: Andrew Belt Date: Tue, 30 Jul 2019 12:47:10 -0400 Subject: [PATCH] Clean up code and issue templates. --- CODE-OF-CONDUCT.md => .github/CODE-OF-CONDUCT.md | 0 .github/ISSUE_TEMPLATE/bug_report.md | 2 +- src/app/ParamWidget.cpp | 5 ++--- src/engine/Engine.cpp | 2 +- 4 files changed, 4 insertions(+), 5 deletions(-) rename CODE-OF-CONDUCT.md => .github/CODE-OF-CONDUCT.md (100%) diff --git a/CODE-OF-CONDUCT.md b/.github/CODE-OF-CONDUCT.md similarity index 100% rename from CODE-OF-CONDUCT.md rename to .github/CODE-OF-CONDUCT.md diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md index 552aafcb..2650b297 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.md +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -8,7 +8,7 @@ about: Bugs, build errors, compatibility/stability issues To file a bug report, fill out the form below. Use a descriptive title that best explains the bug in one sentence. Attach screenshots if the bug is visual. -Attach your `/log.txt` file if something is crashing or not loading. +Attach your `/log.txt` file if Rack is crashing. Surround terminal output with three tildes ``` like this. diff --git a/src/app/ParamWidget.cpp b/src/app/ParamWidget.cpp index 0024d0ea..8752ae19 100644 --- a/src/app/ParamWidget.cpp +++ b/src/app/ParamWidget.cpp @@ -226,6 +226,8 @@ void ParamWidget::resetAction() { if (paramQuantity && paramQuantity->isBounded()) { float oldValue = paramQuantity->getValue(); reset(); + // Here's another way of doing it, but either works. + // paramQuantity->getParam()->reset(); float newValue = paramQuantity->getValue(); if (oldValue != newValue) { @@ -238,9 +240,6 @@ void ParamWidget::resetAction() { h->newValue = newValue; APP->history->push(h); } - - // Here's another way of doing it, but either works. - // paramQuantity->getParam()->reset(); } } diff --git a/src/engine/Engine.cpp b/src/engine/Engine.cpp index e9bb8e51..4820389c 100644 --- a/src/engine/Engine.cpp +++ b/src/engine/Engine.cpp @@ -10,7 +10,7 @@ #include #include #include -#include +#include namespace rack {