Rework and simplify CI file

Signed-off-by: falkTX <falktx@falktx.com>

.github/workflows/build.yml

@@ -4,110 +4,80 @@ on: [push, pull_request]
 
 env:
   CACHE_VERSION: 1
+  DEBIAN_FRONTEND: noninteractive
   PAWPAW_SKIP_LTO: 1
   PAWPAW_SKIP_FFTW: 1
   PAWPAW_SKIP_GLIB: 1
   PAWPAW_SKIP_LV2: 1
   PAWPAW_SKIP_SAMPLERATE: 1
+  PAWPAW_SKIP_TESTS: 1
   WITH_LTO: false
 
 jobs:
   linux:
     strategy:
       matrix:
-        target: [aarch64, armhf, i386, riscv64, x86_64]
-    runs-on: ubuntu-20.04
+        target: [aarch64, armhf, i686, riscv64, x86_64]
+    runs-on: ubuntu-latest
+    container:
+      image: ubuntu:20.04
     steps:
-      - uses: actions/checkout@v3
+      - name: Install git
+        run: |
+          apt-get update -qq && apt-get install -yqq --no-install-recommends ca-certificates curl git openssl
+          curl -sLO https://launchpad.net/~kxstudio-debian/+archive/ubuntu/toolchain/+files/git_2.34.1-1ubuntu1~bpo20.04.1~ppa1_amd64.deb
+          curl -sLO https://launchpad.net/~kxstudio-debian/+archive/ubuntu/toolchain/+files/git-man_2.34.1-1ubuntu1~bpo20.04.1~ppa1_all.deb
+          dpkg -i *.deb
+          rm *.deb
+      - uses: actions/checkout@v4
         with:
           submodules: recursive
       - name: Set up cache
-        uses: actions/cache@v3
+        uses: actions/cache@v4
         with:
           path: |
             ~/PawPawBuilds
           key: linux-${{ matrix.target }}-v${{ env.CACHE_VERSION }}
-      - name: Fix GitHub's mess
-        run: |
-          sudo rm /etc/apt/sources.list.d/*.list
-          sudo apt-get update -qq
-          sudo apt-get purge -yqq git-man libclang* libgbm* libllvm* libmono* libnginx* moby* mono* nginx* perl php* libgdiplus libpcre2-posix3 libselinux1-dev libzip4
-          sudo apt-get install -yqq --allow-downgrades autoconf/focal automake/focal build-essential/focal git/focal libgd3/focal libglib2.0-0/focal libglib2.0-dev/focal libpcre2-8-0/focal libpcre2-16-0/focal libpcre2-32-0/focal libpcre2-posix2/focal pkg-config/focal
-      - name: Set up dependencies (aarch64)
-        if: ${{ matrix.target == 'aarch64' }}
-        run: |
-          sudo dpkg --add-architecture arm64
-          sudo sed -i "s/deb http/deb [arch=amd64] http/" /etc/apt/sources.list
-          sudo sed -i "s/deb mirror/deb [arch=amd64] mirror/" /etc/apt/sources.list
-          echo "deb [arch=arm64] http://ports.ubuntu.com/ubuntu-ports focal main restricted universe multiverse" | sudo tee /etc/apt/sources.list.d/ports-arm64.list
-          echo "deb [arch=arm64] http://ports.ubuntu.com/ubuntu-ports focal-updates main restricted universe multiverse" | sudo tee -a /etc/apt/sources.list.d/ports-arm64.list
-          echo "deb [arch=arm64] http://ports.ubuntu.com/ubuntu-ports focal-backports main restricted universe multiverse" | sudo tee -a /etc/apt/sources.list.d/ports-arm64.list
-          sudo apt-get update -qq
-          sudo apt-get install -yqq g++-aarch64-linux-gnu libasound2-dev:arm64 libdbus-1-dev:arm64 libgl1-mesa-dev:arm64 libglib2.0-dev:arm64 libx11-dev:arm64 libxcursor-dev:arm64 libxext-dev:arm64 libxrandr-dev:arm64 gperf meson qemu-user-static
-      - name: Set up dependencies (armhf)
-        if: ${{ matrix.target == 'armhf' }}
-        run: |
-          sudo dpkg --add-architecture armhf
-          sudo sed -i "s/deb http/deb [arch=amd64] http/" /etc/apt/sources.list
-          sudo sed -i "s/deb mirror/deb [arch=amd64] mirror/" /etc/apt/sources.list
-          echo "deb [arch=armhf] http://ports.ubuntu.com/ubuntu-ports focal main restricted universe multiverse" | sudo tee /etc/apt/sources.list.d/ports-armhf.list
-          echo "deb [arch=armhf] http://ports.ubuntu.com/ubuntu-ports focal-updates main restricted universe multiverse" | sudo tee -a /etc/apt/sources.list.d/ports-armhf.list
-          echo "deb [arch=armhf] http://ports.ubuntu.com/ubuntu-ports focal-backports main restricted universe multiverse" | sudo tee -a /etc/apt/sources.list.d/ports-armhf.list
-          sudo apt-get update -qq
-          sudo apt-get install -yqq g++-arm-linux-gnueabihf libasound2-dev:armhf libdbus-1-dev:armhf libgl1-mesa-dev:armhf libglib2.0-dev:armhf libx11-dev:armhf libxcursor-dev:armhf libxext-dev:armhf libxrandr-dev:armhf gperf meson qemu-user-static
-      - name: Set up dependencies (i386)
-        if: ${{ matrix.target == 'i386' }}
-        run: |
-          sudo dpkg --add-architecture i386
-          sudo apt-get update -qq
-          sudo apt-get install -yqq g++-i686-linux-gnu libasound2-dev:i386 libdbus-1-dev:i386 libgl1-mesa-dev:i386 libglib2.0-dev:i386 libx11-dev:i386 libxcursor-dev:i386 libxext-dev:i386 libxrandr-dev:i386 gperf meson
-          sudo apt-get install -yqq binutils-mingw-w64-i686 g++-mingw-w64-i686 mingw-w64 libwine-dev:i386 wine-stable wine64-tools
-      - name: Set up dependencies (riscv64)
-        if: ${{ matrix.target == 'riscv64' }}
+      - name: Set up dependencies
         run: |
-          sudo dpkg --add-architecture riscv64
-          sudo sed -i "s/deb http/deb [arch=amd64] http/" /etc/apt/sources.list
-          sudo sed -i "s/deb mirror/deb [arch=amd64] mirror/" /etc/apt/sources.list
-          echo "deb [arch=riscv64] http://ports.ubuntu.com/ubuntu-ports focal main restricted universe multiverse" | sudo tee /etc/apt/sources.list.d/ports-riscv64.list
-          echo "deb [arch=riscv64] http://ports.ubuntu.com/ubuntu-ports focal-updates main restricted universe multiverse" | sudo tee -a /etc/apt/sources.list.d/ports-riscv64.list
-          echo "deb [arch=riscv64] http://ports.ubuntu.com/ubuntu-ports focal-backports main restricted universe multiverse" | sudo tee -a /etc/apt/sources.list.d/ports-riscv64.list
-          sudo apt-get update -qq
-          sudo apt-get install -yqq g++-riscv64-linux-gnu libasound2-dev:riscv64 libdbus-1-dev:riscv64 libgl1-mesa-dev:riscv64 libglapi-mesa:riscv64 libglvnd0:riscv64 libglib2.0-dev:riscv64 libx11-dev:riscv64 libxcursor-dev:riscv64 libxext-dev:riscv64 libxrandr-dev:riscv64 gperf meson qemu-user-static
-      - name: Set up dependencies (x86_64)
+          git clone --depth=1 https://github.com/DISTRHO/PawPaw.git
+          ./PawPaw/.github/workflows/bootstrap-deps.sh linux-${{ matrix.target }}
+      - name: Set up dependencies x86_64 extra
         if: ${{ matrix.target == 'x86_64' }}
         run: |
-          sudo dpkg --add-architecture i386
-          sudo apt-get update -qq
-          sudo apt-get install -yqq libasound2-dev libdbus-1-dev libgl1-mesa-dev libglib2.0-dev libx11-dev libxcursor-dev libxext-dev libxrandr-dev gperf meson
-          sudo apt-get install -yqq g++-multilib libx11-dev:i386
-          sudo apt-get install -yqq binutils-mingw-w64-i686 binutils-mingw-w64-x86-64 g++-mingw-w64-i686 g++-mingw-w64-x86-64 mingw-w64 wine-stable wine64-tools
+          dpkg --add-architecture i386
+          apt-get update -qq
+          apt-get install -yqq g++-multilib libx11-dev:i386
+          apt-get install -yqq binutils-mingw-w64-i686 binutils-mingw-w64-x86-64 g++-mingw-w64-i686 g++-mingw-w64-x86-64 mingw-w64 wine-stable wine64-tools
       - name: Build extra dependencies
         run: |
-          git clone --depth=1 https://github.com/DISTRHO/PawPaw.git
-          ./PawPaw/bootstrap-cardinal.sh linux-${{ matrix.target }}
+          ./PawPaw/bootstrap-cardinal.sh linux-${{ matrix.target }} && ./PawPaw/.cleanup.sh linux-${{ matrix.target }}
       - name: Build linux
+        shell: bash
         run: |
           source PawPaw/local.env linux-${{ matrix.target }}
           make features
           make NOOPT=true -j $(nproc)
       - name: Build linux x86_64 extra (part1)
         if: ${{ matrix.target == 'x86_64' }}
+        shell: bash
         run: |
           source PawPaw/local.env linux-${{ matrix.target }}
           make NOOPT=true all extra-posix32 extra-win32 extra-win64 extra-wine64 -j $(nproc)
       - name: Build linux x86_64 extra (part2)
         if: ${{ matrix.target == 'x86_64' }}
+        shell: bash
         run: |
-          sudo apt-get install -yqq libwine-dev:i386
+          apt-get install -yqq libwine-dev:i386
           source PawPaw/local.env linux
           make NOOPT=true extra-wine32 -j $(nproc)
           make CARLA_EXTRA_TARGETS=true NOOPT=true -j $(nproc)
       - name: Set sha8
-        id: slug
-        run: echo "::set-output name=sha8::$(echo ${{ github.sha }} | cut -c1-8)"
-      - uses: actions/upload-artifact@v3
+        run: |
+          echo "SHA8=$(echo ${{ github.sha }} | cut -c1-8)" >> $GITHUB_ENV
+      - uses: actions/upload-artifact@v4
         with:
-          name: ${{ github.event.repository.name }}-linux-${{ matrix.target }}-${{ github.event.pull_request.number || steps.slug.outputs.sha8 }}
+          name: ${{ github.event.repository.name }}-linux-${{ matrix.target }}-${{ github.event.pull_request.number || env.SHA8 }}
           path: |
             bin/*
             !bin/Ildaeil
@@ -118,34 +88,37 @@ jobs:
         target: [intel, universal]
     runs-on: macos-11
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           submodules: recursive
       - name: Set up cache
-        uses: actions/cache@v3
+        uses: actions/cache@v4
         with:
           path: |
             ~/PawPawBuilds
           key: macos-${{ matrix.target }}-v${{ env.CACHE_VERSION }}
       - name: Set up dependencies
         run: |
-          brew install meson
+          git clone --depth=1 https://github.com/DISTRHO/PawPaw.git
+          ./PawPaw/.github/workflows/bootstrap-deps.sh macos-${{ matrix.target }}
       - name: Build extra dependencies
         run: |
-          git clone --depth=1 https://github.com/DISTRHO/PawPaw.git
-          ./PawPaw/bootstrap-cardinal.sh macos-${{ matrix.target }}
+          ./PawPaw/bootstrap-cardinal.sh macos-${{ matrix.target }} && ./PawPaw/.cleanup.sh macos-${{ matrix.target }}
       - name: Build macOS
         run: |
           source PawPaw/local.env macos-${{ matrix.target }}
           make features
           make NOOPT=true -j $(sysctl -n hw.logicalcpu)
+      - name: Pack macOS
+        run: |
+          source PawPaw/local.env macos-${{ matrix.target }}
           ./dpf/utils/package-osx-bundles.sh
       - name: Set sha8
-        id: slug
-        run: echo "::set-output name=sha8::$(echo ${{ github.sha }} | cut -c1-8)"
-      - uses: actions/upload-artifact@v3
+        run: |
+          echo "SHA8=$(echo ${{ github.sha }} | cut -c1-8)" >> $GITHUB_ENV
+      - uses: actions/upload-artifact@v4
         with:
-          name: ${{ github.event.repository.name }}-macOS-${{ matrix.target }}-${{ github.event.pull_request.number || steps.slug.outputs.sha8 }}
+          name: ${{ github.event.repository.name }}-macOS-${{ matrix.target }}-${{ github.event.pull_request.number || env.SHA8 }}
           path: |
             *-macOS.pkg
             bin/*
@@ -161,11 +134,11 @@ jobs:
         target: [win32, win64]
     runs-on: ubuntu-22.04
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           submodules: recursive
       - name: Set up cache
-        uses: actions/cache@v3
+        uses: actions/cache@v4
         with:
           path: |
             ~/PawPawBuilds
@@ -175,156 +148,44 @@ jobs:
           sudo rm -f /etc/apt/sources.list.d/microsoft-prod.list
           sudo dpkg --add-architecture i386
           sudo apt-get update -qq
-      - name: Set up dependencies (win32)
-        if: ${{ matrix.target == 'win32' }}
-        run: |
-          sudo apt-get install -yqq --allow-downgrades binutils-mingw-w64-i686 libc6:i386 libgcc-s1:i386 libstdc++6:i386 g++-mingw-w64-i686 gperf meson mingw-w64 wine-stable
-      - name: Set up dependencies (win64)
-        if: ${{ matrix.target == 'win64' }}
+      - name: Set up dependencies
         run: |
-          sudo apt-get install -yqq --allow-downgrades binutils-mingw-w64-x86-64 libc6:i386 libgcc-s1:i386 libstdc++6:i386 g++-mingw-w64-x86-64 gperf meson mingw-w64 wine-stable
+          git clone --depth=1 https://github.com/DISTRHO/PawPaw.git
+          ./PawPaw/.github/workflows/bootstrap-deps.sh ${{ matrix.target }}
       - name: Build extra dependencies
         run: |
-          git clone --depth=1 https://github.com/DISTRHO/PawPaw.git
-          ./PawPaw/bootstrap-cardinal.sh ${{ matrix.target }}
+          ./PawPaw/bootstrap-cardinal.sh ${{ matrix.target }} && ./PawPaw/.cleanup.sh ${{ matrix.target }}
       - name: Build cross-compiled
         run: |
           source PawPaw/local.env ${{ matrix.target }}
           make features
           make CARLA_EXTRA_TARGETS=true NOOPT=true -j $(nproc)
       - name: Set sha8
-        id: slug
-        run: echo "::set-output name=sha8::$(echo ${{ github.sha }} | cut -c1-8)"
-      - uses: actions/upload-artifact@v3
+        run: |
+          echo "SHA8=$(echo ${{ github.sha }} | cut -c1-8)" >> $GITHUB_ENV
+      - uses: actions/upload-artifact@v4
         with:
-          name: ${{ github.event.repository.name }}-${{ matrix.target }}-${{ github.event.pull_request.number || steps.slug.outputs.sha8 }}
+          name: ${{ github.event.repository.name }}-${{ matrix.target }}-${{ github.event.pull_request.number || env.SHA8 }}
           path: |
             bin/*
             !bin/*.exe
 
-  source-tarball:
-    runs-on: ubuntu-20.04
+  pluginval:
+    runs-on: ubuntu-22.04
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           submodules: recursive
-      - name: Set up dependencies
-        run: |
-          sudo apt-get update -qq
-          sudo apt-get install -yqq libgl1-mesa-dev libx11-dev libxcursor-dev libxext-dev libxrandr-dev gperf
-      - name: Create source tarball
-        run: |
-          make tarball
-      - name: Set sha8 (non-release)
-        if: startsWith(github.ref, 'refs/tags/') != true
-        id: slug1
-        run: echo "::set-output name=sha8::$(echo ${{ github.sha }} | cut -c1-8)"
-      - name: Set sha8 (release)
-        if: startsWith(github.ref, 'refs/tags/')
-        id: slug2
-        run: echo "::set-output name=sha8::$(echo ${{ github.ref_name }})"
-      - name: Set sha8
-        id: slug
-        run: echo "::set-output name=sha8::$(echo ${{ steps.slug1.outputs.sha8 || steps.slug2.outputs.sha8 }})"
-      - uses: actions/upload-artifact@v3
+      - uses: distrho/dpf-makefile-action@v1
         with:
-          name: ${{ github.event.repository.name }}-source-${{ github.event.pull_request.number || steps.slug.outputs.sha8 }}
-          path: |
-            /home/runner/*.tar.xz
-            /home/runner/*/*.tar.xz
-            /home/runner/*/*/*.tar.xz
-      - uses: softprops/action-gh-release@v1
-        if: startsWith(github.ref, 'refs/tags/')
-        with:
-          tag_name: ${{ github.ref_name }}
-          name: ${{ github.ref_name }}
-          draft: false
-          prerelease: false
-          files: |
-            /home/runner/*.tar.xz
-            /home/runner/*/*.tar.xz
-            /home/runner/*/*/*.tar.xz
+          target: pluginval
 
-  plugin-validation:
-    runs-on: ubuntu-20.04
+  source:
+    runs-on: ubuntu-22.04
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           submodules: recursive
-      - name: Set up dependencies
-        run: |
-          # custom repos
-          wget https://launchpad.net/~kxstudio-debian/+archive/kxstudio/+files/kxstudio-repos_11.1.0_all.deb
-          sudo dpkg -i kxstudio-repos_11.1.0_all.deb
-          sudo apt-get update -qq
-          # build-deps
-          sudo apt-get install -yqq libdbus-1-dev libgl1-mesa-dev libx11-dev libxcursor-dev libxext-dev libxrandr-dev gperf
-          # runtime testing
-          sudo apt-get install -yqq carla-git lilv-utils lv2-dev lv2lint kxstudio-lv2-extensions mod-lv2-extensions valgrind xvfb
-      - name: Build plugins
-        env:
-          CFLAGS: -g
-          CXXFLAGS: -g -DDPF_ABORT_ON_ERROR -DDPF_RUNTIME_TESTING
-          LDFLAGS: -static-libgcc -static-libstdc++
-        run: |
-          make features
-          make NOOPT=true SKIP_STRIPPING=true -j $(nproc)
-      - name: Run Ildaeil self-tests
-        run: |
-          xvfb-run valgrind \
-                --gen-suppressions=all \
-                --error-exitcode=255 \
-                --leak-check=no \
-                --track-origins=yes \
-                --suppressions=./dpf/utils/valgrind-dpf.supp \
-                ./bin/Ildaeil selftest
-      - name: Validate LV2 ttl syntax
-        run: |
-          lv2_validate \
-              /usr/lib/lv2/mod.lv2/*.ttl \
-              /usr/lib/lv2/kx-meta/*.ttl \
-              /usr/lib/lv2/kx-control-input-port-change-request.lv2/*.ttl \
-              /usr/lib/lv2/kx-programs.lv2/*.ttl \
-              ./bin/*.lv2/*.ttl
-      - name: Validate LV2 metadata and binaries
-        run: |
-          export LV2_PATH=/tmp/lv2-path
-          mkdir ${LV2_PATH}
-          cp -r bin/*.lv2 \
-              /usr/lib/lv2/{atom,buf-size,core,data-access,kx-control-input-port-change-request,kx-programs,instance-access,midi,parameters,port-groups,port-props,options,patch,presets,resize-port,state,time,ui,units,urid,worker}.lv2 \
-              ${LV2_PATH}
-          lv2lint -s lv2_generate_ttl -l ld-linux-x86-64.so.2 -M nopack $(lv2ls)
-      - name: Test LV2 plugins
-        run: |
-            export LV2_PATH=/tmp/lv2-path
-            for p in $(lv2ls); do \
-                env CARLA_BRIDGE_DUMMY=1 CARLA_BRIDGE_TESTING=native \
-                    valgrind \
-                    --error-exitcode=255 \
-                    --leak-check=full \
-                    --track-origins=yes \
-                    --suppressions=./dpf/utils/valgrind-dpf.supp \
-                    /usr/lib/carla/carla-bridge-native lv2 "" ${p} 1>/dev/null; \
-            done
-      - name: Test VST2 plugins
-        run: |
-            for p in $(find bin/ | grep -e vst.so -e '.*\.vst/.*\.so'); do \
-                env CARLA_BRIDGE_DUMMY=1 CARLA_BRIDGE_TESTING=native \
-                    valgrind \
-                    --error-exitcode=255 \
-                    --leak-check=full \
-                    --track-origins=yes \
-                    --suppressions=./dpf/utils/valgrind-dpf.supp \
-                    /usr/lib/carla/carla-bridge-native vst2 ./${p} "" 1>/dev/null; \
-            done
-      - name: Test VST3 plugins
-        run: |
-            for p in $(ls bin/ | grep vst3); do \
-                env CARLA_BRIDGE_DUMMY=1 CARLA_BRIDGE_TESTING=native \
-                    valgrind \
-                    --error-exitcode=255 \
-                    --leak-check=full \
-                    --track-origins=yes \
-                    --suppressions=./dpf/utils/valgrind-dpf.supp \
-                    /usr/lib/carla/carla-bridge-native vst3 ./bin/${p} "" 1>/dev/null; \
-            done
+      - uses: distrho/dpf-makefile-action@v1
+        with:
+          target: source