Browse Source

Declare the hardcoded dpf param symbols in the public API

Signed-off-by: falkTX <falktx@falktx.com>
pull/443/head
falkTX 1 year ago
parent
commit
bafe8b9dd4
Signed by: falkTX <falktx@falktx.com> GPG Key ID: CDBAA37ABC74FBA0
3 changed files with 21 additions and 5 deletions
  1. +18
    -2
      distrho/DistrhoDetails.hpp
  2. +2
    -2
      distrho/src/DistrhoPluginLV2export.cpp
  3. +1
    -1
      distrho/src/DistrhoUILV2.cpp

+ 18
- 2
distrho/DistrhoDetails.hpp View File

@@ -223,6 +223,22 @@ enum ParameterDesignation {
kParameterDesignationBypass = 1
};

/**
Parameter designation symbols.@n
These are static, hard-coded definitions to ensure consistency across DPF and plugins.
*/
namespace ParameterDesignationSymbols {
/**
Bypass designation symbol.
*/
static constexpr const char bypass[] = "dpf_bypass";

/**
Bypass designation symbol, inverted for LV2 so it becomes "enabled".
*/
static constexpr const char bypass_lv2[] = "lv2_enabled";
};

/**
Predefined Port Groups Ids.

@@ -731,7 +747,7 @@ struct Parameter {
hints = kParameterIsAutomatable|kParameterIsBoolean|kParameterIsInteger;
name = "Bypass";
shortName = "Bypass";
symbol = "dpf_bypass";
symbol = ParameterDesignationSymbols::bypass;
unit = "";
midiCC = 0;
groupId = kPortGroupNone;
@@ -749,7 +765,7 @@ struct Parameter {
*/
static constexpr const Parameter kParameterBypass = {
kParameterIsAutomatable|kParameterIsBoolean|kParameterIsInteger,
"Bypass", "Bypass", "dpf_bypass", "", "", {}, {}, 0, kPortGroupNone,
"Bypass", "Bypass", ParameterDesignationSymbols::bypass, "", "", {}, {}, 0, kPortGroupNone,
};
#endif



+ 2
- 2
distrho/src/DistrhoPluginLV2export.cpp View File

@@ -748,7 +748,7 @@ void lv2_generate_ttl(const char* const basename)
case kParameterDesignationBypass:
designated = true;
pluginString += " lv2:name \"Enabled\" ;\n";
pluginString += " lv2:symbol \"" DISTRHO_BYPASS_PARAMETER_NAME "\" ;\n";
pluginString += " lv2:symbol \"" + String(ParameterDesignationSymbols::bypass_lv2) + "\" ;\n";
pluginString += " lv2:default 1 ;\n";
pluginString += " lv2:minimum 0 ;\n";
pluginString += " lv2:maximum 1 ;\n";
@@ -1684,7 +1684,7 @@ void lv2_generate_ttl(const char* const basename)

if (plugin.getParameterDesignation(j) == kParameterDesignationBypass)
{
parameterSymbol = DISTRHO_BYPASS_PARAMETER_NAME;
parameterSymbol = ParameterDesignationSymbols::bypass_lv2;
parameterValue = 1.0f - parameterValue;
}



+ 1
- 1
distrho/src/DistrhoUILV2.cpp View File

@@ -88,7 +88,7 @@ public:
fController(controller),
fWriteFunction(writeFunc),
fURIDs(uridMap),
fBypassParameterIndex(fUiPortMap != nullptr ? fUiPortMap->port_index(fUiPortMap->handle, "lv2_enabled")
fBypassParameterIndex(fUiPortMap != nullptr ? fUiPortMap->port_index(fUiPortMap->handle, ParameterDesignationSymbols::bypass_lv2)
: LV2UI_INVALID_PORT_INDEX),
fWinIdWasNull(winId == 0),
fUI(this, winId, sampleRate,


Loading…
Cancel
Save