Browse Source
Fix VST3 parameter offset for plugins with midi input
Signed-off-by: falkTX <falktx@falktx.com>pull/473/head
2 changed files with 4 additions and 5 deletions
Unified View
Diff Options
+ 1
- 2
distrho/src/DistrhoPluginVST.hpp
View File
| @@ -70,8 +70,7 @@ enum Vst3InternalParameters { | |||||
| kVst3InternalParameterBaseCount, | kVst3InternalParameterBaseCount, | ||||
| #if DISTRHO_PLUGIN_WANT_MIDI_INPUT | #if DISTRHO_PLUGIN_WANT_MIDI_INPUT | ||||
| kVst3InternalParameterMidiCC_start = kVst3InternalParameterBaseCount, | kVst3InternalParameterMidiCC_start = kVst3InternalParameterBaseCount, | ||||
| kVst3InternalParameterMidiCC_end = kVst3InternalParameterMidiCC_start + 130*16, | |||||
| kVst3InternalParameterCount | |||||
| kVst3InternalParameterCount = kVst3InternalParameterMidiCC_start + 130 * 16 | |||||
| #else | #else | ||||
| kVst3InternalParameterCount = kVst3InternalParameterBaseCount | kVst3InternalParameterCount = kVst3InternalParameterBaseCount | ||||
| #endif | #endif | ||||
+ 3
- 3
distrho/src/DistrhoPluginVST3.cpp
View File
| @@ -1573,7 +1573,7 @@ public: | |||||
| { | { | ||||
| #if DISTRHO_PLUGIN_WANT_MIDI_INPUT | #if DISTRHO_PLUGIN_WANT_MIDI_INPUT | ||||
| // if there are any MIDI CC events as parameter changes, handle them here | // if there are any MIDI CC events as parameter changes, handle them here | ||||
| if (canAppendMoreEvents && rindex >= kVst3InternalParameterMidiCC_start && rindex <= kVst3InternalParameterMidiCC_end) | |||||
| if (canAppendMoreEvents && rindex >= kVst3InternalParameterMidiCC_start && rindex < kVst3InternalParameterCount) | |||||
| { | { | ||||
| for (int32_t j = 0, pcount = v3_cpp_obj(queue)->get_point_count(queue); j < pcount; ++j) | for (int32_t j = 0, pcount = v3_cpp_obj(queue)->get_point_count(queue); j < pcount; ++j) | ||||
| { | { | ||||
| @@ -2008,7 +2008,7 @@ public: | |||||
| #if !DPF_VST3_PURE_MIDI_INTERNAL_PARAMETERS | #if !DPF_VST3_PURE_MIDI_INTERNAL_PARAMETERS | ||||
| rindex >= kVst3InternalParameterMidiCC_start && | rindex >= kVst3InternalParameterMidiCC_start && | ||||
| #endif | #endif | ||||
| rindex <= kVst3InternalParameterMidiCC_end) | |||||
| rindex < kVst3InternalParameterCount) | |||||
| return 0.0; | return 0.0; | ||||
| #endif | #endif | ||||
| @@ -2045,7 +2045,7 @@ public: | |||||
| #if !DPF_VST3_PURE_MIDI_INTERNAL_PARAMETERS | #if !DPF_VST3_PURE_MIDI_INTERNAL_PARAMETERS | ||||
| rindex >= kVst3InternalParameterMidiCC_start && | rindex >= kVst3InternalParameterMidiCC_start && | ||||
| #endif | #endif | ||||
| rindex <= kVst3InternalParameterMidiCC_end) | |||||
| rindex < kVst3InternalParameterCount) | |||||
| return V3_INVALID_ARG; | return V3_INVALID_ARG; | ||||
| #endif | #endif | ||||