Browse Source

Fix some compiler warnings

pull/324/head
falkTX 3 years ago
parent
commit
283e9c3dab
3 changed files with 14 additions and 9 deletions
  1. +12
    -3
      distrho/src/DistrhoPluginLV2.cpp
  2. +2
    -2
      distrho/src/DistrhoUIPrivateData.hpp
  3. +0
    -4
      examples/EmbedExternalUI/EmbedExternalExampleUI.cpp

+ 12
- 3
distrho/src/DistrhoPluginLV2.cpp View File

@@ -84,10 +84,12 @@ public:
fPortControls(nullptr), fPortControls(nullptr),
fLastControlValues(nullptr), fLastControlValues(nullptr),
fSampleRate(sampleRate), fSampleRate(sampleRate),
#if DISTRHO_PLUGIN_WANT_PARAMETER_VALUE_CHANGE_REQUEST
fCtrlInPortChangeReq(ctrlInPortChangeReq),
#endif
fURIDs(uridMap), fURIDs(uridMap),
fUridMap(uridMap), fUridMap(uridMap),
fWorker(worker),
fCtrlInPortChangeReq(ctrlInPortChangeReq)
fWorker(worker)
{ {
#if DISTRHO_PLUGIN_NUM_INPUTS > 0 #if DISTRHO_PLUGIN_NUM_INPUTS > 0
for (uint32_t i=0; i < DISTRHO_PLUGIN_NUM_INPUTS; ++i) for (uint32_t i=0; i < DISTRHO_PLUGIN_NUM_INPUTS; ++i)
@@ -157,6 +159,11 @@ public:
// unused // unused
(void)fWorker; (void)fWorker;
#endif #endif

#if ! DISTRHO_PLUGIN_WANT_PARAMETER_VALUE_CHANGE_REQUEST
// unused
(void)ctrlInPortChangeReq;
#endif
} }


~PluginLv2() ~PluginLv2()
@@ -1178,9 +1185,11 @@ private:
} fURIDs; } fURIDs;


// LV2 features // LV2 features
#if DISTRHO_PLUGIN_WANT_PARAMETER_VALUE_CHANGE_REQUEST
const LV2_ControlInputPort_Change_Request* const fCtrlInPortChangeReq;
#endif
const LV2_URID_Map* const fUridMap; const LV2_URID_Map* const fUridMap;
const LV2_Worker_Schedule* const fWorker; const LV2_Worker_Schedule* const fWorker;
const LV2_ControlInputPort_Change_Request* const fCtrlInPortChangeReq;


#if DISTRHO_PLUGIN_WANT_STATE #if DISTRHO_PLUGIN_WANT_STATE
StringToStringMap fStateMap; StringToStringMap fStateMap;


+ 2
- 2
distrho/src/DistrhoUIPrivateData.hpp View File

@@ -52,14 +52,14 @@ START_NAMESPACE_DGL
#if DISTRHO_PLUGIN_HAS_EXTERNAL_UI #if DISTRHO_PLUGIN_HAS_EXTERNAL_UI
struct PluginApplication struct PluginApplication
{ {
IdleCallback* idleCallback;
DGL_NAMESPACE::IdleCallback* idleCallback;
UI* ui; UI* ui;


explicit PluginApplication() explicit PluginApplication()
: idleCallback(nullptr), : idleCallback(nullptr),
ui(nullptr) {} ui(nullptr) {}


void addIdleCallback(IdleCallback* const cb)
void addIdleCallback(DGL_NAMESPACE::IdleCallback* const cb)
{ {
DISTRHO_SAFE_ASSERT_RETURN(cb != nullptr,); DISTRHO_SAFE_ASSERT_RETURN(cb != nullptr,);
DISTRHO_SAFE_ASSERT_RETURN(idleCallback == nullptr,); DISTRHO_SAFE_ASSERT_RETURN(idleCallback == nullptr,);


+ 0
- 4
examples/EmbedExternalUI/EmbedExternalExampleUI.cpp View File

@@ -473,10 +473,6 @@ protected:


// ------------------------------------------------------------------------------------------------------- // -------------------------------------------------------------------------------------------------------


private:
// Current value, cached for when UI becomes visible
float fValue;

/** /**
Set our UI class as non-copyable and add a leak detector just in case. Set our UI class as non-copyable and add a leak detector just in case.
*/ */


Loading…
Cancel
Save