Browse Source

Enable VST3 build on MSVC, remove C++98 workaround

Signed-off-by: falkTX <falktx@falktx.com>
pull/338/head
falkTX 3 years ago
parent
commit
253edfc88a
Signed by: falkTX <falktx@falktx.com> GPG Key ID: CDBAA37ABC74FBA0
2 changed files with 2 additions and 6 deletions
  1. +1
    -1
      .github/workflows/makefile.yml
  2. +1
    -5
      cmake/DPF-plugin.cmake

+ 1
- 1
.github/workflows/makefile.yml View File

@@ -40,7 +40,7 @@ jobs:
CXXFLAGS: -Werror -std=gnu++98
run: |
make clean >/dev/null
make -j $(nproc) VST3_FILENAME=
make -j $(nproc)
- name: No namespace
env:
CFLAGS: -Werror


+ 1
- 5
cmake/DPF-plugin.cmake View File

@@ -154,11 +154,7 @@ function(dpf_add_plugin NAME)
elseif(_target STREQUAL "vst2")
dpf__build_vst2("${NAME}" "${_dgl_library}")
elseif(_target STREQUAL "vst3")
if(MSVC)
message(WARNING "TODO: VST3 is not supported on MSVC yet")
else()
dpf__build_vst3("${NAME}" "${_dgl_library}")
endif()
dpf__build_vst3("${NAME}" "${_dgl_library}")
else()
message(FATAL_ERROR "Unrecognized target type for plugin: ${_target}")
endif()


Loading…
Cancel
Save