Merge pull request #14 from linuxaudio/fix-compiler-warnings

Fix all compiler warnings

src/Endpoint.cpp

@@ -30,6 +30,7 @@
 #include "Thread.hpp"
 
 #pragma GCC diagnostic ignored "-Wunused-parameter"
+#pragma GCC diagnostic ignored "-Wunused-result"
 
 namespace OSC
 {

src/file.cpp

@@ -180,7 +180,7 @@ write_line ( const char *dir, const char *name, const char *value )
     fclose( fp );
 }
 
-/** write a single string to a file */
+/** read a single string from a file */
 char *
 read_line ( const char *dir, const char *name  )
 {
@@ -195,9 +195,8 @@ read_line ( const char *dir, const char *name  )
 
     char *value = (char*)malloc( 512 );
 
-    value[0] = 0;
-
-    fgets( value, 512, fp );
+    if ( ! fgets( value, 512, fp ) )
+        value[0] = 0;
 
     fclose( fp );
 

src/jackpatch.c

@@ -25,6 +25,10 @@
  */
 
 #pragma GCC diagnostic ignored "-Wunused-parameter"
+#pragma GCC diagnostic ignored "-Wunused-result"
+
+/* needed for asprintf */
+#define _GNU_SOURCE
 
 #include <string.h>
 #include <sys/stat.h>
@@ -694,7 +698,7 @@ dequeue_new_port ( void )
 
     if ( sizeof( int ) == jack_ringbuffer_peek( port_ringbuffer, (char*)&size, sizeof( int ) ) )
     {
-        if ( jack_ringbuffer_read_space( port_ringbuffer ) >= size );
+        if ( jack_ringbuffer_read_space( port_ringbuffer ) >= size )
         {
             struct port_notification_record *pr = malloc( size );
 

src/nsm-proxy.cpp

@@ -19,6 +19,7 @@
 /*******************************************************************************/
 
 #pragma GCC diagnostic ignored "-Wunused-parameter"
+#pragma GCC diagnostic ignored "-Wunused-result"
 
 #define _MODULE_ "nsm-proxy"
 #define APP_NAME "NSM Proxy"

src/nsmd.cpp

@@ -57,6 +57,7 @@
 #include <algorithm>
 
 #pragma GCC diagnostic ignored "-Wunused-parameter"
+#pragma GCC diagnostic ignored "-Wunused-result"
 
 static OSC::Endpoint *osc_server;
 static lo_address gui_addr;

src/session-manager.cpp

@@ -53,6 +53,8 @@
 #define APP_NAME "New-Session-Manager"
 #define APP_TITLE "New Session Manager"
 
+#pragma GCC diagnostic ignored "-Wunused-result"
+
 // static lo_address nsm_addr = NULL;
 static time_t last_ping_response;