JackTools is a part of the LGPL licenced jacklib and should not pull in
GPL licensed code.

* Fix generation of client uuid

Signed-off-by: falkTX <falktx@falktx.com>

* Remove all client properties when removed; Cleanup a few things

Signed-off-by: falkTX <falktx@falktx.com>

* Make all uuid function arguments use jack_uuid_t type; Fix warnings

Signed-off-by: falkTX <falktx@falktx.com>

* Rework uuids to never be int, more cleanup

Signed-off-by: falkTX <falktx@falktx.com>

Signed-off-by: falkTX <falktx@falktx.com>

Signed-off-by: falkTX <falktx@falktx.com>

Only REG_EXTENDED regular expressions are understood.

Eg. foo_{1|2} is NOT understood.

This commit solves segfault when using invalid regular expressions.
See https://github.com/jackaudio/jack2/issues/433

* Revert "oss_driver: Use float to S32 conversion if requested"

This reverts commit c5a0f5ea1c.

* Revert "alsa_in/out: Use float to S32 conversion if requested"

This reverts commit 148c8d8e6a.

* Revert "alsa_driver: Use float to S32 conversion if requested"

This reverts commit d017e1fffe.

* Revert "memops: Provide function for float to S32 conversion"

This reverts commit bb99e09b99.

* Revert "memops: Align S24LE and S32LE to float conversion"

This reverts commit b4ea23df6a.

* Revert "memops: Provide function for S32 to float conversion"

This reverts commit 244fc27e29.

* Revert "memops: Align float to S24LE and S32LE conversion"

This reverts commit 4455fe020c.

* Revert "memops: Remove not used conversion macros"

This reverts commit a82f3f2fb4.

* Revert "memops: Use right-aligned S24LE to float conversion"

This reverts commit e753254313.

* Revert "memops: Use right-aligned float to S24LE conversion"

This reverts commit 831163e516.

Problem:

#set two properties for UUID 4294967296

$ jack_property -s 4294967296 "a" 1
$ jack_property -s 4294967296 b "2"

#-l lists them

$ jack_property -l
4294967296
key: b value: 2
key: a value: 1

#-l for UUID doesn't list them  <<<<<<

$ jack_property -l 4294967296
$ jack_property -l 4294967296 a
Value not found for a of 4294967296
$ jack_property -l 4294967296 b
Value not found for b of 4294967296

#it seems that 3 chars is the minimum length for value when querying for UUID

$ jack_property -s 4294967296 a 123
$ jack_property -l 4294967296
key: a value: 123
$ jack_property -l 4294967296 a
123

In example-clients/property.c:

/* list all properties for a given UUID */

                        if ((cnt = jack_get_properties (uuid, &description)) < 0) {
                                fprintf (stderr, "could not retrieve properties for %s\n", subject);
                                exit (1);
                        }

cnt is always 0 for values < 3 chars. Why?

In common/JackMetadata.cpp:

int JackMetadata::GetProperty(jack_uuid_t subject, const char* key, char** value, char** type)
int JackMetadata::GetProperties(jack_uuid_t subject, jack_description_t* desc)

This loop gets results:
while ((ret = cursor->get (cursor, &key, &data, DB_NEXT)) == 0) {

but are dropped because of this check:

/* result must have at least 2 chars plus 2 nulls to be valid
if (data.size < 4) {

This rule isn't understood. Explanations are welcome!
Reducing the check to 2 (1 char + null) will consider single char values.
This makes listing properties for a given UUID the same keys as when listing all UUIDs and keys.
No side-effects of lowering the value has been detected (yet).

Note: there is no problem getting "short" values in this method:
int JackMetadata::GetAllProperties(jack_description_t** descriptions)
(as used by jack_property -l without UUID)

jack_property output after change to (data.size < 2):

$ jack_property -s 4294967296 "a" 1
$ jack_property -s 4294967296 b "2"
$ jack_property -l
4294967296
key: b value: 2
key: a value: 1
$ jack_property -l 4294967296
key: b value: 2
key: a value: 1
$ jack_property -l 4294967296 a
1
$ jack_property -l 4294967296 b
2

Note: This change should be considered also for JACK1 (libjack/metadata.c)
to keep implementations in sync.

See https://github.com/jackaudio/jack2/issues/413

Due to inlining and enabled optimization the compiler will not create
machine instructions for the if-clauses and left shift for
sample_move_dS_s32s() and sample_move_dS_s32().

Signed-off-by: Timo Wischer <twischer@de.adit-jv.com>

Due to the optimization of the compiler this commit does not introduce any
differences in the machine instructions.
Tested with GCC version 6.2.0 on ARM64 and x86_64.

Signed-off-by: Timo Wischer <twischer@de.adit-jv.com>

Signed-off-by: Timo Wischer <twischer@de.adit-jv.com>

Signed-off-by: Timo Wischer <twischer@de.adit-jv.com>

Signed-off-by: Timo Wischer <twischer@de.adit-jv.com>

ALSA expects right-aligned samples (0x00******) as mentioned in the
source code for SND_PCM_FORMAT_S24_LE:
Signed 24 bit Little Endian using low three bytes in 32-bit word
See http://git.alsa-project.org/?p=alsa-
lib.git;a=blob;f=include/pcm.h;h=5b0782315585de1d5ab82c9f2036b62c168f5a48;hb=HEAD#l140

Signed-off-by: Timo Wischer <twischer@de.adit-jv.com>

ALSA expects right-aligned samples (0x00******) as mentioned in the
source code for SND_PCM_FORMAT_S24_LE:
Signed 24 bit Little Endian using low three bytes in 32-bit word
See http://git.alsa-project.org/?p=alsa-
lib.git;a=blob;f=include/pcm.h;h=5b0782315585de1d5ab82c9f2036b62c168f5a48;hb=HEAD#l140

Signed-off-by: Timo Wischer <twischer@de.adit-jv.com>

GCC defines __ARM_NEON__ for asimd on ARMv7 and __ARM_NEON for simd on
ARMv8. Therefore also check for __ARM_NEON.

Signed-off-by: Timo Wischer <twischer@de.adit-jv.com>

When building with MXE, the macro expansion of PRIu64 fails:

../common/JackAPI.cpp: In function 'int jack_uuid_parse(const char*, jack_uuid_t*)':
../common/JackAPI.cpp:2119:24: error: expected ')' before 'PRIu64'
     if (sscanf (b, "%" PRIu64, u) == 1) {
                        ^
../common/JackAPI.cpp:2119:33: warning: spurious trailing '%' in format [-Wformat=]
     if (sscanf (b, "%" PRIu64, u) == 1) {
                                 ^
../common/JackAPI.cpp:2119:33: warning: too many arguments for format [-Wformat-extra-args]
../common/JackAPI.cpp: In function 'void jack_uuid_unparse(jack_uuid_t, char*)':
../common/JackAPI.cpp:2134:45: error: expected ')' before 'PRIu64'
     snprintf (b, JACK_UUID_STRING_SIZE, "%" PRIu64, u);
                                             ^
../common/JackAPI.cpp:2134:54: warning: spurious trailing '%' in format [-Wformat=]
     snprintf (b, JACK_UUID_STRING_SIZE, "%" PRIu64, u);
                                                      ^
../common/JackAPI.cpp:2134:54: warning: too many arguments for format [-Wformat-extra-args]

This could be resolved by adding those two lines:

#define __STDC_FORMAT_MACROS 1
#include <inttypes.h>

References:
https://stackoverflow.com/questions/14535556/why-doesnt-priu64-work-in-this-code
https://stackoverflow.com/questions/8132399/how-to-printf-uint64-t-fails-with-spurious-trailing-in-format

Signed-off-by: falkTX <falktx@gmail.com>

* [metadata] Metadata properties implementation.

* [metadata] Fixed for shared server metadata-base accessor; alsofixed coding/naming style.

* [metadata] Fixed a tab for space.

* [metadata] Use of Berkeley DB is now truly optional on configure time.

* [metadata] Fixed tabs for spaces, again.

* [metadata] Fixed for shared metadata-base initialization and external clients.

* [metadata] Blind-fix for windows codebase.

* [metadata] Metadata API moved into client-side library only.

* [metadata] Fixed jack_port_uuid() stubbiness, now returning a proper UUID from port index.

* [metadata] Uniform method names.

* [metadata] Fixed PropertyChangeNotify through server async call.

Signed-off-by: falkTX <falktx@gmail.com>

This adds missing includes for alloca. The man page of alloca(3) states
that alloca.h should be #include'd to use alloca.

Also work around missing alloca.h header on Windows by adding a
compatibility module.

Closes: #197

This reverts commit dde9f29a8e.

The commit introduced the following compiler error:

[100/255] Compiling posix/JackNetUnixSocket.cpp
../posix/JackNetUnixSocket.cpp: In member function 'int Jack::JackNetUnixSocket::NewSocket()':
../posix/JackNetUnixSocket.cpp:126:32: error: 'tos' was not declared in this scope
         socklen_t len = sizeof(tos);

A bit late...

With this patch it is possibly to start the JACK daemon with a systemd
service file of type notify. The following provides an example service
file:

[Service]
Type=notify
ExecStart=/usr/bin/jackd -d alsa

[Install]
WantedBy=multi-user.target

Signed-off-by: Timo Wischer <twischer@de.adit-jv.com>

Flagged by the Debian QA tool.

Mostly automatic search-n-replace of the mistakes flagged.

Fixes #288

Thanks to Timo Wischer for the initial work