Found via `codespell -q 3 -L capela,nd,numer,parm`

Found via `codespell -q 3`

Notes:
The name length test still fails.

jack_client_open() will only allow 63 printable chars (unlike expected 64 == JACK_CLIENT_NAME_SIZE).
This difference isn't explained by the terminating NULL character. jack_client_name_size() takes care of that (returns JACK_CLIENT_NAME_SIZE + 1).
char arrays are initialized like arr[JACK_CLIENT_NAME_SIZE + 1] in many files und truncated like arr[JACK_CLIENT_NAME_SIZE].

Probable reason for 63: ':' is part of the client name and implicitely added later.
Name used by caller does not include ':' thus jack_client_open() will allow only JACK_CLIENT_NAME_SIZE - 1 printable chars.

This line in common/JackConstants.h gives a hint that ':' might be counted in for JACK_CLIENT_NAME_SIZE
#define REAL_JACK_PORT_NAME_SIZE JACK_CLIENT_NAME_SIZE + JACK_PORT_NAME_SIZE // full name like "client_name:short_port_name"

Currently many char arguments are described like
@param client_name of at most jack_client_name_size() characters

This can be confusing in two ways:
-jack_client_name_size() does include the NULL so it's one less 'payload' character
-if the returned size is used exactly as described for function jack_client_name_size() including NULL,
it won't work with jack_client_open() or jack_port_register() etc. because of another reduction (eventually for the ":").

!! This needs to be verified and documentation needs to be reviewed. !!

Note: the client name length test still fails, this is a different issue.

This reverts commit dde9f29a8e.

The commit introduced the following compiler error:

[100/255] Compiling posix/JackNetUnixSocket.cpp
../posix/JackNetUnixSocket.cpp: In member function 'int Jack::JackNetUnixSocket::NewSocket()':
../posix/JackNetUnixSocket.cpp:126:32: error: 'tos' was not declared in this scope
         socklen_t len = sizeof(tos);

Flagged by the Debian QA tool.

Mostly automatic search-n-replace of the mistakes flagged.

JACK2 added this function first, but the int return has been always wrong.
When JACK1 added JackPortRenameCallback it used the proper return.

Now that JACK1 supports port renames, devs will start to use it.
(previously it didn't work properly because of the missing jack_client_t* arg)

Some code might be broken because of this, but it's a very simple change,
and existing code would have been broken when changing JACK1 to JACK2.

Finally, JACK2 code never uses the int return value of this callback.
So there's no real reason to NOT change this.

git-svn-id: http://subversion.jackaudio.org/jack/jack2/trunk/jackmp@4684 0c269be4-1314-0410-8aa9-9f06e86f4224

git-svn-id: http://subversion.jackaudio.org/jack/jack2/trunk/jackmp@4670 0c269be4-1314-0410-8aa9-9f06e86f4224

gcc (Gentoo 4.4.5 p1.2, pie-0.4.5) 4.4.5

git-svn-id: http://subversion.jackaudio.org/jack/jack2/trunk/jackmp@4363 0c269be4-1314-0410-8aa9-9f06e86f4224

git-svn-id: http://subversion.jackaudio.org/jack/jack2/branches/libjacknet@4307 0c269be4-1314-0410-8aa9-9f06e86f4224

git-svn-id: http://subversion.jackaudio.org/jack/jack2/trunk/jackmp@4288 0c269be4-1314-0410-8aa9-9f06e86f4224

git-svn-id: http://subversion.jackaudio.org/jack/jack2/branches/libjacknet@4084 0c269be4-1314-0410-8aa9-9f06e86f4224

git-svn-id: http://subversion.jackaudio.org/jack/jack2/trunk/jackmp@4067 0c269be4-1314-0410-8aa9-9f06e86f4224

git-svn-id: http://subversion.jackaudio.org/jack/jack2/branches/libjacknet@4042 0c269be4-1314-0410-8aa9-9f06e86f4224

git-svn-id: http://subversion.jackaudio.org/jack/jack2/trunk/jackmp@4006 0c269be4-1314-0410-8aa9-9f06e86f4224

git-svn-id: http://subversion.jackaudio.org/jack/jack2/branches/libjacknet@3917 0c269be4-1314-0410-8aa9-9f06e86f4224

git-svn-id: http://subversion.jackaudio.org/jack/jack2/trunk/jackmp@3909 0c269be4-1314-0410-8aa9-9f06e86f4224

git-svn-id: http://subversion.jackaudio.org/jack/jack2/branches/libjacknet@3900 0c269be4-1314-0410-8aa9-9f06e86f4224

git-svn-id: http://subversion.jackaudio.org/jack/jack2/trunk/jackmp@3851 0c269be4-1314-0410-8aa9-9f06e86f4224

git-svn-id: http://subversion.jackaudio.org/jack/jack2/trunk/jackmp@3835 0c269be4-1314-0410-8aa9-9f06e86f4224

git-svn-id: http://subversion.jackaudio.org/jack/jack2/branches/libjacknet@3814 0c269be4-1314-0410-8aa9-9f06e86f4224

git-svn-id: http://subversion.jackaudio.org/jack/jack2/trunk/jackmp@3732 0c269be4-1314-0410-8aa9-9f06e86f4224

git-svn-id: http://subversion.jackaudio.org/jack/jack2/branches/libjacknet@3685 0c269be4-1314-0410-8aa9-9f06e86f4224

git-svn-id: http://subversion.jackaudio.org/jack/jack2/trunk/jackmp@3654 0c269be4-1314-0410-8aa9-9f06e86f4224

git-svn-id: http://subversion.jackaudio.org/jack/jack2/branches/libjacknet@3483 0c269be4-1314-0410-8aa9-9f06e86f4224

git-svn-id: http://subversion.jackaudio.org/jack/jack2/trunk/jackmp@3465 0c269be4-1314-0410-8aa9-9f06e86f4224

git-svn-id: http://subversion.jackaudio.org/jack/jack2/trunk/jackmp@3119 0c269be4-1314-0410-8aa9-9f06e86f4224

git-svn-id: http://subversion.jackaudio.org/jack/jack2/trunk/jackmp@2878 0c269be4-1314-0410-8aa9-9f06e86f4224

git-svn-id: http://subversion.jackaudio.org/jack/jack2/trunk/jackmp@2797 0c269be4-1314-0410-8aa9-9f06e86f4224

git-svn-id: http://subversion.jackaudio.org/jack/jack2/trunk/jackmp@2458 0c269be4-1314-0410-8aa9-9f06e86f4224

git-svn-id: http://subversion.jackaudio.org/jack/jack2/trunk/jackmp@2431 0c269be4-1314-0410-8aa9-9f06e86f4224

git-svn-id: http://subversion.jackaudio.org/jack/jack2/trunk/jackmp@2102 0c269be4-1314-0410-8aa9-9f06e86f4224

git-svn-id: http://subversion.jackaudio.org/jack/jack2/trunk/jackmp@1970 0c269be4-1314-0410-8aa9-9f06e86f4224