Forwarded from
<https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=728710>

JACK2 added this function first, but the int return has been always wrong.
When JACK1 added JackPortRenameCallback it used the proper return.

Now that JACK1 supports port renames, devs will start to use it.
(previously it didn't work properly because of the missing jack_client_t* arg)

Some code might be broken because of this, but it's a very simple change,
and existing code would have been broken when changing JACK1 to JACK2.

Finally, JACK2 code never uses the int return value of this callback.
So there's no real reason to NOT change this.

For instance, if compiling with gcc and the option --stc=c++11, WIN32 is not defined.
See http://webcache.googleusercontent.com/search?q=cache:amvfgAUCdsgJ:sourceforge.net/p/mingw-w64/mailman/message/31850993/+&cd=4&hl=en&ct=clnk&gl=no
http://sourceforge.net/p/mingw-w64/mailman/message/31850993/

return value of JackGenericClientChannel->SetTimebaseCallback() instead
of -1 where there is a conditional request

This driver is very similar to the JackNetDriver, but instead of connecting
through the network, it connects to its upstream server through standard jack
API. So it can only reach local servers which must be running as the same user
or in promiscuous mode.

The main use case is the multi-user, multi-session, shared workstation:

 - a classic server with hw driver is launched system-wide at boot time, in
   promiscuous mode, optionaly restricted to the audio group
 - in each user session, a jackdbus server is automatically started with
   JackProxyDriver as master driver, automatically connected to the
   system-wide one
 - optionaly, each user run PulseAudio with a pulse-jack bridge

This wrapper driver has the same usage as its parent JackWaitThreadedDriver,
but for non-threaded (callback) drivers. After waiting for Initialize to
return, its main thread simply ends instead of calling the driver's Process
method in a loop. The decorated driver, which must extends JackRestarerDriver
instead of JackWaiterDriver, can restart the wait cycle by calling its
RestartWait method.

This makes it possible to use JackWaitThreadedDriver as a base class
for a non-threaded version.

No biggie, but since this is C++, let's use the C++ includes.

- use unsigned int instead of int (socklen_t is supposed to be unsigned)
- converted inconsistent line Ending to UNIX line ending

- separated two causes of an error
- gave the win32 "lost signal" case a more descriptive message

- moved platform dependend code into scope its respective #ifdef
- killed one useless 'goto' with great pleasure
- introduced duplicate code to preserve behavior (fallthrough case)

Setting the JACK_NO_AUDIO_RESERVATION environment variable let one skip the
audio reservation bits.
The main use case is a system-wide jackd promiscuous instance launched at boot
time. In such a case no session bus is available, and reservation doesn't
really makes sense anyway.

Forwarded from http://bugs.debian.org/757820