From e3ce8807cf858bd37a24cef266709754a99f329c Mon Sep 17 00:00:00 2001 From: sletz Date: Fri, 21 Mar 2008 08:11:45 +0000 Subject: [PATCH] Cleanup git-svn-id: http://subversion.jackaudio.org/jack/jack2/trunk/jackmp@2065 0c269be4-1314-0410-8aa9-9f06e86f4224 --- common/JackAPI.cpp | 4 ++++ common/JackTransportEngine.cpp | 4 ++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/common/JackAPI.cpp b/common/JackAPI.cpp index ed5573b0..a1e72a95 100644 --- a/common/JackAPI.cpp +++ b/common/JackAPI.cpp @@ -501,6 +501,10 @@ EXPORT int jack_recompute_total_latencies(jack_client_t* ext_client) } } +/* +This is unsafe if case of concurrent access, and should be "serialized" doing a server call. +*/ + EXPORT int jack_port_set_name(jack_port_t* port, const char* name) { #ifdef __CLIENTDEBUG__ diff --git a/common/JackTransportEngine.cpp b/common/JackTransportEngine.cpp index a2a2b3f4..dfca076d 100644 --- a/common/JackTransportEngine.cpp +++ b/common/JackTransportEngine.cpp @@ -101,7 +101,7 @@ void JackTransportEngine::MakeAllStartingLocating(JackClientInterface** table) for (int i = REAL_REFNUM; i < CLIENT_NUM; i++) { JackClientInterface* client = table[i]; if (client) { - // Inactive clients don't have their process function called at all, so they appear as already "rolling" for the transport.... + // Inactive clients don't have their process function called at all, so they must appear as already "rolling" for the transport.... client->GetClientControl()->fTransportState = (client->GetClientControl()->fActive) ? JackTransportStarting : JackTransportRolling; client->GetClientControl()->fTransportSync = true; client->GetClientControl()->fTransportTimebase = true; @@ -138,7 +138,7 @@ void JackTransportEngine::MakeAllLocating(JackClientInterface** table) } // RT -void JackTransportEngine::CycleBegin(jack_nframes_t frame_rate, jack_time_t time) // really needed?? (would be done in CycleEnd...) +void JackTransportEngine::CycleBegin(jack_nframes_t frame_rate, jack_time_t time) { jack_position_t* pending = WriteNextStateStart(1); // Update "pending" state pending->usecs = time;