diff --git a/common/JackAPI.cpp b/common/JackAPI.cpp index b3d7c343..98d53dfd 100644 --- a/common/JackAPI.cpp +++ b/common/JackAPI.cpp @@ -1983,7 +1983,7 @@ LIB_EXPORT char *jack_client_get_uuid(jack_client_t* ext_client) return NULL; } else { char retval[16]; - snprintf(retval, sizeof(retval), "%d", client->GetClientControl()->fSessionID); + snprintf(retval, sizeof(retval), "%" PRIu64, client->GetClientControl()->fSessionID); return strdup(retval); } } diff --git a/common/JackChannel.h b/common/JackChannel.h index c4188b3c..56687043 100644 --- a/common/JackChannel.h +++ b/common/JackChannel.h @@ -99,7 +99,7 @@ class JackClientChannelInterface {} // Open the Server/Client connection - virtual int Open(const char* server_name, const char* name, int uuid, char* name_res, JackClient* obj, jack_options_t options, jack_status_t* status) + virtual int Open(const char* server_name, const char* name, jack_uuid_t uuid, char* name_res, JackClient* obj, jack_options_t options, jack_status_t* status) { return 0; } @@ -123,9 +123,9 @@ class JackClientChannelInterface return -1; } - virtual void ClientCheck(const char* name, int uuid, char* name_res, int protocol, int options, int* status, int* result, int open) + virtual void ClientCheck(const char* name, jack_uuid_t uuid, char* name_res, int protocol, int options, int* status, int* result, int open) {} - virtual void ClientOpen(const char* name, int pid, int uuid, int* shared_engine, int* shared_client, int* shared_graph, int* result) + virtual void ClientOpen(const char* name, int pid, jack_uuid_t uuid, int* shared_engine, int* shared_client, int* shared_graph, int* result) {} virtual void ClientOpen(const char* name, int* ref, JackEngineControl** shared_engine, JackGraphManager** shared_manager, JackClientInterface* client, int* result) {} @@ -169,7 +169,7 @@ class JackClientChannelInterface {} virtual void InternalClientHandle(int refnum, const char* client_name, int* status, int* int_ref, int* result) {} - virtual void InternalClientLoad(int refnum, const char* client_name, const char* so_name, const char* objet_data, int options, int* status, int* int_ref, int uuid, int* result) + virtual void InternalClientLoad(int refnum, const char* client_name, const char* so_name, const char* objet_data, int options, int* status, int* int_ref, jack_uuid_t uuid, int* result) {} virtual void InternalClientUnload(int refnum, int int_ref, int* status, int* result) {} diff --git a/common/JackClient.cpp b/common/JackClient.cpp index 5befdfbd..cdd99af0 100644 --- a/common/JackClient.cpp +++ b/common/JackClient.cpp @@ -309,7 +309,7 @@ int JackClient::ClientNotify(int refnum, const char* name, int notify, int sync, event->session_dir = strdup(message); event->command_line = NULL; event->flags = (jack_session_flags_t)0; - snprintf(uuid_buf, sizeof(uuid_buf), "%d", GetClientControl()->fSessionID); + snprintf(uuid_buf, sizeof(uuid_buf), "%" PRIu64, GetClientControl()->fSessionID); event->client_uuid = strdup(uuid_buf); fSessionReply = kPendingSessionReply; // Session callback may change fSessionReply by directly using jack_session_reply diff --git a/common/JackClient.h b/common/JackClient.h index 67cd611d..3270933a 100644 --- a/common/JackClient.h +++ b/common/JackClient.h @@ -131,7 +131,7 @@ class SERVER_EXPORT JackClient : public JackClientInterface, public JackRunnable JackClient(JackSynchro* table); virtual ~JackClient(); - virtual int Open(const char* server_name, const char* name, int uuid, jack_options_t options, jack_status_t* status) = 0; + virtual int Open(const char* server_name, const char* name, jack_uuid_t uuid, jack_options_t options, jack_status_t* status) = 0; virtual int Close(); virtual JackGraphManager* GetGraphManager() const = 0; diff --git a/common/JackClientControl.h b/common/JackClientControl.h index 5037c2fd..107345fa 100644 --- a/common/JackClientControl.h +++ b/common/JackClientControl.h @@ -50,7 +50,7 @@ struct JackClientControl : public JackShmMemAble char fSessionCommand[JACK_SESSION_COMMAND_SIZE]; jack_session_flags_t fSessionFlags; - JackClientControl(const char* name, int pid, int refnum, int uuid) + JackClientControl(const char* name, int pid, int refnum, jack_uuid_t uuid) { Init(name, pid, refnum, uuid); } @@ -65,7 +65,7 @@ struct JackClientControl : public JackShmMemAble Init("", 0, -1, 0); } - void Init(const char* name, int pid, int refnum, int uuid) + void Init(const char* name, int pid, int refnum, jack_uuid_t uuid) { strcpy(fName, name); for (int i = 0; i < kMaxNotification; i++) { diff --git a/common/JackDebugClient.cpp b/common/JackDebugClient.cpp index 7c1f539a..a7d11f9e 100644 --- a/common/JackDebugClient.cpp +++ b/common/JackDebugClient.cpp @@ -79,7 +79,7 @@ JackDebugClient::~JackDebugClient() delete fClient; } -int JackDebugClient::Open(const char* server_name, const char* name, int uuid, jack_options_t options, jack_status_t* status) +int JackDebugClient::Open(const char* server_name, const char* name, jack_uuid_t uuid, jack_options_t options, jack_status_t* status) { int res = fClient->Open(server_name, name, uuid, options, status); char provstr[256]; diff --git a/common/JackDebugClient.h b/common/JackDebugClient.h index efe71dee..9e82f1d4 100644 --- a/common/JackDebugClient.h +++ b/common/JackDebugClient.h @@ -68,7 +68,7 @@ class JackDebugClient : public JackClient JackDebugClient(JackClient* fTheClient); virtual ~JackDebugClient(); - virtual int Open(const char* server_name, const char* name, int uuid, jack_options_t options, jack_status_t* status); + virtual int Open(const char* server_name, const char* name, jack_uuid_t uuid, jack_options_t options, jack_status_t* status); int Close(); virtual JackGraphManager* GetGraphManager() const; diff --git a/common/JackEngine.cpp b/common/JackEngine.cpp index 62edc90c..85dc245e 100644 --- a/common/JackEngine.cpp +++ b/common/JackEngine.cpp @@ -476,7 +476,7 @@ int JackEngine::InternalClientUnload(int refnum, int* status) // Client management //------------------- -int JackEngine::ClientCheck(const char* name, int uuid, char* name_res, int protocol, int options, int* status) +int JackEngine::ClientCheck(const char* name, jack_uuid_t uuid, char* name_res, int protocol, int options, int* status) { // Clear status *status = 0; @@ -602,7 +602,7 @@ int JackEngine::GetClientRefNum(const char* name) } // Used for external clients -int JackEngine::ClientExternalOpen(const char* name, int pid, int uuid, int* ref, int* shared_engine, int* shared_client, int* shared_graph_manager) +int JackEngine::ClientExternalOpen(const char* name, int pid, jack_uuid_t uuid, int* ref, int* shared_engine, int* shared_client, int* shared_graph_manager) { char real_name[JACK_CLIENT_NAME_SIZE + 1]; diff --git a/common/JackEngine.h b/common/JackEngine.h index a389de7b..8b5136c9 100644 --- a/common/JackEngine.h +++ b/common/JackEngine.h @@ -105,9 +105,9 @@ class SERVER_EXPORT JackEngine : public JackLockAble int Close(); // Client management - int ClientCheck(const char* name, int uuid, char* name_res, int protocol, int options, int* status); + int ClientCheck(const char* name, jack_uuid_t uuid, char* name_res, int protocol, int options, int* status); - int ClientExternalOpen(const char* name, int pid, int uuid, int* ref, int* shared_engine, int* shared_client, int* shared_graph_manager); + int ClientExternalOpen(const char* name, int pid, jack_uuid_t uuid, int* ref, int* shared_engine, int* shared_client, int* shared_graph_manager); int ClientInternalOpen(const char* name, int* ref, JackEngineControl** shared_engine, JackGraphManager** shared_manager, JackClientInterface* client, bool wait); int ClientExternalClose(int refnum); diff --git a/common/JackExternalClient.cpp b/common/JackExternalClient.cpp index 9f240f9c..8a4995cc 100644 --- a/common/JackExternalClient.cpp +++ b/common/JackExternalClient.cpp @@ -41,7 +41,7 @@ int JackExternalClient::ClientNotify(int refnum, const char* name, int notify, i return result; } -int JackExternalClient::Open(const char* name, int pid, int refnum, int uuid, int* shared_client) +int JackExternalClient::Open(const char* name, int pid, int refnum, jack_uuid_t uuid, int* shared_client) { try { diff --git a/common/JackExternalClient.h b/common/JackExternalClient.h index 19318a33..00b26818 100644 --- a/common/JackExternalClient.h +++ b/common/JackExternalClient.h @@ -46,7 +46,7 @@ class JackExternalClient : public JackClientInterface JackExternalClient(); virtual ~JackExternalClient(); - int Open(const char* name, int pid, int refnum, int uuid, int* shared_client); + int Open(const char* name, int pid, int refnum, jack_uuid_t uuid, int* shared_client); int Close(); int ClientNotify(int refnum, const char* name, int notify, int sync, const char* message, int value1, int value2); diff --git a/common/JackGenericClientChannel.cpp b/common/JackGenericClientChannel.cpp index 047d7bfa..96401d29 100644 --- a/common/JackGenericClientChannel.cpp +++ b/common/JackGenericClientChannel.cpp @@ -97,7 +97,7 @@ void JackGenericClientChannel::ServerAsyncCall(JackRequest* req, JackResult* res } } -void JackGenericClientChannel::ClientCheck(const char* name, int uuid, char* name_res, int protocol, int options, int* status, int* result, int open) +void JackGenericClientChannel::ClientCheck(const char* name, jack_uuid_t uuid, char* name_res, int protocol, int options, int* status, int* result, int open) { JackClientCheckRequest req(name, protocol, options, uuid, open); JackClientCheckResult res; @@ -106,7 +106,7 @@ void JackGenericClientChannel::ClientCheck(const char* name, int uuid, char* nam strcpy(name_res, res.fName); } -void JackGenericClientChannel::ClientOpen(const char* name, int pid, int uuid, int* shared_engine, int* shared_client, int* shared_graph, int* result) +void JackGenericClientChannel::ClientOpen(const char* name, int pid, jack_uuid_t uuid, int* shared_engine, int* shared_client, int* shared_graph, int* result) { JackClientOpenRequest req(name, pid, uuid); JackClientOpenResult res; @@ -285,7 +285,7 @@ void JackGenericClientChannel::InternalClientHandle(int refnum, const char* clie *status = res.fStatus; } -void JackGenericClientChannel::InternalClientLoad(int refnum, const char* client_name, const char* so_name, const char* objet_data, int options, int* status, int* int_ref, int uuid, int* result) +void JackGenericClientChannel::InternalClientLoad(int refnum, const char* client_name, const char* so_name, const char* objet_data, int options, int* status, int* int_ref, jack_uuid_t uuid, int* result) { JackInternalClientLoadRequest req(refnum, client_name, so_name, objet_data, options, uuid); JackInternalClientLoadResult res; diff --git a/common/JackGenericClientChannel.h b/common/JackGenericClientChannel.h index 04195a2a..b2c7b4ad 100644 --- a/common/JackGenericClientChannel.h +++ b/common/JackGenericClientChannel.h @@ -47,7 +47,7 @@ class JackGenericClientChannel : public detail::JackClientChannelInterface JackGenericClientChannel(); virtual ~JackGenericClientChannel(); - virtual int Open(const char* server_name, const char* name, int uuid, char* name_res, JackClient* obj, jack_options_t options, jack_status_t* status) { return -1; } + virtual int Open(const char* server_name, const char* name, jack_uuid_t uuid, char* name_res, JackClient* obj, jack_options_t options, jack_status_t* status) { return -1; } virtual void Close() {} virtual int Start() { return -1; } @@ -55,8 +55,8 @@ class JackGenericClientChannel : public detail::JackClientChannelInterface int ServerCheck(const char* server_name); - void ClientCheck(const char* name, int uuid, char* name_res, int protocol, int options, int* status, int* result, int open); - void ClientOpen(const char* name, int pid, int uuid, int* shared_engine, int* shared_client, int* shared_graph, int* result); + void ClientCheck(const char* name, jack_uuid_t uuid, char* name_res, int protocol, int options, int* status, int* result, int open); + void ClientOpen(const char* name, int pid, jack_uuid_t uuid, int* shared_engine, int* shared_client, int* shared_graph, int* result); void ClientClose(int refnum, int* result); void ClientActivate(int refnum, int is_real_time, int* result); @@ -83,7 +83,7 @@ class JackGenericClientChannel : public detail::JackClientChannelInterface void GetInternalClientName(int refnum, int int_ref, char* name_res, int* result); void InternalClientHandle(int refnum, const char* client_name, int* status, int* int_ref, int* result); - void InternalClientLoad(int refnum, const char* client_name, const char* so_name, const char* objet_data, int options, int* status, int* int_ref, int uuid, int* result); + void InternalClientLoad(int refnum, const char* client_name, const char* so_name, const char* objet_data, int options, int* status, int* int_ref, jack_uuid_t uuid, int* result); void InternalClientUnload(int refnum, int int_ref, int* status, int* result); // Session API diff --git a/common/JackInternalClient.cpp b/common/JackInternalClient.cpp index 0668516a..ca19316d 100644 --- a/common/JackInternalClient.cpp +++ b/common/JackInternalClient.cpp @@ -63,7 +63,7 @@ JackInternalClient::~JackInternalClient() delete fChannel; } -int JackInternalClient::Open(const char* server_name, const char* name, int uuid, jack_options_t options, jack_status_t* status) +int JackInternalClient::Open(const char* server_name, const char* name, jack_uuid_t uuid, jack_options_t options, jack_status_t* status) { int result; jack_log("JackInternalClient::Open name = %s", name); @@ -215,7 +215,7 @@ JackLoadableInternalClient::~JackLoadableInternalClient() } } -int JackLoadableInternalClient1::Open(const char* server_name, const char* name, int uuid, jack_options_t options, jack_status_t* status) +int JackLoadableInternalClient1::Open(const char* server_name, const char* name, jack_uuid_t uuid, jack_options_t options, jack_status_t* status) { int res = -1; @@ -231,7 +231,7 @@ int JackLoadableInternalClient1::Open(const char* server_name, const char* name, return res; } -int JackLoadableInternalClient2::Open(const char* server_name, const char* name, int uuid, jack_options_t options, jack_status_t* status) +int JackLoadableInternalClient2::Open(const char* server_name, const char* name, jack_uuid_t uuid, jack_options_t options, jack_status_t* status) { int res = -1; diff --git a/common/JackInternalClient.h b/common/JackInternalClient.h index 28c11d4d..ca5ac0bd 100644 --- a/common/JackInternalClient.h +++ b/common/JackInternalClient.h @@ -46,7 +46,7 @@ class JackInternalClient : public JackClient JackInternalClient(JackServer* server, JackSynchro* table); virtual ~JackInternalClient(); - int Open(const char* server_name, const char* name, int uuid, jack_options_t options, jack_status_t* status); + int Open(const char* server_name, const char* name, jack_uuid_t uuid, jack_options_t options, jack_status_t* status); void ShutDown(jack_status_t code, const char* message); JackGraphManager* GetGraphManager() const; @@ -100,7 +100,7 @@ class JackLoadableInternalClient1 : public JackLoadableInternalClient {} int Init(const char* so_name); - int Open(const char* server_name, const char* name, int uuid, jack_options_t options, jack_status_t* status); + int Open(const char* server_name, const char* name, jack_uuid_t uuid, jack_options_t options, jack_status_t* status); }; @@ -119,7 +119,7 @@ class JackLoadableInternalClient2 : public JackLoadableInternalClient {} int Init(const char* so_name); - int Open(const char* server_name, const char* name, int uuid, jack_options_t options, jack_status_t* status); + int Open(const char* server_name, const char* name, jack_uuid_t uuid, jack_options_t options, jack_status_t* status); }; diff --git a/common/JackInternalClientChannel.h b/common/JackInternalClientChannel.h index ce0084c4..fd75e27f 100644 --- a/common/JackInternalClientChannel.h +++ b/common/JackInternalClientChannel.h @@ -44,7 +44,7 @@ class JackInternalClientChannel : public detail::JackClientChannelInterface virtual ~JackInternalClientChannel() {} - void ClientCheck(const char* name, int uuid, char* name_res, int protocol, int options, int* status, int* result, int open) + void ClientCheck(const char* name, jack_uuid_t uuid, char* name_res, int protocol, int options, int* status, int* result, int open) { *result = fEngine->ClientCheck(name, uuid, name_res, protocol, options, status); } @@ -128,7 +128,7 @@ class JackInternalClientChannel : public detail::JackClientChannelInterface *result = fEngine->InternalClientHandle(client_name, status, int_ref); } - void InternalClientLoad(int refnum, const char* client_name, const char* so_name, const char* objet_data, int options, int* status, int* int_ref, int uuid, int* result) + void InternalClientLoad(int refnum, const char* client_name, const char* so_name, const char* objet_data, int options, int* status, int* int_ref, jack_uuid_t uuid, int* result) { *result = fServer->InternalClientLoad1(client_name, so_name, objet_data, options, int_ref, uuid, status); } diff --git a/common/JackLibClient.cpp b/common/JackLibClient.cpp index 515a5f02..65e70a13 100644 --- a/common/JackLibClient.cpp +++ b/common/JackLibClient.cpp @@ -91,7 +91,7 @@ JackLibClient::~JackLibClient() delete fChannel; } -int JackLibClient::Open(const char* server_name, const char* name, int uuid, jack_options_t options, jack_status_t* status) +int JackLibClient::Open(const char* server_name, const char* name, jack_uuid_t uuid, jack_options_t options, jack_status_t* status) { int shared_engine, shared_client, shared_graph, result; bool res; diff --git a/common/JackLibClient.h b/common/JackLibClient.h index 6077ebe8..9fe5d783 100644 --- a/common/JackLibClient.h +++ b/common/JackLibClient.h @@ -44,7 +44,7 @@ class JackLibClient : public JackClient JackLibClient(JackSynchro* table); virtual ~JackLibClient(); - int Open(const char* server_name, const char* name, int uuid, jack_options_t options, jack_status_t* status); + int Open(const char* server_name, const char* name, jack_uuid_t uuid, jack_options_t options, jack_status_t* status); void ShutDown(jack_status_t code, const char* message); int ClientNotifyImp(int refnum, const char* name, int notify, int sync, const char* message, int value1, int value2); diff --git a/common/JackLockedEngine.h b/common/JackLockedEngine.h index a07eb38e..3e3c8186 100644 --- a/common/JackLockedEngine.h +++ b/common/JackLockedEngine.h @@ -109,14 +109,14 @@ class SERVER_EXPORT JackLockedEngine } // Client management - int ClientCheck(const char* name, int uuid, char* name_res, int protocol, int options, int* status) + int ClientCheck(const char* name, jack_uuid_t uuid, char* name_res, int protocol, int options, int* status) { TRY_CALL JackLock lock(&fEngine); return fEngine.ClientCheck(name, uuid, name_res, protocol, options, status); CATCH_EXCEPTION_RETURN } - int ClientExternalOpen(const char* name, int pid, int uuid, int* ref, int* shared_engine, int* shared_client, int* shared_graph_manager) + int ClientExternalOpen(const char* name, int pid, jack_uuid_t uuid, int* ref, int* shared_engine, int* shared_client, int* shared_graph_manager) { TRY_CALL JackLock lock(&fEngine); diff --git a/common/JackNetTool.cpp b/common/JackNetTool.cpp index b34711c3..c21e5fca 100644 --- a/common/JackNetTool.cpp +++ b/common/JackNetTool.cpp @@ -884,7 +884,7 @@ namespace Jack for (int port_index = 0; port_index < fNPorts; port_index++) { if (fPortBuffer[port_index]) { int res = opus_custom_decode_float(fOpusDecoder[port_index], fCompressedBuffer[port_index], fCompressedSizesByte[port_index], fPortBuffer[port_index], ((nframes == -1) ? fPeriodSize : nframes)); - if (res < 0 || res != ((nframes == -1) ? fPeriodSize : nframes)) { + if (res < 0 || res != ((nframes == -1) ? (int)fPeriodSize : nframes)) { jack_error("opus_custom_decode_float error fCompressedSizeByte = %d res = %d", fCompressedSizesByte[port_index], res); } } diff --git a/common/JackRequest.h b/common/JackRequest.h index 314f84fc..e39f2097 100644 --- a/common/JackRequest.h +++ b/common/JackRequest.h @@ -168,7 +168,7 @@ struct JackClientCheckRequest : public JackRequest { memset(fName, 0, sizeof(fName)); } - JackClientCheckRequest(const char* name, int protocol, int options, int uuid, int open = false) + JackClientCheckRequest(const char* name, int protocol, int options, jack_uuid_t uuid, int open = false) : JackRequest(JackRequest::kClientCheck), fProtocol(protocol), fOptions(options), fUUID(uuid), fOpen(open) { memset(fName, 0, sizeof(fName)); @@ -253,7 +253,7 @@ struct JackClientOpenRequest : public JackRequest { memset(fName, 0, sizeof(fName)); } - JackClientOpenRequest(const char* name, int pid, int uuid): JackRequest(JackRequest::kClientOpen) + JackClientOpenRequest(const char* name, int pid, jack_uuid_t uuid): JackRequest(JackRequest::kClientOpen) { memset(fName, 0, sizeof(fName)); snprintf(fName, sizeof(fName), "%s", name); @@ -1056,7 +1056,7 @@ struct JackInternalClientLoadRequest : public JackRequest memset(fDllName, 0, sizeof(fDllName)); memset(fLoadInitName, 0, sizeof(fLoadInitName)); } - JackInternalClientLoadRequest(int refnum, const char* client_name, const char* so_name, const char* objet_data, int options, int uuid ) + JackInternalClientLoadRequest(int refnum, const char* client_name, const char* so_name, const char* objet_data, int options, jack_uuid_t uuid ) : JackRequest(JackRequest::kInternalClientLoad), fRefNum(refnum), fOptions(options), fUUID(uuid) { memset(fName, 0, sizeof(fName)); diff --git a/common/JackServer.cpp b/common/JackServer.cpp index 5e88cf48..02273f5a 100644 --- a/common/JackServer.cpp +++ b/common/JackServer.cpp @@ -194,21 +194,21 @@ bool JackServer::IsRunning() // Internal clients //------------------ -int JackServer::InternalClientLoad1(const char* client_name, const char* so_name, const char* objet_data, int options, int* int_ref, int uuid, int* status) +int JackServer::InternalClientLoad1(const char* client_name, const char* so_name, const char* objet_data, int options, int* int_ref, jack_uuid_t uuid, int* status) { JackLoadableInternalClient* client = new JackLoadableInternalClient1(JackServerGlobals::fInstance, GetSynchroTable(), objet_data); assert(client); return InternalClientLoadAux(client, so_name, client_name, options, int_ref, uuid, status); } -int JackServer::InternalClientLoad2(const char* client_name, const char* so_name, const JSList * parameters, int options, int* int_ref, int uuid, int* status) +int JackServer::InternalClientLoad2(const char* client_name, const char* so_name, const JSList * parameters, int options, int* int_ref, jack_uuid_t uuid, int* status) { JackLoadableInternalClient* client = new JackLoadableInternalClient2(JackServerGlobals::fInstance, GetSynchroTable(), parameters); assert(client); return InternalClientLoadAux(client, so_name, client_name, options, int_ref, uuid, status); } -int JackServer::InternalClientLoadAux(JackLoadableInternalClient* client, const char* so_name, const char* client_name, int options, int* int_ref, int uuid, int* status) +int JackServer::InternalClientLoadAux(JackLoadableInternalClient* client, const char* so_name, const char* client_name, int options, int* int_ref, jack_uuid_t uuid, int* status) { // Clear status *status = 0; diff --git a/common/JackServer.h b/common/JackServer.h index c1b5b0d8..71192e9e 100644 --- a/common/JackServer.h +++ b/common/JackServer.h @@ -60,7 +60,7 @@ class SERVER_EXPORT JackServer JackSynchro fSynchroTable[CLIENT_NUM]; bool fFreewheel; - int InternalClientLoadAux(JackLoadableInternalClient* client, const char* so_name, const char* client_name, int options, int* int_ref, int uuid, int* status); + int InternalClientLoadAux(JackLoadableInternalClient* client, const char* so_name, const char* client_name, int options, int* int_ref, jack_uuid_t uuid, int* status); public: @@ -84,8 +84,8 @@ class SERVER_EXPORT JackServer int SetFreewheel(bool onoff); // Internals clients - int InternalClientLoad1(const char* client_name, const char* so_name, const char* objet_data, int options, int* int_ref, int uuid, int* status); - int InternalClientLoad2(const char* client_name, const char* so_name, const JSList * parameters, int options, int* int_ref, int uuid, int* status); + int InternalClientLoad1(const char* client_name, const char* so_name, const char* objet_data, int options, int* int_ref, jack_uuid_t uuid, int* status); + int InternalClientLoad2(const char* client_name, const char* so_name, const JSList * parameters, int options, int* int_ref, jack_uuid_t uuid, int* status); // Internal session file int LoadInternalSessionFile(const char* file); diff --git a/dbus/controller_iface_patchbay.c b/dbus/controller_iface_patchbay.c index 8e754afc..765d4690 100644 --- a/dbus/controller_iface_patchbay.c +++ b/dbus/controller_iface_patchbay.c @@ -1647,7 +1647,7 @@ jack_controller_port_connect_callback( } } -int jack_controller_port_rename_callback(jack_port_id_t port, const char * old_name, const char * new_name, void * context) +void jack_controller_port_rename_callback(jack_port_id_t port, const char * old_name, const char * new_name, void * context) { struct jack_graph_port * port_ptr; const char * port_new_short_name; @@ -1660,7 +1660,7 @@ int jack_controller_port_rename_callback(jack_port_id_t port, const char * old_n if (port_new_short_name == NULL) { jack_error("renamed port new name '%s' does not contain ':' separator char", new_name); - return -1; + return; } port_new_short_name++; /* skip ':' separator char */ @@ -1669,7 +1669,7 @@ int jack_controller_port_rename_callback(jack_port_id_t port, const char * old_n if (port_old_short_name == NULL) { jack_error("renamed port old name '%s' does not contain ':' separator char", old_name); - return -1; + return; } port_old_short_name++; /* skip ':' separator char */ @@ -1678,14 +1678,14 @@ int jack_controller_port_rename_callback(jack_port_id_t port, const char * old_n if (port_ptr == NULL) { jack_error("renamed port '%s' not found", old_name); - return -1; + return; } name_buffer = strdup(port_new_short_name); if (name_buffer == NULL) { jack_error("strdup() call for port name '%s' failed.", port_new_short_name); - return 1; + return; } free(port_ptr->name); @@ -1702,8 +1702,6 @@ int jack_controller_port_rename_callback(jack_port_id_t port, const char * old_n port_ptr->name); jack_controller_patchbay_send_signal_graph_changed(patchbay_ptr->graph.version); pthread_mutex_unlock(&patchbay_ptr->lock); - - return 0; } #undef controller_ptr diff --git a/dbus/sigsegv.c b/dbus/sigsegv.c index c5321f1d..de316429 100644 --- a/dbus/sigsegv.c +++ b/dbus/sigsegv.c @@ -61,10 +61,12 @@ static void signal_segv(int signum, siginfo_t* info, void*ptr) static void signal_segv(int signum, siginfo_t* info, void*ptr) { static const char *si_codes[3] = {"", "SEGV_MAPERR", "SEGV_ACCERR"}; - size_t i; const char *si_code_str; ucontext_t *ucontext = (ucontext_t*)ptr; +#if defined(HAVE_UCONTEXT) && defined(HAVE_NGREG) + size_t i; +#endif #if defined(SIGSEGV_STACK_X86) || defined(SIGSEGV_STACK_IA64) int f = 0; Dl_info dlinfo; diff --git a/example-clients/netsource.c b/example-clients/netsource.c index 6cf8c698..bc63c732 100644 --- a/example-clients/netsource.c +++ b/example-clients/netsource.c @@ -62,6 +62,10 @@ Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. #include #endif +#ifndef CUSTOM_MODES +#define CUSTOM_MODES // for opus_custom_decoder_init +#endif + #if HAVE_OPUS #include #include diff --git a/linux/JackLinuxFutex.cpp b/linux/JackLinuxFutex.cpp index 415a8b95..deff006b 100644 --- a/linux/JackLinuxFutex.cpp +++ b/linux/JackLinuxFutex.cpp @@ -138,7 +138,10 @@ bool JackLinuxFutex::Allocate(const char* name, const char* server_name, int val return false; } - ftruncate(fSharedMem, sizeof(FutexData)); + if (ftruncate(fSharedMem, sizeof(FutexData)) != 0) { + jack_error("Allocate: can't set shared memory size in named futex name = %s err = %s", fName, strerror(errno)); + return false; + } if (fPromiscuous && (jack_promiscuous_perms(fSharedMem, fName, fPromiscuousGid) < 0)) { close(fSharedMem); diff --git a/linux/firewire/ffado_driver.h b/linux/firewire/ffado_driver.h index a06c1361..8ee387b2 100644 --- a/linux/firewire/ffado_driver.h +++ b/linux/firewire/ffado_driver.h @@ -86,7 +86,7 @@ #define debugError(format, args...) jack_error( "firewire ERR: %s:%d (%s): " format, __FILE__, __LINE__, __FUNCTION__, ##args ) #define debugPrint(Level, format, args...) if(DEBUG_LEVEL & (Level)) jack_error("DEBUG %s:%d (%s) :" format, __FILE__, __LINE__, __FUNCTION__, ##args ); #define debugPrintShort(Level, format, args...) if(DEBUG_LEVEL & (Level)) jack_error( format,##args ); -#define debugPrintWithTimeStamp(Level, format, args...) if(DEBUG_LEVEL & (Level)) jack_error( "%16lu: "format, debugGetCurrentUTime(),##args ); +#define debugPrintWithTimeStamp(Level, format, args...) if(DEBUG_LEVEL & (Level)) jack_error( "%16lu: " format, debugGetCurrentUTime(), ##args ); #define SEGFAULT int *test=NULL; *test=1; #else #define DEBUG_LEVEL diff --git a/posix/JackSocketClientChannel.cpp b/posix/JackSocketClientChannel.cpp index 8538f034..3f02daff 100644 --- a/posix/JackSocketClientChannel.cpp +++ b/posix/JackSocketClientChannel.cpp @@ -39,7 +39,7 @@ JackSocketClientChannel::~JackSocketClientChannel() delete fNotificationSocket; } -int JackSocketClientChannel::Open(const char* server_name, const char* name, int uuid, char* name_res, JackClient* client, jack_options_t options, jack_status_t* status) +int JackSocketClientChannel::Open(const char* server_name, const char* name, jack_uuid_t uuid, char* name_res, JackClient* client, jack_options_t options, jack_status_t* status) { int result = 0; jack_log("JackSocketClientChannel::Open name = %s", name); diff --git a/posix/JackSocketClientChannel.h b/posix/JackSocketClientChannel.h index ff753d20..1dc0ed7b 100644 --- a/posix/JackSocketClientChannel.h +++ b/posix/JackSocketClientChannel.h @@ -49,7 +49,7 @@ class JackSocketClientChannel : public JackGenericClientChannel, public JackRunn JackSocketClientChannel(); virtual ~JackSocketClientChannel(); - int Open(const char* server_name, const char* name, int uuid, char* name_res, JackClient* client, jack_options_t options, jack_status_t* status); + int Open(const char* server_name, const char* name, jack_uuid_t uuid, char* name_res, JackClient* client, jack_options_t options, jack_status_t* status); void Close(); int Start(); diff --git a/windows/JackWinNamedPipeClientChannel.cpp b/windows/JackWinNamedPipeClientChannel.cpp index 8d94b9e5..64c56102 100644 --- a/windows/JackWinNamedPipeClientChannel.cpp +++ b/windows/JackWinNamedPipeClientChannel.cpp @@ -38,7 +38,7 @@ JackWinNamedPipeClientChannel::~JackWinNamedPipeClientChannel() delete fRequest; } -int JackWinNamedPipeClientChannel::Open(const char* server_name, const char* name, int uuid, char* name_res, JackClient* client, jack_options_t options, jack_status_t* status) +int JackWinNamedPipeClientChannel::Open(const char* server_name, const char* name, jack_uuid_t uuid, char* name_res, JackClient* client, jack_options_t options, jack_status_t* status) { int result = 0; jack_log("JackWinNamedPipeClientChannel::Open name = %s", name); diff --git a/windows/JackWinNamedPipeClientChannel.h b/windows/JackWinNamedPipeClientChannel.h index 6542399d..298cb5c2 100644 --- a/windows/JackWinNamedPipeClientChannel.h +++ b/windows/JackWinNamedPipeClientChannel.h @@ -49,7 +49,7 @@ class JackWinNamedPipeClientChannel : public JackGenericClientChannel, public Ja JackWinNamedPipeClientChannel(); virtual ~JackWinNamedPipeClientChannel(); - int Open(const char* server_name, const char* name, int uuid, char* name_res, JackClient* client, jack_options_t options, jack_status_t* status); + int Open(const char* server_name, const char* name, jack_uuid_t uuid, char* name_res, JackClient* client, jack_options_t options, jack_status_t* status); void Close(); int Start();