You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

843 lines
30KB

  1. \input texinfo @c -*- texinfo -*-
  2. @documentencoding UTF-8
  3. @settitle Developer Documentation
  4. @titlepage
  5. @center @titlefont{Developer Documentation}
  6. @end titlepage
  7. @top
  8. @contents
  9. @chapter Developers Guide
  10. @section Notes for external developers
  11. This document is mostly useful for internal FFmpeg developers.
  12. External developers who need to use the API in their application should
  13. refer to the API doxygen documentation in the public headers, and
  14. check the examples in @file{doc/examples} and in the source code to
  15. see how the public API is employed.
  16. You can use the FFmpeg libraries in your commercial program, but you
  17. are encouraged to @emph{publish any patch you make}. In this case the
  18. best way to proceed is to send your patches to the ffmpeg-devel
  19. mailing list following the guidelines illustrated in the remainder of
  20. this document.
  21. For more detailed legal information about the use of FFmpeg in
  22. external programs read the @file{LICENSE} file in the source tree and
  23. consult @url{https://ffmpeg.org/legal.html}.
  24. @section Contributing
  25. There are 3 ways by which code gets into FFmpeg.
  26. @itemize @bullet
  27. @item Submitting patches to the main developer mailing list.
  28. See @ref{Submitting patches} for details.
  29. @item Directly committing changes to the main tree.
  30. @item Committing changes to a git clone, for example on github.com or
  31. gitorious.org. And asking us to merge these changes.
  32. @end itemize
  33. Whichever way, changes should be reviewed by the maintainer of the code
  34. before they are committed. And they should follow the @ref{Coding Rules}.
  35. The developer making the commit and the author are responsible for their changes
  36. and should try to fix issues their commit causes.
  37. @anchor{Coding Rules}
  38. @section Coding Rules
  39. @subsection Code formatting conventions
  40. There are the following guidelines regarding the indentation in files:
  41. @itemize @bullet
  42. @item
  43. Indent size is 4.
  44. @item
  45. The TAB character is forbidden outside of Makefiles as is any
  46. form of trailing whitespace. Commits containing either will be
  47. rejected by the git repository.
  48. @item
  49. You should try to limit your code lines to 80 characters; however, do so if
  50. and only if this improves readability.
  51. @item
  52. K&R coding style is used.
  53. @end itemize
  54. The presentation is one inspired by 'indent -i4 -kr -nut'.
  55. The main priority in FFmpeg is simplicity and small code size in order to
  56. minimize the bug count.
  57. @subsection Comments
  58. Use the JavaDoc/Doxygen format (see examples below) so that code documentation
  59. can be generated automatically. All nontrivial functions should have a comment
  60. above them explaining what the function does, even if it is just one sentence.
  61. All structures and their member variables should be documented, too.
  62. Avoid Qt-style and similar Doxygen syntax with @code{!} in it, i.e. replace
  63. @code{//!} with @code{///} and similar. Also @@ syntax should be employed
  64. for markup commands, i.e. use @code{@@param} and not @code{\param}.
  65. @example
  66. /**
  67. * @@file
  68. * MPEG codec.
  69. * @@author ...
  70. */
  71. /**
  72. * Summary sentence.
  73. * more text ...
  74. * ...
  75. */
  76. typedef struct Foobar @{
  77. int var1; /**< var1 description */
  78. int var2; ///< var2 description
  79. /** var3 description */
  80. int var3;
  81. @} Foobar;
  82. /**
  83. * Summary sentence.
  84. * more text ...
  85. * ...
  86. * @@param my_parameter description of my_parameter
  87. * @@return return value description
  88. */
  89. int myfunc(int my_parameter)
  90. ...
  91. @end example
  92. @subsection C language features
  93. FFmpeg is programmed in the ISO C90 language with a few additional
  94. features from ISO C99, namely:
  95. @itemize @bullet
  96. @item
  97. the @samp{inline} keyword;
  98. @item
  99. @samp{//} comments;
  100. @item
  101. designated struct initializers (@samp{struct s x = @{ .i = 17 @};});
  102. @item
  103. compound literals (@samp{x = (struct s) @{ 17, 23 @};}).
  104. @end itemize
  105. These features are supported by all compilers we care about, so we will not
  106. accept patches to remove their use unless they absolutely do not impair
  107. clarity and performance.
  108. All code must compile with recent versions of GCC and a number of other
  109. currently supported compilers. To ensure compatibility, please do not use
  110. additional C99 features or GCC extensions. Especially watch out for:
  111. @itemize @bullet
  112. @item
  113. mixing statements and declarations;
  114. @item
  115. @samp{long long} (use @samp{int64_t} instead);
  116. @item
  117. @samp{__attribute__} not protected by @samp{#ifdef __GNUC__} or similar;
  118. @item
  119. GCC statement expressions (@samp{(x = (@{ int y = 4; y; @})}).
  120. @end itemize
  121. @subsection Naming conventions
  122. All names should be composed with underscores (_), not CamelCase. For example,
  123. @samp{avfilter_get_video_buffer} is an acceptable function name and
  124. @samp{AVFilterGetVideo} is not. The exception from this are type names, like
  125. for example structs and enums; they should always be in CamelCase.
  126. There are the following conventions for naming variables and functions:
  127. @itemize @bullet
  128. @item
  129. For local variables no prefix is required.
  130. @item
  131. For file-scope variables and functions declared as @code{static}, no prefix
  132. is required.
  133. @item
  134. For variables and functions visible outside of file scope, but only used
  135. internally by a library, an @code{ff_} prefix should be used,
  136. e.g. @samp{ff_w64_demuxer}.
  137. @item
  138. For variables and functions visible outside of file scope, used internally
  139. across multiple libraries, use @code{avpriv_} as prefix, for example,
  140. @samp{avpriv_aac_parse_header}.
  141. @item
  142. Each library has its own prefix for public symbols, in addition to the
  143. commonly used @code{av_} (@code{avformat_} for libavformat,
  144. @code{avcodec_} for libavcodec, @code{swr_} for libswresample, etc).
  145. Check the existing code and choose names accordingly.
  146. Note that some symbols without these prefixes are also exported for
  147. retro-compatibility reasons. These exceptions are declared in the
  148. @code{lib<name>/lib<name>.v} files.
  149. @end itemize
  150. Furthermore, name space reserved for the system should not be invaded.
  151. Identifiers ending in @code{_t} are reserved by
  152. @url{http://pubs.opengroup.org/onlinepubs/007904975/functions/xsh_chap02_02.html#tag_02_02_02, POSIX}.
  153. Also avoid names starting with @code{__} or @code{_} followed by an uppercase
  154. letter as they are reserved by the C standard. Names starting with @code{_}
  155. are reserved at the file level and may not be used for externally visible
  156. symbols. If in doubt, just avoid names starting with @code{_} altogether.
  157. @subsection Miscellaneous conventions
  158. @itemize @bullet
  159. @item
  160. fprintf and printf are forbidden in libavformat and libavcodec,
  161. please use av_log() instead.
  162. @item
  163. Casts should be used only when necessary. Unneeded parentheses
  164. should also be avoided if they don't make the code easier to understand.
  165. @end itemize
  166. @subsection Editor configuration
  167. In order to configure Vim to follow FFmpeg formatting conventions, paste
  168. the following snippet into your @file{.vimrc}:
  169. @example
  170. " indentation rules for FFmpeg: 4 spaces, no tabs
  171. set expandtab
  172. set shiftwidth=4
  173. set softtabstop=4
  174. set cindent
  175. set cinoptions=(0
  176. " Allow tabs in Makefiles.
  177. autocmd FileType make,automake set noexpandtab shiftwidth=8 softtabstop=8
  178. " Trailing whitespace and tabs are forbidden, so highlight them.
  179. highlight ForbiddenWhitespace ctermbg=red guibg=red
  180. match ForbiddenWhitespace /\s\+$\|\t/
  181. " Do not highlight spaces at the end of line while typing on that line.
  182. autocmd InsertEnter * match ForbiddenWhitespace /\t\|\s\+\%#\@@<!$/
  183. @end example
  184. For Emacs, add these roughly equivalent lines to your @file{.emacs.d/init.el}:
  185. @lisp
  186. (c-add-style "ffmpeg"
  187. '("k&r"
  188. (c-basic-offset . 4)
  189. (indent-tabs-mode . nil)
  190. (show-trailing-whitespace . t)
  191. (c-offsets-alist
  192. (statement-cont . (c-lineup-assignments +)))
  193. )
  194. )
  195. (setq c-default-style "ffmpeg")
  196. @end lisp
  197. @section Development Policy
  198. @subsection Patches/Committing
  199. @subheading Licenses for patches must be compatible with FFmpeg.
  200. Contributions should be licensed under the
  201. @uref{http://www.gnu.org/licenses/lgpl-2.1.html, LGPL 2.1},
  202. including an "or any later version" clause, or, if you prefer
  203. a gift-style license, the
  204. @uref{http://opensource.org/licenses/isc-license.txt, ISC} or
  205. @uref{http://mit-license.org/, MIT} license.
  206. @uref{http://www.gnu.org/licenses/gpl-2.0.html, GPL 2} including
  207. an "or any later version" clause is also acceptable, but LGPL is
  208. preferred.
  209. If you add a new file, give it a proper license header. Do not copy and
  210. paste it from a random place, use an existing file as template.
  211. @subheading You must not commit code which breaks FFmpeg!
  212. This means unfinished code which is enabled and breaks compilation,
  213. or compiles but does not work/breaks the regression tests. Code which
  214. is unfinished but disabled may be permitted under-circumstances, like
  215. missing samples or an implementation with a small subset of features.
  216. Always check the mailing list for any reviewers with issues and test
  217. FATE before you push.
  218. @subheading Keep the main commit message short with an extended description below.
  219. The commit message should have a short first line in the form of
  220. a @samp{topic: short description} as a header, separated by a newline
  221. from the body consisting of an explanation of why the change is necessary.
  222. If the commit fixes a known bug on the bug tracker, the commit message
  223. should include its bug ID. Referring to the issue on the bug tracker does
  224. not exempt you from writing an excerpt of the bug in the commit message.
  225. @subheading Testing must be adequate but not excessive.
  226. If it works for you, others, and passes FATE then it should be OK to commit
  227. it, provided it fits the other committing criteria. You should not worry about
  228. over-testing things. If your code has problems (portability, triggers
  229. compiler bugs, unusual environment etc) they will be reported and eventually
  230. fixed.
  231. @subheading Do not commit unrelated changes together.
  232. They should be split them into self-contained pieces. Also do not forget
  233. that if part B depends on part A, but A does not depend on B, then A can
  234. and should be committed first and separate from B. Keeping changes well
  235. split into self-contained parts makes reviewing and understanding them on
  236. the commit log mailing list easier. This also helps in case of debugging
  237. later on.
  238. Also if you have doubts about splitting or not splitting, do not hesitate to
  239. ask/discuss it on the developer mailing list.
  240. @subheading Ask before you change the build system (configure, etc).
  241. Do not commit changes to the build system (Makefiles, configure script)
  242. which change behavior, defaults etc, without asking first. The same
  243. applies to compiler warning fixes, trivial looking fixes and to code
  244. maintained by other developers. We usually have a reason for doing things
  245. the way we do. Send your changes as patches to the ffmpeg-devel mailing
  246. list, and if the code maintainers say OK, you may commit. This does not
  247. apply to files you wrote and/or maintain.
  248. @subheading Cosmetic changes should be kept in separate patches.
  249. We refuse source indentation and other cosmetic changes if they are mixed
  250. with functional changes, such commits will be rejected and removed. Every
  251. developer has his own indentation style, you should not change it. Of course
  252. if you (re)write something, you can use your own style, even though we would
  253. prefer if the indentation throughout FFmpeg was consistent (Many projects
  254. force a given indentation style - we do not.). If you really need to make
  255. indentation changes (try to avoid this), separate them strictly from real
  256. changes.
  257. NOTE: If you had to put if()@{ .. @} over a large (> 5 lines) chunk of code,
  258. then either do NOT change the indentation of the inner part within (do not
  259. move it to the right)! or do so in a separate commit
  260. @subheading Commit messages should always be filled out properly.
  261. Always fill out the commit log message. Describe in a few lines what you
  262. changed and why. You can refer to mailing list postings if you fix a
  263. particular bug. Comments such as "fixed!" or "Changed it." are unacceptable.
  264. Recommended format:
  265. @example
  266. area changed: Short 1 line description
  267. details describing what and why and giving references.
  268. @end example
  269. @subheading Credit the author of the patch.
  270. Make sure the author of the commit is set correctly. (see git commit --author)
  271. If you apply a patch, send an
  272. answer to ffmpeg-devel (or wherever you got the patch from) saying that
  273. you applied the patch.
  274. @subheading Complex patches should refer to discussion surrounding them.
  275. When applying patches that have been discussed (at length) on the mailing
  276. list, reference the thread in the log message.
  277. @subheading Always wait long enough before pushing changes
  278. Do NOT commit to code actively maintained by others without permission.
  279. Send a patch to ffmpeg-devel. If no one answers within a reasonable
  280. time-frame (12h for build failures and security fixes, 3 days small changes,
  281. 1 week for big patches) then commit your patch if you think it is OK.
  282. Also note, the maintainer can simply ask for more time to review!
  283. @subsection Code
  284. @subheading API/ABI changes should be discussed before they are made.
  285. Do not change behavior of the programs (renaming options etc) or public
  286. API or ABI without first discussing it on the ffmpeg-devel mailing list.
  287. Do not remove widely used functionality or features (redundant code can be removed).
  288. @subheading Remember to check if you need to bump versions for libav*.
  289. Depending on the change, you may need to change the version integer.
  290. Incrementing the first component means no backward compatibility to
  291. previous versions (e.g. removal of a function from the public API).
  292. Incrementing the second component means backward compatible change
  293. (e.g. addition of a function to the public API or extension of an
  294. existing data structure).
  295. Incrementing the third component means a noteworthy binary compatible
  296. change (e.g. encoder bug fix that matters for the decoder). The third
  297. component always starts at 100 to distinguish FFmpeg from Libav.
  298. @subheading Warnings for correct code may be disabled if there is no other option.
  299. Compiler warnings indicate potential bugs or code with bad style. If a type of
  300. warning always points to correct and clean code, that warning should
  301. be disabled, not the code changed.
  302. Thus the remaining warnings can either be bugs or correct code.
  303. If it is a bug, the bug has to be fixed. If it is not, the code should
  304. be changed to not generate a warning unless that causes a slowdown
  305. or obfuscates the code.
  306. @subheading Check untrusted input properly.
  307. Never write to unallocated memory, never write over the end of arrays,
  308. always check values read from some untrusted source before using them
  309. as array index or other risky things.
  310. @subsection Documentation/Other
  311. @subheading Subscribe to the ffmpeg-cvslog mailing list.
  312. It is important to do this as the diffs of all commits are sent there and
  313. reviewed by all the other developers. Bugs and possible improvements or
  314. general questions regarding commits are discussed there. We expect you to
  315. react if problems with your code are uncovered.
  316. @subheading Keep the documentation up to date.
  317. Update the documentation if you change behavior or add features. If you are
  318. unsure how best to do this, send a patch to ffmpeg-devel, the documentation
  319. maintainer(s) will review and commit your stuff.
  320. @subheading Important discussions should be accessible to all.
  321. Try to keep important discussions and requests (also) on the public
  322. developer mailing list, so that all developers can benefit from them.
  323. @subheading Check your entries in MAINTAINERS.
  324. Make sure that no parts of the codebase that you maintain are missing from the
  325. @file{MAINTAINERS} file. If something that you want to maintain is missing add it with
  326. your name after it.
  327. If at some point you no longer want to maintain some code, then please help in
  328. finding a new maintainer and also don't forget to update the @file{MAINTAINERS} file.
  329. We think our rules are not too hard. If you have comments, contact us.
  330. @section Code of conduct
  331. Be friendly and respectful towards others and third parties.
  332. Treat others the way you yourself want to be treated.
  333. Be considerate. Not everyone shares the same viewpoint and priorities as you do.
  334. Different opinions and interpretations help the project.
  335. Looking at issues from a different perspective assists development.
  336. Do not assume malice for things that can be attributed to incompetence. Even if
  337. it is malice, it's rarely good to start with that as initial assumption.
  338. Stay friendly even if someone acts contrarily. Everyone has a bad day
  339. once in a while.
  340. If you yourself have a bad day or are angry then try to take a break and reply
  341. once you are calm and without anger if you have to.
  342. Try to help other team members and cooperate if you can.
  343. The goal of software development is to create technical excellence, not for any
  344. individual to be better and "win" against the others. Large software projects
  345. are only possible and successful through teamwork.
  346. If someone struggles do not put them down. Give them a helping hand
  347. instead and point them in the right direction.
  348. Finally, keep in mind the immortal words of Bill and Ted,
  349. "Be excellent to each other."
  350. @anchor{Submitting patches}
  351. @section Submitting patches
  352. First, read the @ref{Coding Rules} above if you did not yet, in particular
  353. the rules regarding patch submission.
  354. When you submit your patch, please use @code{git format-patch} or
  355. @code{git send-email}. We cannot read other diffs :-).
  356. Also please do not submit a patch which contains several unrelated changes.
  357. Split it into separate, self-contained pieces. This does not mean splitting
  358. file by file. Instead, make the patch as small as possible while still
  359. keeping it as a logical unit that contains an individual change, even
  360. if it spans multiple files. This makes reviewing your patches much easier
  361. for us and greatly increases your chances of getting your patch applied.
  362. Use the patcheck tool of FFmpeg to check your patch.
  363. The tool is located in the tools directory.
  364. Run the @ref{Regression tests} before submitting a patch in order to verify
  365. it does not cause unexpected problems.
  366. It also helps quite a bit if you tell us what the patch does (for example
  367. 'replaces lrint by lrintf'), and why (for example '*BSD isn't C99 compliant
  368. and has no lrint()')
  369. Also please if you send several patches, send each patch as a separate mail,
  370. do not attach several unrelated patches to the same mail.
  371. Patches should be posted to the
  372. @uref{https://lists.ffmpeg.org/mailman/listinfo/ffmpeg-devel, ffmpeg-devel}
  373. mailing list. Use @code{git send-email} when possible since it will properly
  374. send patches without requiring extra care. If you cannot, then send patches
  375. as base64-encoded attachments, so your patch is not trashed during
  376. transmission. Also ensure the correct mime type is used
  377. (text/x-diff or text/x-patch or at least text/plain) and that only one
  378. patch is inline or attached per mail.
  379. You can check @url{https://patchwork.ffmpeg.org}, if your patch does not show up, its mime type
  380. likely was wrong.
  381. Your patch will be reviewed on the mailing list. You will likely be asked
  382. to make some changes and are expected to send in an improved version that
  383. incorporates the requests from the review. This process may go through
  384. several iterations. Once your patch is deemed good enough, some developer
  385. will pick it up and commit it to the official FFmpeg tree.
  386. Give us a few days to react. But if some time passes without reaction,
  387. send a reminder by email. Your patch should eventually be dealt with.
  388. @section New codecs or formats checklist
  389. @enumerate
  390. @item
  391. Did you use av_cold for codec initialization and close functions?
  392. @item
  393. Did you add a long_name under NULL_IF_CONFIG_SMALL to the AVCodec or
  394. AVInputFormat/AVOutputFormat struct?
  395. @item
  396. Did you bump the minor version number (and reset the micro version
  397. number) in @file{libavcodec/version.h} or @file{libavformat/version.h}?
  398. @item
  399. Did you register it in @file{allcodecs.c} or @file{allformats.c}?
  400. @item
  401. Did you add the AVCodecID to @file{avcodec.h}?
  402. When adding new codec IDs, also add an entry to the codec descriptor
  403. list in @file{libavcodec/codec_desc.c}.
  404. @item
  405. If it has a FourCC, did you add it to @file{libavformat/riff.c},
  406. even if it is only a decoder?
  407. @item
  408. Did you add a rule to compile the appropriate files in the Makefile?
  409. Remember to do this even if you're just adding a format to a file that is
  410. already being compiled by some other rule, like a raw demuxer.
  411. @item
  412. Did you add an entry to the table of supported formats or codecs in
  413. @file{doc/general.texi}?
  414. @item
  415. Did you add an entry in the Changelog?
  416. @item
  417. If it depends on a parser or a library, did you add that dependency in
  418. configure?
  419. @item
  420. Did you @code{git add} the appropriate files before committing?
  421. @item
  422. Did you make sure it compiles standalone, i.e. with
  423. @code{configure --disable-everything --enable-decoder=foo}
  424. (or @code{--enable-demuxer} or whatever your component is)?
  425. @end enumerate
  426. @section patch submission checklist
  427. @enumerate
  428. @item
  429. Does @code{make fate} pass with the patch applied?
  430. @item
  431. Was the patch generated with git format-patch or send-email?
  432. @item
  433. Did you sign off your patch? (git commit -s)
  434. See @url{http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=blob_plain;f=Documentation/SubmittingPatches} for the meaning
  435. of sign off.
  436. @item
  437. Did you provide a clear git commit log message?
  438. @item
  439. Is the patch against latest FFmpeg git master branch?
  440. @item
  441. Are you subscribed to ffmpeg-devel?
  442. (the list is subscribers only due to spam)
  443. @item
  444. Have you checked that the changes are minimal, so that the same cannot be
  445. achieved with a smaller patch and/or simpler final code?
  446. @item
  447. If the change is to speed critical code, did you benchmark it?
  448. @item
  449. If you did any benchmarks, did you provide them in the mail?
  450. @item
  451. Have you checked that the patch does not introduce buffer overflows or
  452. other security issues?
  453. @item
  454. Did you test your decoder or demuxer against damaged data? If no, see
  455. tools/trasher, the noise bitstream filter, and
  456. @uref{http://caca.zoy.org/wiki/zzuf, zzuf}. Your decoder or demuxer
  457. should not crash, end in a (near) infinite loop, or allocate ridiculous
  458. amounts of memory when fed damaged data.
  459. @item
  460. Did you test your decoder or demuxer against sample files?
  461. Samples may be obtained at @url{https://samples.ffmpeg.org}.
  462. @item
  463. Does the patch not mix functional and cosmetic changes?
  464. @item
  465. Did you add tabs or trailing whitespace to the code? Both are forbidden.
  466. @item
  467. Is the patch attached to the email you send?
  468. @item
  469. Is the mime type of the patch correct? It should be text/x-diff or
  470. text/x-patch or at least text/plain and not application/octet-stream.
  471. @item
  472. If the patch fixes a bug, did you provide a verbose analysis of the bug?
  473. @item
  474. If the patch fixes a bug, did you provide enough information, including
  475. a sample, so the bug can be reproduced and the fix can be verified?
  476. Note please do not attach samples >100k to mails but rather provide a
  477. URL, you can upload to ftp://upload.ffmpeg.org.
  478. @item
  479. Did you provide a verbose summary about what the patch does change?
  480. @item
  481. Did you provide a verbose explanation why it changes things like it does?
  482. @item
  483. Did you provide a verbose summary of the user visible advantages and
  484. disadvantages if the patch is applied?
  485. @item
  486. Did you provide an example so we can verify the new feature added by the
  487. patch easily?
  488. @item
  489. If you added a new file, did you insert a license header? It should be
  490. taken from FFmpeg, not randomly copied and pasted from somewhere else.
  491. @item
  492. You should maintain alphabetical order in alphabetically ordered lists as
  493. long as doing so does not break API/ABI compatibility.
  494. @item
  495. Lines with similar content should be aligned vertically when doing so
  496. improves readability.
  497. @item
  498. Consider adding a regression test for your code.
  499. @item
  500. If you added YASM code please check that things still work with --disable-yasm.
  501. @item
  502. Make sure you check the return values of function and return appropriate
  503. error codes. Especially memory allocation functions like @code{av_malloc()}
  504. are notoriously left unchecked, which is a serious problem.
  505. @item
  506. Test your code with valgrind and or Address Sanitizer to ensure it's free
  507. of leaks, out of array accesses, etc.
  508. @end enumerate
  509. @section Patch review process
  510. All patches posted to ffmpeg-devel will be reviewed, unless they contain a
  511. clear note that the patch is not for the git master branch.
  512. Reviews and comments will be posted as replies to the patch on the
  513. mailing list. The patch submitter then has to take care of every comment,
  514. that can be by resubmitting a changed patch or by discussion. Resubmitted
  515. patches will themselves be reviewed like any other patch. If at some point
  516. a patch passes review with no comments then it is approved, that can for
  517. simple and small patches happen immediately while large patches will generally
  518. have to be changed and reviewed many times before they are approved.
  519. After a patch is approved it will be committed to the repository.
  520. We will review all submitted patches, but sometimes we are quite busy so
  521. especially for large patches this can take several weeks.
  522. If you feel that the review process is too slow and you are willing to try to
  523. take over maintainership of the area of code you change then just clone
  524. git master and maintain the area of code there. We will merge each area from
  525. where its best maintained.
  526. When resubmitting patches, please do not make any significant changes
  527. not related to the comments received during review. Such patches will
  528. be rejected. Instead, submit significant changes or new features as
  529. separate patches.
  530. Everyone is welcome to review patches. Also if you are waiting for your patch
  531. to be reviewed, please consider helping to review other patches, that is a great
  532. way to get everyone's patches reviewed sooner.
  533. @anchor{Regression tests}
  534. @section Regression tests
  535. Before submitting a patch (or committing to the repository), you should at least
  536. test that you did not break anything.
  537. Running 'make fate' accomplishes this, please see @url{fate.html} for details.
  538. [Of course, some patches may change the results of the regression tests. In
  539. this case, the reference results of the regression tests shall be modified
  540. accordingly].
  541. @subsection Adding files to the fate-suite dataset
  542. When there is no muxer or encoder available to generate test media for a
  543. specific test then the media has to be included in the fate-suite.
  544. First please make sure that the sample file is as small as possible to test the
  545. respective decoder or demuxer sufficiently. Large files increase network
  546. bandwidth and disk space requirements.
  547. Once you have a working fate test and fate sample, provide in the commit
  548. message or introductory message for the patch series that you post to
  549. the ffmpeg-devel mailing list, a direct link to download the sample media.
  550. @subsection Visualizing Test Coverage
  551. The FFmpeg build system allows visualizing the test coverage in an easy
  552. manner with the coverage tools @code{gcov}/@code{lcov}. This involves
  553. the following steps:
  554. @enumerate
  555. @item
  556. Configure to compile with instrumentation enabled:
  557. @code{configure --toolchain=gcov}.
  558. @item
  559. Run your test case, either manually or via FATE. This can be either
  560. the full FATE regression suite, or any arbitrary invocation of any
  561. front-end tool provided by FFmpeg, in any combination.
  562. @item
  563. Run @code{make lcov} to generate coverage data in HTML format.
  564. @item
  565. View @code{lcov/index.html} in your preferred HTML viewer.
  566. @end enumerate
  567. You can use the command @code{make lcov-reset} to reset the coverage
  568. measurements. You will need to rerun @code{make lcov} after running a
  569. new test.
  570. @subsection Using Valgrind
  571. The configure script provides a shortcut for using valgrind to spot bugs
  572. related to memory handling. Just add the option
  573. @code{--toolchain=valgrind-memcheck} or @code{--toolchain=valgrind-massif}
  574. to your configure line, and reasonable defaults will be set for running
  575. FATE under the supervision of either the @strong{memcheck} or the
  576. @strong{massif} tool of the valgrind suite.
  577. In case you need finer control over how valgrind is invoked, use the
  578. @code{--target-exec='valgrind <your_custom_valgrind_options>} option in
  579. your configure line instead.
  580. @anchor{Release process}
  581. @section Release process
  582. FFmpeg maintains a set of @strong{release branches}, which are the
  583. recommended deliverable for system integrators and distributors (such as
  584. Linux distributions, etc.). At regular times, a @strong{release
  585. manager} prepares, tests and publishes tarballs on the
  586. @url{https://ffmpeg.org} website.
  587. There are two kinds of releases:
  588. @enumerate
  589. @item
  590. @strong{Major releases} always include the latest and greatest
  591. features and functionality.
  592. @item
  593. @strong{Point releases} are cut from @strong{release} branches,
  594. which are named @code{release/X}, with @code{X} being the release
  595. version number.
  596. @end enumerate
  597. Note that we promise to our users that shared libraries from any FFmpeg
  598. release never break programs that have been @strong{compiled} against
  599. previous versions of @strong{the same release series} in any case!
  600. However, from time to time, we do make API changes that require adaptations
  601. in applications. Such changes are only allowed in (new) major releases and
  602. require further steps such as bumping library version numbers and/or
  603. adjustments to the symbol versioning file. Please discuss such changes
  604. on the @strong{ffmpeg-devel} mailing list in time to allow forward planning.
  605. @anchor{Criteria for Point Releases}
  606. @subsection Criteria for Point Releases
  607. Changes that match the following criteria are valid candidates for
  608. inclusion into a point release:
  609. @enumerate
  610. @item
  611. Fixes a security issue, preferably identified by a @strong{CVE
  612. number} issued by @url{http://cve.mitre.org/}.
  613. @item
  614. Fixes a documented bug in @url{https://trac.ffmpeg.org}.
  615. @item
  616. Improves the included documentation.
  617. @item
  618. Retains both source code and binary compatibility with previous
  619. point releases of the same release branch.
  620. @end enumerate
  621. The order for checking the rules is (1 OR 2 OR 3) AND 4.
  622. @subsection Release Checklist
  623. The release process involves the following steps:
  624. @enumerate
  625. @item
  626. Ensure that the @file{RELEASE} file contains the version number for
  627. the upcoming release.
  628. @item
  629. Add the release at @url{https://trac.ffmpeg.org/admin/ticket/versions}.
  630. @item
  631. Announce the intent to do a release to the mailing list.
  632. @item
  633. Make sure all relevant security fixes have been backported. See
  634. @url{https://ffmpeg.org/security.html}.
  635. @item
  636. Ensure that the FATE regression suite still passes in the release
  637. branch on at least @strong{i386} and @strong{amd64}
  638. (cf. @ref{Regression tests}).
  639. @item
  640. Prepare the release tarballs in @code{bz2} and @code{gz} formats, and
  641. supplementing files that contain @code{gpg} signatures
  642. @item
  643. Publish the tarballs at @url{https://ffmpeg.org/releases}. Create and
  644. push an annotated tag in the form @code{nX}, with @code{X}
  645. containing the version number.
  646. @item
  647. Propose and send a patch to the @strong{ffmpeg-devel} mailing list
  648. with a news entry for the website.
  649. @item
  650. Publish the news entry.
  651. @item
  652. Send an announcement to the mailing list.
  653. @end enumerate
  654. @bye