You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

847 lines
31KB

  1. \input texinfo @c -*- texinfo -*-
  2. @documentencoding UTF-8
  3. @settitle Developer Documentation
  4. @titlepage
  5. @center @titlefont{Developer Documentation}
  6. @end titlepage
  7. @top
  8. @contents
  9. @chapter Notes for external developers
  10. This document is mostly useful for internal FFmpeg developers.
  11. External developers who need to use the API in their application should
  12. refer to the API doxygen documentation in the public headers, and
  13. check the examples in @file{doc/examples} and in the source code to
  14. see how the public API is employed.
  15. You can use the FFmpeg libraries in your commercial program, but you
  16. are encouraged to @emph{publish any patch you make}. In this case the
  17. best way to proceed is to send your patches to the ffmpeg-devel
  18. mailing list following the guidelines illustrated in the remainder of
  19. this document.
  20. For more detailed legal information about the use of FFmpeg in
  21. external programs read the @file{LICENSE} file in the source tree and
  22. consult @url{https://ffmpeg.org/legal.html}.
  23. @chapter Contributing
  24. There are 3 ways by which code gets into FFmpeg.
  25. @itemize @bullet
  26. @item Submitting patches to the main developer mailing list.
  27. See @ref{Submitting patches} for details.
  28. @item Directly committing changes to the main tree.
  29. @item Committing changes to a git clone, for example on github.com or
  30. gitorious.org. And asking us to merge these changes.
  31. @end itemize
  32. Whichever way, changes should be reviewed by the maintainer of the code
  33. before they are committed. And they should follow the @ref{Coding Rules}.
  34. The developer making the commit and the author are responsible for their changes
  35. and should try to fix issues their commit causes.
  36. @anchor{Coding Rules}
  37. @chapter Coding Rules
  38. @section Code formatting conventions
  39. There are the following guidelines regarding the indentation in files:
  40. @itemize @bullet
  41. @item
  42. Indent size is 4.
  43. @item
  44. The TAB character is forbidden outside of Makefiles as is any
  45. form of trailing whitespace. Commits containing either will be
  46. rejected by the git repository.
  47. @item
  48. You should try to limit your code lines to 80 characters; however, do so if
  49. and only if this improves readability.
  50. @item
  51. K&R coding style is used.
  52. @end itemize
  53. The presentation is one inspired by 'indent -i4 -kr -nut'.
  54. The main priority in FFmpeg is simplicity and small code size in order to
  55. minimize the bug count.
  56. @section Comments
  57. Use the JavaDoc/Doxygen format (see examples below) so that code documentation
  58. can be generated automatically. All nontrivial functions should have a comment
  59. above them explaining what the function does, even if it is just one sentence.
  60. All structures and their member variables should be documented, too.
  61. Avoid Qt-style and similar Doxygen syntax with @code{!} in it, i.e. replace
  62. @code{//!} with @code{///} and similar. Also @@ syntax should be employed
  63. for markup commands, i.e. use @code{@@param} and not @code{\param}.
  64. @example
  65. /**
  66. * @@file
  67. * MPEG codec.
  68. * @@author ...
  69. */
  70. /**
  71. * Summary sentence.
  72. * more text ...
  73. * ...
  74. */
  75. typedef struct Foobar @{
  76. int var1; /**< var1 description */
  77. int var2; ///< var2 description
  78. /** var3 description */
  79. int var3;
  80. @} Foobar;
  81. /**
  82. * Summary sentence.
  83. * more text ...
  84. * ...
  85. * @@param my_parameter description of my_parameter
  86. * @@return return value description
  87. */
  88. int myfunc(int my_parameter)
  89. ...
  90. @end example
  91. @section C language features
  92. FFmpeg is programmed in the ISO C90 language with a few additional
  93. features from ISO C99, namely:
  94. @itemize @bullet
  95. @item
  96. the @samp{inline} keyword;
  97. @item
  98. @samp{//} comments;
  99. @item
  100. designated struct initializers (@samp{struct s x = @{ .i = 17 @};});
  101. @item
  102. compound literals (@samp{x = (struct s) @{ 17, 23 @};}).
  103. @item
  104. Implementation defined behavior for signed integers is assumed to match the
  105. expected behavior for two's complement. Non representable values in integer
  106. casts are binary truncated. Shift right of signed values uses sign extension.
  107. @end itemize
  108. These features are supported by all compilers we care about, so we will not
  109. accept patches to remove their use unless they absolutely do not impair
  110. clarity and performance.
  111. All code must compile with recent versions of GCC and a number of other
  112. currently supported compilers. To ensure compatibility, please do not use
  113. additional C99 features or GCC extensions. Especially watch out for:
  114. @itemize @bullet
  115. @item
  116. mixing statements and declarations;
  117. @item
  118. @samp{long long} (use @samp{int64_t} instead);
  119. @item
  120. @samp{__attribute__} not protected by @samp{#ifdef __GNUC__} or similar;
  121. @item
  122. GCC statement expressions (@samp{(x = (@{ int y = 4; y; @})}).
  123. @end itemize
  124. @section Naming conventions
  125. All names should be composed with underscores (_), not CamelCase. For example,
  126. @samp{avfilter_get_video_buffer} is an acceptable function name and
  127. @samp{AVFilterGetVideo} is not. The exception from this are type names, like
  128. for example structs and enums; they should always be in CamelCase.
  129. There are the following conventions for naming variables and functions:
  130. @itemize @bullet
  131. @item
  132. For local variables no prefix is required.
  133. @item
  134. For file-scope variables and functions declared as @code{static}, no prefix
  135. is required.
  136. @item
  137. For variables and functions visible outside of file scope, but only used
  138. internally by a library, an @code{ff_} prefix should be used,
  139. e.g. @samp{ff_w64_demuxer}.
  140. @item
  141. For variables and functions visible outside of file scope, used internally
  142. across multiple libraries, use @code{avpriv_} as prefix, for example,
  143. @samp{avpriv_report_missing_feature}.
  144. @item
  145. Each library has its own prefix for public symbols, in addition to the
  146. commonly used @code{av_} (@code{avformat_} for libavformat,
  147. @code{avcodec_} for libavcodec, @code{swr_} for libswresample, etc).
  148. Check the existing code and choose names accordingly.
  149. Note that some symbols without these prefixes are also exported for
  150. retro-compatibility reasons. These exceptions are declared in the
  151. @code{lib<name>/lib<name>.v} files.
  152. @end itemize
  153. Furthermore, name space reserved for the system should not be invaded.
  154. Identifiers ending in @code{_t} are reserved by
  155. @url{http://pubs.opengroup.org/onlinepubs/007904975/functions/xsh_chap02_02.html#tag_02_02_02, POSIX}.
  156. Also avoid names starting with @code{__} or @code{_} followed by an uppercase
  157. letter as they are reserved by the C standard. Names starting with @code{_}
  158. are reserved at the file level and may not be used for externally visible
  159. symbols. If in doubt, just avoid names starting with @code{_} altogether.
  160. @section Miscellaneous conventions
  161. @itemize @bullet
  162. @item
  163. fprintf and printf are forbidden in libavformat and libavcodec,
  164. please use av_log() instead.
  165. @item
  166. Casts should be used only when necessary. Unneeded parentheses
  167. should also be avoided if they don't make the code easier to understand.
  168. @end itemize
  169. @section Editor configuration
  170. In order to configure Vim to follow FFmpeg formatting conventions, paste
  171. the following snippet into your @file{.vimrc}:
  172. @example
  173. " indentation rules for FFmpeg: 4 spaces, no tabs
  174. set expandtab
  175. set shiftwidth=4
  176. set softtabstop=4
  177. set cindent
  178. set cinoptions=(0
  179. " Allow tabs in Makefiles.
  180. autocmd FileType make,automake set noexpandtab shiftwidth=8 softtabstop=8
  181. " Trailing whitespace and tabs are forbidden, so highlight them.
  182. highlight ForbiddenWhitespace ctermbg=red guibg=red
  183. match ForbiddenWhitespace /\s\+$\|\t/
  184. " Do not highlight spaces at the end of line while typing on that line.
  185. autocmd InsertEnter * match ForbiddenWhitespace /\t\|\s\+\%#\@@<!$/
  186. @end example
  187. For Emacs, add these roughly equivalent lines to your @file{.emacs.d/init.el}:
  188. @lisp
  189. (c-add-style "ffmpeg"
  190. '("k&r"
  191. (c-basic-offset . 4)
  192. (indent-tabs-mode . nil)
  193. (show-trailing-whitespace . t)
  194. (c-offsets-alist
  195. (statement-cont . (c-lineup-assignments +)))
  196. )
  197. )
  198. (setq c-default-style "ffmpeg")
  199. @end lisp
  200. @chapter Development Policy
  201. @section Patches/Committing
  202. @subheading Licenses for patches must be compatible with FFmpeg.
  203. Contributions should be licensed under the
  204. @uref{http://www.gnu.org/licenses/lgpl-2.1.html, LGPL 2.1},
  205. including an "or any later version" clause, or, if you prefer
  206. a gift-style license, the
  207. @uref{http://opensource.org/licenses/isc-license.txt, ISC} or
  208. @uref{http://mit-license.org/, MIT} license.
  209. @uref{http://www.gnu.org/licenses/gpl-2.0.html, GPL 2} including
  210. an "or any later version" clause is also acceptable, but LGPL is
  211. preferred.
  212. If you add a new file, give it a proper license header. Do not copy and
  213. paste it from a random place, use an existing file as template.
  214. @subheading You must not commit code which breaks FFmpeg!
  215. This means unfinished code which is enabled and breaks compilation,
  216. or compiles but does not work/breaks the regression tests. Code which
  217. is unfinished but disabled may be permitted under-circumstances, like
  218. missing samples or an implementation with a small subset of features.
  219. Always check the mailing list for any reviewers with issues and test
  220. FATE before you push.
  221. @subheading Keep the main commit message short with an extended description below.
  222. The commit message should have a short first line in the form of
  223. a @samp{topic: short description} as a header, separated by a newline
  224. from the body consisting of an explanation of why the change is necessary.
  225. If the commit fixes a known bug on the bug tracker, the commit message
  226. should include its bug ID. Referring to the issue on the bug tracker does
  227. not exempt you from writing an excerpt of the bug in the commit message.
  228. @subheading Testing must be adequate but not excessive.
  229. If it works for you, others, and passes FATE then it should be OK to commit
  230. it, provided it fits the other committing criteria. You should not worry about
  231. over-testing things. If your code has problems (portability, triggers
  232. compiler bugs, unusual environment etc) they will be reported and eventually
  233. fixed.
  234. @subheading Do not commit unrelated changes together.
  235. They should be split them into self-contained pieces. Also do not forget
  236. that if part B depends on part A, but A does not depend on B, then A can
  237. and should be committed first and separate from B. Keeping changes well
  238. split into self-contained parts makes reviewing and understanding them on
  239. the commit log mailing list easier. This also helps in case of debugging
  240. later on.
  241. Also if you have doubts about splitting or not splitting, do not hesitate to
  242. ask/discuss it on the developer mailing list.
  243. @subheading Ask before you change the build system (configure, etc).
  244. Do not commit changes to the build system (Makefiles, configure script)
  245. which change behavior, defaults etc, without asking first. The same
  246. applies to compiler warning fixes, trivial looking fixes and to code
  247. maintained by other developers. We usually have a reason for doing things
  248. the way we do. Send your changes as patches to the ffmpeg-devel mailing
  249. list, and if the code maintainers say OK, you may commit. This does not
  250. apply to files you wrote and/or maintain.
  251. @subheading Cosmetic changes should be kept in separate patches.
  252. We refuse source indentation and other cosmetic changes if they are mixed
  253. with functional changes, such commits will be rejected and removed. Every
  254. developer has his own indentation style, you should not change it. Of course
  255. if you (re)write something, you can use your own style, even though we would
  256. prefer if the indentation throughout FFmpeg was consistent (Many projects
  257. force a given indentation style - we do not.). If you really need to make
  258. indentation changes (try to avoid this), separate them strictly from real
  259. changes.
  260. NOTE: If you had to put if()@{ .. @} over a large (> 5 lines) chunk of code,
  261. then either do NOT change the indentation of the inner part within (do not
  262. move it to the right)! or do so in a separate commit
  263. @subheading Commit messages should always be filled out properly.
  264. Always fill out the commit log message. Describe in a few lines what you
  265. changed and why. You can refer to mailing list postings if you fix a
  266. particular bug. Comments such as "fixed!" or "Changed it." are unacceptable.
  267. Recommended format:
  268. @example
  269. area changed: Short 1 line description
  270. details describing what and why and giving references.
  271. @end example
  272. @subheading Credit the author of the patch.
  273. Make sure the author of the commit is set correctly. (see git commit --author)
  274. If you apply a patch, send an
  275. answer to ffmpeg-devel (or wherever you got the patch from) saying that
  276. you applied the patch.
  277. @subheading Complex patches should refer to discussion surrounding them.
  278. When applying patches that have been discussed (at length) on the mailing
  279. list, reference the thread in the log message.
  280. @subheading Always wait long enough before pushing changes
  281. Do NOT commit to code actively maintained by others without permission.
  282. Send a patch to ffmpeg-devel. If no one answers within a reasonable
  283. time-frame (12h for build failures and security fixes, 3 days small changes,
  284. 1 week for big patches) then commit your patch if you think it is OK.
  285. Also note, the maintainer can simply ask for more time to review!
  286. @section Code
  287. @subheading API/ABI changes should be discussed before they are made.
  288. Do not change behavior of the programs (renaming options etc) or public
  289. API or ABI without first discussing it on the ffmpeg-devel mailing list.
  290. Do not remove widely used functionality or features (redundant code can be removed).
  291. @subheading Remember to check if you need to bump versions for libav*.
  292. Depending on the change, you may need to change the version integer.
  293. Incrementing the first component means no backward compatibility to
  294. previous versions (e.g. removal of a function from the public API).
  295. Incrementing the second component means backward compatible change
  296. (e.g. addition of a function to the public API or extension of an
  297. existing data structure).
  298. Incrementing the third component means a noteworthy binary compatible
  299. change (e.g. encoder bug fix that matters for the decoder). The third
  300. component always starts at 100 to distinguish FFmpeg from Libav.
  301. @subheading Warnings for correct code may be disabled if there is no other option.
  302. Compiler warnings indicate potential bugs or code with bad style. If a type of
  303. warning always points to correct and clean code, that warning should
  304. be disabled, not the code changed.
  305. Thus the remaining warnings can either be bugs or correct code.
  306. If it is a bug, the bug has to be fixed. If it is not, the code should
  307. be changed to not generate a warning unless that causes a slowdown
  308. or obfuscates the code.
  309. @subheading Check untrusted input properly.
  310. Never write to unallocated memory, never write over the end of arrays,
  311. always check values read from some untrusted source before using them
  312. as array index or other risky things.
  313. @section Documentation/Other
  314. @subheading Subscribe to the ffmpeg-cvslog mailing list.
  315. It is important to do this as the diffs of all commits are sent there and
  316. reviewed by all the other developers. Bugs and possible improvements or
  317. general questions regarding commits are discussed there. We expect you to
  318. react if problems with your code are uncovered.
  319. @subheading Keep the documentation up to date.
  320. Update the documentation if you change behavior or add features. If you are
  321. unsure how best to do this, send a patch to ffmpeg-devel, the documentation
  322. maintainer(s) will review and commit your stuff.
  323. @subheading Important discussions should be accessible to all.
  324. Try to keep important discussions and requests (also) on the public
  325. developer mailing list, so that all developers can benefit from them.
  326. @subheading Check your entries in MAINTAINERS.
  327. Make sure that no parts of the codebase that you maintain are missing from the
  328. @file{MAINTAINERS} file. If something that you want to maintain is missing add it with
  329. your name after it.
  330. If at some point you no longer want to maintain some code, then please help in
  331. finding a new maintainer and also don't forget to update the @file{MAINTAINERS} file.
  332. We think our rules are not too hard. If you have comments, contact us.
  333. @chapter Code of conduct
  334. Be friendly and respectful towards others and third parties.
  335. Treat others the way you yourself want to be treated.
  336. Be considerate. Not everyone shares the same viewpoint and priorities as you do.
  337. Different opinions and interpretations help the project.
  338. Looking at issues from a different perspective assists development.
  339. Do not assume malice for things that can be attributed to incompetence. Even if
  340. it is malice, it's rarely good to start with that as initial assumption.
  341. Stay friendly even if someone acts contrarily. Everyone has a bad day
  342. once in a while.
  343. If you yourself have a bad day or are angry then try to take a break and reply
  344. once you are calm and without anger if you have to.
  345. Try to help other team members and cooperate if you can.
  346. The goal of software development is to create technical excellence, not for any
  347. individual to be better and "win" against the others. Large software projects
  348. are only possible and successful through teamwork.
  349. If someone struggles do not put them down. Give them a helping hand
  350. instead and point them in the right direction.
  351. Finally, keep in mind the immortal words of Bill and Ted,
  352. "Be excellent to each other."
  353. @anchor{Submitting patches}
  354. @chapter Submitting patches
  355. First, read the @ref{Coding Rules} above if you did not yet, in particular
  356. the rules regarding patch submission.
  357. When you submit your patch, please use @code{git format-patch} or
  358. @code{git send-email}. We cannot read other diffs :-).
  359. Also please do not submit a patch which contains several unrelated changes.
  360. Split it into separate, self-contained pieces. This does not mean splitting
  361. file by file. Instead, make the patch as small as possible while still
  362. keeping it as a logical unit that contains an individual change, even
  363. if it spans multiple files. This makes reviewing your patches much easier
  364. for us and greatly increases your chances of getting your patch applied.
  365. Use the patcheck tool of FFmpeg to check your patch.
  366. The tool is located in the tools directory.
  367. Run the @ref{Regression tests} before submitting a patch in order to verify
  368. it does not cause unexpected problems.
  369. It also helps quite a bit if you tell us what the patch does (for example
  370. 'replaces lrint by lrintf'), and why (for example '*BSD isn't C99 compliant
  371. and has no lrint()')
  372. Also please if you send several patches, send each patch as a separate mail,
  373. do not attach several unrelated patches to the same mail.
  374. Patches should be posted to the
  375. @uref{https://lists.ffmpeg.org/mailman/listinfo/ffmpeg-devel, ffmpeg-devel}
  376. mailing list. Use @code{git send-email} when possible since it will properly
  377. send patches without requiring extra care. If you cannot, then send patches
  378. as base64-encoded attachments, so your patch is not trashed during
  379. transmission. Also ensure the correct mime type is used
  380. (text/x-diff or text/x-patch or at least text/plain) and that only one
  381. patch is inline or attached per mail.
  382. You can check @url{https://patchwork.ffmpeg.org}, if your patch does not show up, its mime type
  383. likely was wrong.
  384. Your patch will be reviewed on the mailing list. You will likely be asked
  385. to make some changes and are expected to send in an improved version that
  386. incorporates the requests from the review. This process may go through
  387. several iterations. Once your patch is deemed good enough, some developer
  388. will pick it up and commit it to the official FFmpeg tree.
  389. Give us a few days to react. But if some time passes without reaction,
  390. send a reminder by email. Your patch should eventually be dealt with.
  391. @chapter New codecs or formats checklist
  392. @enumerate
  393. @item
  394. Did you use av_cold for codec initialization and close functions?
  395. @item
  396. Did you add a long_name under NULL_IF_CONFIG_SMALL to the AVCodec or
  397. AVInputFormat/AVOutputFormat struct?
  398. @item
  399. Did you bump the minor version number (and reset the micro version
  400. number) in @file{libavcodec/version.h} or @file{libavformat/version.h}?
  401. @item
  402. Did you register it in @file{allcodecs.c} or @file{allformats.c}?
  403. @item
  404. Did you add the AVCodecID to @file{avcodec.h}?
  405. When adding new codec IDs, also add an entry to the codec descriptor
  406. list in @file{libavcodec/codec_desc.c}.
  407. @item
  408. If it has a FourCC, did you add it to @file{libavformat/riff.c},
  409. even if it is only a decoder?
  410. @item
  411. Did you add a rule to compile the appropriate files in the Makefile?
  412. Remember to do this even if you're just adding a format to a file that is
  413. already being compiled by some other rule, like a raw demuxer.
  414. @item
  415. Did you add an entry to the table of supported formats or codecs in
  416. @file{doc/general.texi}?
  417. @item
  418. Did you add an entry in the Changelog?
  419. @item
  420. If it depends on a parser or a library, did you add that dependency in
  421. configure?
  422. @item
  423. Did you @code{git add} the appropriate files before committing?
  424. @item
  425. Did you make sure it compiles standalone, i.e. with
  426. @code{configure --disable-everything --enable-decoder=foo}
  427. (or @code{--enable-demuxer} or whatever your component is)?
  428. @end enumerate
  429. @chapter Patch submission checklist
  430. @enumerate
  431. @item
  432. Does @code{make fate} pass with the patch applied?
  433. @item
  434. Was the patch generated with git format-patch or send-email?
  435. @item
  436. Did you sign off your patch? (git commit -s)
  437. See @url{http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=blob_plain;f=Documentation/SubmittingPatches} for the meaning
  438. of sign off.
  439. @item
  440. Did you provide a clear git commit log message?
  441. @item
  442. Is the patch against latest FFmpeg git master branch?
  443. @item
  444. Are you subscribed to ffmpeg-devel?
  445. (the list is subscribers only due to spam)
  446. @item
  447. Have you checked that the changes are minimal, so that the same cannot be
  448. achieved with a smaller patch and/or simpler final code?
  449. @item
  450. If the change is to speed critical code, did you benchmark it?
  451. @item
  452. If you did any benchmarks, did you provide them in the mail?
  453. @item
  454. Have you checked that the patch does not introduce buffer overflows or
  455. other security issues?
  456. @item
  457. Did you test your decoder or demuxer against damaged data? If no, see
  458. tools/trasher, the noise bitstream filter, and
  459. @uref{http://caca.zoy.org/wiki/zzuf, zzuf}. Your decoder or demuxer
  460. should not crash, end in a (near) infinite loop, or allocate ridiculous
  461. amounts of memory when fed damaged data.
  462. @item
  463. Did you test your decoder or demuxer against sample files?
  464. Samples may be obtained at @url{https://samples.ffmpeg.org}.
  465. @item
  466. Does the patch not mix functional and cosmetic changes?
  467. @item
  468. Did you add tabs or trailing whitespace to the code? Both are forbidden.
  469. @item
  470. Is the patch attached to the email you send?
  471. @item
  472. Is the mime type of the patch correct? It should be text/x-diff or
  473. text/x-patch or at least text/plain and not application/octet-stream.
  474. @item
  475. If the patch fixes a bug, did you provide a verbose analysis of the bug?
  476. @item
  477. If the patch fixes a bug, did you provide enough information, including
  478. a sample, so the bug can be reproduced and the fix can be verified?
  479. Note please do not attach samples >100k to mails but rather provide a
  480. URL, you can upload to ftp://upload.ffmpeg.org.
  481. @item
  482. Did you provide a verbose summary about what the patch does change?
  483. @item
  484. Did you provide a verbose explanation why it changes things like it does?
  485. @item
  486. Did you provide a verbose summary of the user visible advantages and
  487. disadvantages if the patch is applied?
  488. @item
  489. Did you provide an example so we can verify the new feature added by the
  490. patch easily?
  491. @item
  492. If you added a new file, did you insert a license header? It should be
  493. taken from FFmpeg, not randomly copied and pasted from somewhere else.
  494. @item
  495. You should maintain alphabetical order in alphabetically ordered lists as
  496. long as doing so does not break API/ABI compatibility.
  497. @item
  498. Lines with similar content should be aligned vertically when doing so
  499. improves readability.
  500. @item
  501. Consider adding a regression test for your code.
  502. @item
  503. If you added YASM code please check that things still work with --disable-yasm.
  504. @item
  505. Make sure you check the return values of function and return appropriate
  506. error codes. Especially memory allocation functions like @code{av_malloc()}
  507. are notoriously left unchecked, which is a serious problem.
  508. @item
  509. Test your code with valgrind and or Address Sanitizer to ensure it's free
  510. of leaks, out of array accesses, etc.
  511. @end enumerate
  512. @chapter Patch review process
  513. All patches posted to ffmpeg-devel will be reviewed, unless they contain a
  514. clear note that the patch is not for the git master branch.
  515. Reviews and comments will be posted as replies to the patch on the
  516. mailing list. The patch submitter then has to take care of every comment,
  517. that can be by resubmitting a changed patch or by discussion. Resubmitted
  518. patches will themselves be reviewed like any other patch. If at some point
  519. a patch passes review with no comments then it is approved, that can for
  520. simple and small patches happen immediately while large patches will generally
  521. have to be changed and reviewed many times before they are approved.
  522. After a patch is approved it will be committed to the repository.
  523. We will review all submitted patches, but sometimes we are quite busy so
  524. especially for large patches this can take several weeks.
  525. If you feel that the review process is too slow and you are willing to try to
  526. take over maintainership of the area of code you change then just clone
  527. git master and maintain the area of code there. We will merge each area from
  528. where its best maintained.
  529. When resubmitting patches, please do not make any significant changes
  530. not related to the comments received during review. Such patches will
  531. be rejected. Instead, submit significant changes or new features as
  532. separate patches.
  533. Everyone is welcome to review patches. Also if you are waiting for your patch
  534. to be reviewed, please consider helping to review other patches, that is a great
  535. way to get everyone's patches reviewed sooner.
  536. @anchor{Regression tests}
  537. @chapter Regression tests
  538. Before submitting a patch (or committing to the repository), you should at least
  539. test that you did not break anything.
  540. Running 'make fate' accomplishes this, please see @url{fate.html} for details.
  541. [Of course, some patches may change the results of the regression tests. In
  542. this case, the reference results of the regression tests shall be modified
  543. accordingly].
  544. @section Adding files to the fate-suite dataset
  545. When there is no muxer or encoder available to generate test media for a
  546. specific test then the media has to be included in the fate-suite.
  547. First please make sure that the sample file is as small as possible to test the
  548. respective decoder or demuxer sufficiently. Large files increase network
  549. bandwidth and disk space requirements.
  550. Once you have a working fate test and fate sample, provide in the commit
  551. message or introductory message for the patch series that you post to
  552. the ffmpeg-devel mailing list, a direct link to download the sample media.
  553. @section Visualizing Test Coverage
  554. The FFmpeg build system allows visualizing the test coverage in an easy
  555. manner with the coverage tools @code{gcov}/@code{lcov}. This involves
  556. the following steps:
  557. @enumerate
  558. @item
  559. Configure to compile with instrumentation enabled:
  560. @code{configure --toolchain=gcov}.
  561. @item
  562. Run your test case, either manually or via FATE. This can be either
  563. the full FATE regression suite, or any arbitrary invocation of any
  564. front-end tool provided by FFmpeg, in any combination.
  565. @item
  566. Run @code{make lcov} to generate coverage data in HTML format.
  567. @item
  568. View @code{lcov/index.html} in your preferred HTML viewer.
  569. @end enumerate
  570. You can use the command @code{make lcov-reset} to reset the coverage
  571. measurements. You will need to rerun @code{make lcov} after running a
  572. new test.
  573. @section Using Valgrind
  574. The configure script provides a shortcut for using valgrind to spot bugs
  575. related to memory handling. Just add the option
  576. @code{--toolchain=valgrind-memcheck} or @code{--toolchain=valgrind-massif}
  577. to your configure line, and reasonable defaults will be set for running
  578. FATE under the supervision of either the @strong{memcheck} or the
  579. @strong{massif} tool of the valgrind suite.
  580. In case you need finer control over how valgrind is invoked, use the
  581. @code{--target-exec='valgrind <your_custom_valgrind_options>} option in
  582. your configure line instead.
  583. @anchor{Release process}
  584. @chapter Release process
  585. FFmpeg maintains a set of @strong{release branches}, which are the
  586. recommended deliverable for system integrators and distributors (such as
  587. Linux distributions, etc.). At regular times, a @strong{release
  588. manager} prepares, tests and publishes tarballs on the
  589. @url{https://ffmpeg.org} website.
  590. There are two kinds of releases:
  591. @enumerate
  592. @item
  593. @strong{Major releases} always include the latest and greatest
  594. features and functionality.
  595. @item
  596. @strong{Point releases} are cut from @strong{release} branches,
  597. which are named @code{release/X}, with @code{X} being the release
  598. version number.
  599. @end enumerate
  600. Note that we promise to our users that shared libraries from any FFmpeg
  601. release never break programs that have been @strong{compiled} against
  602. previous versions of @strong{the same release series} in any case!
  603. However, from time to time, we do make API changes that require adaptations
  604. in applications. Such changes are only allowed in (new) major releases and
  605. require further steps such as bumping library version numbers and/or
  606. adjustments to the symbol versioning file. Please discuss such changes
  607. on the @strong{ffmpeg-devel} mailing list in time to allow forward planning.
  608. @anchor{Criteria for Point Releases}
  609. @section Criteria for Point Releases
  610. Changes that match the following criteria are valid candidates for
  611. inclusion into a point release:
  612. @enumerate
  613. @item
  614. Fixes a security issue, preferably identified by a @strong{CVE
  615. number} issued by @url{http://cve.mitre.org/}.
  616. @item
  617. Fixes a documented bug in @url{https://trac.ffmpeg.org}.
  618. @item
  619. Improves the included documentation.
  620. @item
  621. Retains both source code and binary compatibility with previous
  622. point releases of the same release branch.
  623. @end enumerate
  624. The order for checking the rules is (1 OR 2 OR 3) AND 4.
  625. @section Release Checklist
  626. The release process involves the following steps:
  627. @enumerate
  628. @item
  629. Ensure that the @file{RELEASE} file contains the version number for
  630. the upcoming release.
  631. @item
  632. Add the release at @url{https://trac.ffmpeg.org/admin/ticket/versions}.
  633. @item
  634. Announce the intent to do a release to the mailing list.
  635. @item
  636. Make sure all relevant security fixes have been backported. See
  637. @url{https://ffmpeg.org/security.html}.
  638. @item
  639. Ensure that the FATE regression suite still passes in the release
  640. branch on at least @strong{i386} and @strong{amd64}
  641. (cf. @ref{Regression tests}).
  642. @item
  643. Prepare the release tarballs in @code{bz2} and @code{gz} formats, and
  644. supplementing files that contain @code{gpg} signatures
  645. @item
  646. Publish the tarballs at @url{https://ffmpeg.org/releases}. Create and
  647. push an annotated tag in the form @code{nX}, with @code{X}
  648. containing the version number.
  649. @item
  650. Propose and send a patch to the @strong{ffmpeg-devel} mailing list
  651. with a news entry for the website.
  652. @item
  653. Publish the news entry.
  654. @item
  655. Send an announcement to the mailing list.
  656. @end enumerate
  657. @bye