92e483f8ed 
								
							
								 
							
						 
						
							
							
								
								all: use FFDIFFSIGN to resolve possible undefined behavior in comparators  
							
							FFDIFFSIGN was created explicitly for this purpose, since the common
return a - b idiom is unsafe regarding overflow on signed integers. It
optimizes to branchless code on common compilers.
FFDIFFSIGN also has the subjective benefit of being easier to read due
to lack of ternary operators.
Tested with FATE.
Things not covered by this are unsigned integers, for which overflows
are well defined, and also places where overflow is clearly impossible,
e.g an instance where the a - b was being done on 24 bit values.
Reviewed-by: Michael Niedermayer <michael@niedermayer.cc>
Reviewed-by: Clément Bœsch <u@pkh.me>
Signed-off-by: Ganesh Ajjanagadde <gajjanagadde@gmail.com> 
							
						 
						10 years ago  
				
					
						
							
							
								 
						
							
							
							
								
							
								f7b53c9527 
								
							
								 
							
						 
						
							
							
								
								avfilter/f_sendcmd: use the name 's' for the pointer to the private context  
							
							Signed-off-by: Ganesh Ajjanagadde <gajjanagadde@gmail.com>
Signed-off-by: Ronald S. Bultje <rsbultje@gmail.com> 
							
						 
						10 years ago  
				
					
						
							
							
								 
						
							
							
							
								
							
								83ee820a16 
								
							
								 
							
						 
						
							
							
								
								lavfi/sendcmd: improve error reporting and robustness in case of missing commands  
							
							In particular, fix crash with -vf sendcmd, when no arguments are provided. 
							
						 
						10 years ago  
				
					
						
							
							
								 
						
							
							
							
								
							
								694671bc9a 
								
							
								 
							
						 
						
							
							
								
								avfilter/f_sendcmd: consider it an error if there are no commands  
							
							Signed-off-by: Michael Niedermayer <michaelni@gmx.at> 
							
						 
						10 years ago  
				
					
						
							
							
								 
						
							
							
							
								
							
								eb055295bd 
								
							
								 
							
						 
						
							
							
								
								avfilter/f_sendcmd: Use av_freep() to avoid leaving stale pointers in memory  
							
							Signed-off-by: Michael Niedermayer <michaelni@gmx.at> 
							
						 
						11 years ago  
				
					
						
							
							
								 
						
							
							
							
								
							
								b211607b5c 
								
							
								 
							
						 
						
							
							
								
								avfilter: various cosmetics  
							
							Signed-off-by: Paul B Mahol <onemda@gmail.com> 
							
						 
						12 years ago  
				
					
						
							
							
								 
						
							
							
							
								
							
								b077d8d908 
								
							
								 
							
						 
						
							
							
								
								avfilter: remove redundant .get_(audio/video)_buffer initializations  
							
							Signed-off-by: Paul B Mahol <onemda@gmail.com> 
							
						 
						12 years ago  
				
					
						
							
							
								 
						
							
							
							
								
							
								0b5627189d 
								
							
								 
							
						 
						
							
							
								
								avfilter/f_sendcmd: make const arrays static const  
							
							Signed-off-by: Michael Niedermayer <michaelni@gmx.at> 
							
						 
						12 years ago  
				
					
						
							
							
								 
						
							
							
							
								
							
								a1f234be11 
								
							
								 
							
						 
						
							
							
								
								make the ordering of the return type and av_cold consistent  
							
							Signed-off-by: Michael Niedermayer <michaelni@gmx.at> 
							
						 
						12 years ago  
				
					
						
							
							
								 
						
							
							
							
								
							
								df766673e5 
								
							
								 
							
						 
						
							
							
								
								lavfi/sendcmd: drop now pointless sendcmd/asendcmd_init() wrappers  
							
							
								
							
							
						 
						12 years ago  
				
					
						
							
							
								 
						
							
							
							
								
							
								5e893df7ae 
								
							
								 
							
						 
						
							
							
								
								lavfi/sendcmd: fix various "in in" rerepepetitions in messages  
							
							
								
							
							
						 
						12 years ago  
				
					
						
							
							
								 
						
							
							
							
								
							
								292f68154b 
								
							
								 
							
						 
						
							
							
								
								avfilter: Filter options that are used for both video and audio should have both flags  
							
							Signed-off-by: Michael Niedermayer <michaelni@gmx.at> 
							
						 
						12 years ago  
				
					
						
							
							
								 
						
							
							
							
								
							
								fd6228e657 
								
							
								 
							
						 
						
							
							
								
								lavfi: remove now unused args parameter from AVFilter.init and init_opaque  
							
							This is mostly automated global search and replace
The deprecated aconvert filter is disabled, if it still has users
it should be updated
Signed-off-by: Michael Niedermayer <michaelni@gmx.at> 
							
						 
						12 years ago  
				
					
						
							
							
								 
						
							
							
							
								
							
								7eb1ea2ae6 
								
							
								 
							
						 
						
							
							
								
								lavfi/sendcmd: switch to an AVOptions-based system.  
							
							
								
							
							
						 
						12 years ago  
				
					
						
							
							
								 
						
							
							
							
								
							
								35e81441fc 
								
							
								 
							
						 
						
							
							
								
								lavfi/sendcmd: switch to filter_frame API  
							
							
								
							
							
						 
						13 years ago  
				
					
						
							
							
								 
						
							
							
							
								
							
								3860e34b08 
								
							
								 
							
						 
						
							
							
								
								lavfi/sendcmd: expose the options for both filters.  
							
							
								
							
							
						 
						13 years ago  
				
					
						
							
							
								 
						
							
							
							
								
							
								0b70ffa4ac 
								
							
								 
							
						 
						
							
							
								
								lavfi/sendcmd: add FLAGS to AVOption array.  
							
							
								
							
							
						 
						13 years ago  
				
					
						
							
							
								 
						
							
							
							
								
							
								2d9d444051 
								
							
								 
							
						 
						
							
							
								
								lavfi: convert remaining input/output list compound literals to named objects.  
							
							This is following 568c70e79e 
							
						 
						13 years ago  
				
					
						
							
							
								 
						
							
							
							
								
							
								cd7febd33f 
								
							
								 
							
						 
						
							
							
								
								lavfi: replace filter_samples by filter_frame  
							
							Based on patch by Anton Khirnov
Signed-off-by: Michael Niedermayer <michaelni@gmx.at> 
							
						 
						13 years ago  
				
					
						
							
							
								 
						
							
							
							
								
							
								bd6240e7e9 
								
							
								 
							
						 
						
							
							
								
								lavfi/sendcmd: move buf init() variable to internal scope where it is used  
							
							
								
							
							
						 
						13 years ago  
				
					
						
							
							
								 
						
							
							
							
								
							
								c7065f1f89 
								
							
								 
							
						 
						
							
							
								
								lavfi/sendcmd: release file in case of failed allocation  
							
							Avoid hanging file. 
							
						 
						13 years ago  
				
					
						
							
							
								 
						
							
							
							
								
							
								740c995288 
								
							
								 
							
						 
						
							
							
								
								lavfi: add asendcmd and sendcmd filters  
							
							
								
							
							
						 
						13 years ago