EAGAIN is already managed in poll_filters().

Signed-off-by: Luca Barbato <lu_zero@gentoo.org>

Signed-off-by: Luca Barbato <lu_zero@gentoo.org>

Signed-off-by: Luca Barbato <lu_zero@gentoo.org>

`av_packet_unref` matches the AVFrame ref-counted API and can be used as
a drop in replacement.

Deprecate `av_free_packet`.

And drop the av_dup_packet from the input_thread.

Signed-off-by: Luca Barbato <lu_zero@gentoo.org>

There are no formats supporting it anymore and it is deprecated.
Update the documentation accordingly.

Signed-off-by: Anton Khirnov <anton@khirnov.net>

Deprecate the now unused option, but temporarily retain the capability
to disable the now default behaviour.

Mention this change in the AVPacket documentation.

Signed-off-by: Vittorio Giovara <vittorio.giovara@gmail.com>

Signed-off-by: Vittorio Giovara <vittorio.giovara@gmail.com>

Express bitfields more simply.

Signed-off-by: Vittorio Giovara <vittorio.giovara@gmail.com>

Convert doxygen to multiline and express bitfields more simply.

Signed-off-by: Vittorio Giovara <vittorio.giovara@gmail.com>

The rationale is that coded_frame was only used to communicate key_frame,
pict_type and quality to the caller, as well as a few other random fields,
in a non predictable, let alone consistent way.

There was agreement that there was no use case for coded_frame, as it is
a full-sized AVFrame container used for just 2-3 int-sized properties,
which shouldn't even belong into the AVCodecContext in the first place.

The appropriate AVPacket flag can be used instead of key_frame, while
quality is exported with the new AVPacketSideData quality factor.
There is no replacement for the other fields as they were unreliable,
mishandled or just not used at all.

Signed-off-by: Vittorio Giovara <vittorio.giovara@gmail.com>

This is necessary to preserve the quality information currently exported
with coded_frame. Add the new side data to every encoder that needs it,
and use it in avconv.

Signed-off-by: Vittorio Giovara <vittorio.giovara@gmail.com>

The current code is less than straightforward due to the fact that
output streams can be created based on filtergraph definitions. This
change should make the code simpler and more readable. It will also be
useful in the future commits.

It is a better place for it, there is no reason to wait until
transcode_init().

It more logically belongs there.

This will be useful in the following commits.

There is only one decoder left that supports this (libopus, which is not
used by default since we have a native one) and this code goes against
the avconv design, since it propagates information back from the encoder
to decoder.

We still want to flush the filters on EOF and possibly apply streamcopy.

This also ensures this is always done, avoiding infinite loops if an
error occurs at the end of the input.

The option is enabled by default, but can be disabled.

If this is enabled, such side data isn't copied into the output stream
(except when doing stream copy).

Signed-off-by: Martin Storsjö <martin@martin.st>

Bug-Id: CID 1292519

Signed-off-by: Luca Barbato <lu_zero@gentoo.org>

Since we are not doing encoding, there is no point in ever touching the
separate encoding context. Always use the stream codec context.

Fixes writing attachments.

CC:libav-devel@libav.org

Signed-off-by: Luca Barbato <lu_zero@gentoo.org>

exit_program() will try to free the decoders, which is not a good idea
from within get_format().
Return an error instead.

Signed-off-by: Martin Storsjö <martin@martin.st>

CC: libav-stable@libav.org
Bug-Id: CID 1224275

Data and subtitle streams might cause false positive.

Signed-off-by: Diego Biurrun <diego@biurrun.de>

It more accurately describes what this function does

This is required by the new API.

CC: libav-stable@libav.org

Bug-Id: 694

Use OutputStream.last_mux_dts as an approximation of 'current' output
time instead.

This makes it more clear what is this variable for exactly.

Doing anything with that field when we are doing streamcopy (so the
encoder is not opened) should have absolutely no effect.

This more clearly describes what is the variable used for.

Also, move its declaration into the block where it is actually used.