c2fc466351
avcodec/alsdec: use av_malloc(z)_array()
Signed-off-by: Paul B Mahol <onemda@gmail.com>
11 years ago
7f9f771eac
avcodec: Don't anonymously typedef structs
11 years ago
dccd648f9f
avcodec/alsdec: use init_get_bits8()
Signed-off-by: Paul B Mahol <onemda@gmail.com>
11 years ago
c67b449beb
dsputil: Split bswap*_buf() off into a separate context
12 years ago
6e6bd5481c
avcodec/alsdec: Clear MPEG4AudioConfig so that no use of uninitialized memory is possible
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
11 years ago
cc8163e1a3
avcodec: more correct printf specifiers
12 years ago
18f94df8af
avcodec/alsdec: check predictor order against block length
Fixes out of array access
Fixes: abd3c041acbcb816be113455d138166b-asan_heap-oob_b11634_3707_cov_1707137151_als_05_2ch48k16b.mp4
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
12 years ago
5c74fa6ce0
avcodec/alsdec: skip cases where the master channel equals the current channel
Fixes: msan_uninit-mem_7f6c73c97cf9_3571_als_04_2ch48k16b.mp4
Fixes use of uninitialized memory
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Reviewed-by: Thilo Borgmann <thilo.borgmann@mail.de>
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
12 years ago
2a0fb7286d
alsdec: check block length
Fix writing over the end
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Addresses: CVE-2013-0845
12 years ago
23a211cbba
lavc: change all decoders to behave consistently with AV_EF_CRCCHECK.
Just crccheck prints a warning, crccheck+explode returns an error.
Also document this behavior.
12 years ago
b2bed9325d
cosmetics: Group .name and .long_name together in codec/format declarations
12 years ago
6a64b23d93
Update my email address.
12 years ago
800637709c
alsdec: minor simplification in read_block()
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
12 years ago
ca488ad480
alsdec: Clean up error paths
Fix at least a memory leak.
CC: libav-stable@libav.org
12 years ago
70ecc175c7
alsdec: Fix the clipping range
mcc_weightings is only 32 elements.
Reported-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable@libav.org
12 years ago
2832ea26f3
Remove commented-out debug #define cruft
12 years ago
63d744e2be
av_log_missing_feature() ---> avpriv_report_missing_feature()
13 years ago
1ec94b0f06
lavc: factorize ff_{thread_,re,}get_buffer error messages.
Coccinelle profile used:
@@
expression r, ctx, f, loglevel, str, flags;
@@
-if ((r = ff_get_buffer(ctx, f, flags)) < 0) {
- av_log(ctx, loglevel, str);
- return r;
-}
+if ((r = ff_get_buffer(ctx, f, flags)) < 0)
+ return r;
@@
expression r, ctx, f, loglevel, str;
@@
-if ((r = ff_reget_buffer(ctx, f)) < 0) {
- av_log(ctx, loglevel, str);
- return r;
-}
+if ((r = ff_reget_buffer(ctx, f)) < 0)
+ return r;
@@
expression r, ctx, f, loglevel, str, flags;
@@
-if ((r = ff_thread_get_buffer(ctx, f, flags)) < 0) {
- av_log(ctx, loglevel, str);
- return r;
-}
+if ((r = ff_thread_get_buffer(ctx, f, flags)) < 0)
+ return r;
...along with some manual patches for the remaining ones.
13 years ago
759001c534
lavc decoders: work with refcounted frames.
13 years ago
9b0b355e97
als: decode directly to the user-provided AVFrame
13 years ago
4484c722f6
alsdec/read_specific_config: check for init_get_bits failure
This also fixes a potential integer overflow
Reviewed-by: Paul B Mahol <onemda@gmail.com>
Reviewed-by: Thilo Borgmann <thilo.borgmann@googlemail.com>
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
13 years ago
bfde6e5c02
alsdec: Introduce failsafe switch to keep ALSSpecificConfig consistent to the input.
Reveiwed-by: Paul B Mahol <onemda@gmail.com>
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
13 years ago
95f81159de
alsdec: Consistently use a period at the end of error messages.
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
13 years ago
d4211c4722
alsdec: change channel sorting so it match reference implementation
Read channel source instead of channel target for channel sorting.
Signed-off-by: Paul B Mahol <onemda@gmail.com>
13 years ago
d885cc41e5
Fix "knwon" typo and add a check in tools/patcheck
Signed-off-by: Paul B Mahol <onemda@gmail.com>
13 years ago
98fed176cf
alsdec: improve warning message when invalid channel position is found
Signed-off-by: Paul B Mahol <onemda@gmail.com>
13 years ago
fb3f28ee28
alsdec: cosmetics after previous commit
Signed-off-by: Paul B Mahol <onemda@gmail.com>
13 years ago
ae27b70b9d
alsdec: channel sorting
Signed-off-by: Paul B Mahol <onemda@gmail.com>
13 years ago
1818a1130d
alsdec: propagate error codes in read_block()
Reviewed-by: Thilo Borgmann <thilo.borgmann@googlemail.com>
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
13 years ago
0213d5ad86
alsdec: make return checking for read_*_block_data() consistent
Reviewed-by: Thilo Borgmann <thilo.borgmann@googlemail.com>
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
13 years ago
79bfba14b7
alsdec: Use AVERROR_INVALIDDATA in read_const_block_data
Reviewed-by: Thilo Borgmann <thilo.borgmann@googlemail.com>
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
13 years ago
0ceca269b6
alsdec: check block length
Fix writing over the end
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
13 years ago
594d4d5df3
lavc: add a wrapper for AVCodecContext.get_buffer().
It will be useful in the upcoming transition to refcounted AVFrames.
13 years ago
feaff427c0
alsdec: fix clipping of weightings for MCC decoding
Fixes CID717905
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
13 years ago
717addecad
Use proper return values in case of missing features
13 years ago
ee0f53e966
alsdec: fix misplaced parentheses.
Signed-off-by: Justin Ruggles <justin.ruggles@gmail.com>
13 years ago
ac3f5a6879
alsdec: check return values.
Signed-off-by: Justin Ruggles <justin.ruggles@gmail.com>
14 years ago
66197988b1
alsdec: fix number of decoded samples in first sub-block in BGMC mode.
Fixes CVE-2012-2790
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
Signed-off-by: Justin Ruggles <justin.ruggles@gmail.com>
14 years ago
97f0efbfb8
alsdec: Fix out of ltp_gain_values read.
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
Signed-off-by: Justin Ruggles <justin.ruggles@gmail.com>
14 years ago
5b051ec3bd
alsdec: Check that quantized parcor coeffs are within range.
ALS spec:
11.6.3.1.1 Quantization and encoding of parcor coefficients
...
In all cases the resulting quantized values ak are restricted to the range [-64,63].
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
Signed-off-by: Justin Ruggles <justin.ruggles@gmail.com>
14 years ago
23aae62c2c
alsdec: Check k used for rice decoder.
Values that fail this check will cause failure of decode_rice()
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
Signed-off-by: Justin Ruggles <justin.ruggles@gmail.com>
14 years ago
9853e41aa0
alsdec: check opt_order.
Fixes out of array write in quant_cof.
Also make sure no invalid opt_order stays in the context.
Fixes CVE-2012-2775
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
Signed-off-by: Justin Ruggles <justin.ruggles@gmail.com>
14 years ago
36ef5369ee
Replace all CODEC_ID_* with AV_CODEC_ID_*
13 years ago
b2527d5d5a
Revert "alsdec: remove dead assignments"
This reverts commit 4ca6d206d1
13 years ago
4ca6d206d1
alsdec: remove dead assignments
Signed-off-by: Mans Rullgard <mans@mansr.com>
13 years ago
396d2aecc5
alsdec.c: Also test 0 when checking rice decoder values.
Suggested-by: Thilo Borgmann
13 years ago
849172882c
alsdec.c: Simplify error check before calling rice decoder.
Reviewed-by: Thilo Borgmann
13 years ago
2837d8dc27
alsdec: fix number of decoded samples in first sub-block in BGMC mode.
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
14 years ago
6c3d6a214c
alsdec: Check k used for rice decoder.
Values that fail this check will cause failure of decode_rice()
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
14 years ago
00c3b67b8a
cosmetics: Align codec declarations
Also break some long lines, remove codec function placeholder comments
and add spaces in sample/pixel format lists.
Signed-off-by: Martin Storsjö <martin@martin.st>
14 years ago
Paul B Mahol
Diego Biurrun
Michael Niedermayer
Reinhard Tartler
Anton Khirnov
Thilo Borgmann
Luca Barbato
Clément Bœsch
Justin Ruggles
Mans Rullgard
Carl Eugen Hoyos
Martin Storsjö