FFmpeg

42357 Commits

32 Branches

1.0GB

Tree: b10b6ac7a9

Commit Graph

Author	SHA1	Message	Date
wm4	fbd6c97f9c	lavu: fix memory leaks by using a mutex instead of atomics The buffer pool has to atomically add and remove entries from the linked list of available buffers. This was done by removing the entire list with a CAS operation, working on it, and then setting it back again (using a retry-loop in case another thread was doing the same thing). This could effectively cause memory leaks: while a thread was working on the buffer list, other threads would allocate new buffers, increasing the pool's total size. There was no real leak, but since these extra buffers were not needed, but not free'd either (except when the buffer pool was destroyed), this had the same effects as a real leak. For some reason, growth was exponential, and could easily kill the process due to OOM in real-world uses. Fix this by using a mutex to protect the list operations. The fancy way atomics remove the whole list to work on it is not needed anymore, which also avoids the situation which was causing the leak. Signed-off-by: Anton Khirnov <anton@khirnov.net>	10 years ago
Anton Khirnov	1cec0624d0	AVBuffer: add a new API for buffer pools	12 years ago
Anton Khirnov	8e401dbe90	lavu: add a new API for reference-counted data buffers.	12 years ago

Author

SHA1

Message

Date

wm4

fbd6c97f9c

lavu: fix memory leaks by using a mutex instead of atomics

The buffer pool has to atomically add and remove entries from the linked
list of available buffers. This was done by removing the entire list
with a CAS operation, working on it, and then setting it back again
(using a retry-loop in case another thread was doing the same thing).

This could effectively cause memory leaks: while a thread was working on
the buffer list, other threads would allocate new buffers, increasing
the pool's total size. There was no real leak, but since these extra
buffers were not needed, but not free'd either (except when the buffer
pool was destroyed), this had the same effects as a real leak. For some
reason, growth was exponential, and could easily kill the process due
to OOM in real-world uses.

Fix this by using a mutex to protect the list operations. The fancy
way atomics remove the whole list to work on it is not needed anymore,
which also avoids the situation which was causing the leak.

Signed-off-by: Anton Khirnov <anton@khirnov.net>

10 years ago

Anton Khirnov

1cec0624d0

AVBuffer: add a new API for buffer pools

12 years ago

Anton Khirnov

8e401dbe90

lavu: add a new API for reference-counted data buffers.

12 years ago

3 Commits (b10b6ac7a902f28e09e37a29c392e2f0c19e9526)