FFv1 uses two types of coders, golomb and range with two different
tables. This is exposed this in a rather convoluted way, for example
mentioning to set coder type 1 while initializing the variable 'ac' to 2,
because encoder does not use range coder with default table.

Appropriate internal coder type values have been added and used in any
check rather than using raw numbers.

Initialization of avctx.coder_type in ffv1dec is removed because this
field is encoder only. An unneeded validation check in the encoder
is dropped too.

Signed-off-by: Vittorio Giovara <vittorio.giovara@gmail.com>

Bug-Id: CID 1295124

Signed-off-by: Diego Biurrun <diego@biurrun.de>

ffv1 does not use any part of the dsputil framework.

This avoids crashes when initializing the range coder for
the first slice context.

Reported-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable@libav.org
Signed-off-by: Martin Storsjö <martin@martin.st>

Based on code from Carl Eugen Hoyos, Michael Niedermayer and Paul B Mahol.

Signed-off-by: Diego Biurrun <diego@biurrun.de>

Also break some long lines, remove codec function placeholder comments
and add spaces in sample/pixel format lists.

Signed-off-by: Martin Storsjö <martin@martin.st>

Signed-off-by: Martin Storsjö <martin@martin.st>

init_get_bits() takes a number of bits and not a number of bytes as
its size argument.

Signed-off-by: Alex Converse <alex.converse@gmail.com>

It's more readable and less prone to breakage.

Signed-off-by: Mans Rullgard <mans@mansr.com>

The new tables is large enough to prevent this together with our image size checks.

Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
Signed-off-by: Anton Khirnov <anton@khirnov.net>

The _fast integer types provide no realworld benefits, but may introduce
portability issues and are just plain ugly.

Signed-off-by: Diego Biurrun <diego@biurrun.de>

Signed-off-by: Ronald S. Bultje <rsbultje@gmail.com>

This fixes a typo in the size calculation for the sample buffer
introduced in cbabccc367.

Signed-off-by: Mans Rullgard <mans@mansr.com>

Signed-off-by: Mans Rullgard <mans@mansr.com>

None of these symbols should be accessed directly, so declare them as
hidden.

Signed-off-by: Mans Rullgard <mans@mansr.com>

Originally committed as revision 25935 to svn://svn.ffmpeg.org/ffmpeg/trunk

Previously it was releasing the buffer which was returned to the user,
which was resulting in a crash in case of direct rendering.

Originally committed as revision 25678 to svn://svn.ffmpeg.org/ffmpeg/trunk

Originally committed as revision 25595 to svn://svn.ffmpeg.org/ffmpeg/trunk

Difference in filesizes to foreman ffv1 version=2, context=1 coder=1
18637016 adv-pass2-g300.avi
18638806 adv-pass1-g300.avi
18640534 ref-pass2-g300.avi
18918214 adv-pass2-g1.avi
18982048 ref-pass2-g1.avi
21516230 adv-pass1-g1.avi

Originally committed as revision 25594 to svn://svn.ffmpeg.org/ffmpeg/trunk

Originally committed as revision 25593 to svn://svn.ffmpeg.org/ffmpeg/trunk

Originally committed as revision 25592 to svn://svn.ffmpeg.org/ffmpeg/trunk

Originally committed as revision 25584 to svn://svn.ffmpeg.org/ffmpeg/trunk

Originally committed as revision 25583 to svn://svn.ffmpeg.org/ffmpeg/trunk

Originally committed as revision 25582 to svn://svn.ffmpeg.org/ffmpeg/trunk

Originally committed as revision 25581 to svn://svn.ffmpeg.org/ffmpeg/trunk

Originally committed as revision 25580 to svn://svn.ffmpeg.org/ffmpeg/trunk

Originally committed as revision 25579 to svn://svn.ffmpeg.org/ffmpeg/trunk

Originally committed as revision 25578 to svn://svn.ffmpeg.org/ffmpeg/trunk

Originally committed as revision 25577 to svn://svn.ffmpeg.org/ffmpeg/trunk

Originally committed as revision 25571 to svn://svn.ffmpeg.org/ffmpeg/trunk

Originally committed as revision 25570 to svn://svn.ffmpeg.org/ffmpeg/trunk

Originally committed as revision 25563 to svn://svn.ffmpeg.org/ffmpeg/trunk

Originally committed as revision 25562 to svn://svn.ffmpeg.org/ffmpeg/trunk

Originally committed as revision 25561 to svn://svn.ffmpeg.org/ffmpeg/trunk