The function was introduced in 4d6a8a2bdb and is not used anymore
outside avfilter.c.

This avoids to pollute the public API with an apparently unnecessary
function. The function was introduced a few days ago, so removing it from
the public API should do no much harm.

These utilities are meant to be defined in avfilter.c, since they are
generic and thus contain both audio and video code.

They are only useful inside filters and we don't allow user filters for
now.

They are only useful inside filters and we don't allow user filters for
now.

It is only useful inside filters and we don't allow user filters for
now.

The function is modelled after av_default_item_name(), and will print the
name of the instance filter if defined, otherwise the name of the filter.

This allows to show the instance name in the log, which is useful when
debugging complex filter graphs.

Please help setting the category for all remaining AVClasses

Signed-off-by: Michael Niedermayer <michaelni@gmx.at>

Signed-off-by: Paul B Mahol <onemda@gmail.com>

Link properties have to be checked after config_props() is called to
make sure everything is sane, so the default config_props() for output
links was redundant.

Remove now empty defaults.c

Signed-off-by: Anton Khirnov <anton@khirnov.net>

The planar/packed switch and the packing_formats list is no longer
required, since the planar/packed information is now stored in the sample
format enum.

This is technically a major API break, possibly it should be not too
painful as we marked the audio filtering API as unstable.

This fixes a compilation failure with -DDEBUG.

This is easier to follow than having them randomly scattered in
avfilter.c and defaults.c.

Signed-off-by: Michael Niedermayer <michaelni@gmx.at>

This is easier to follow than having them randomly scattered in
avfilter.c and defaults.c.

Those functions are only useful inside filters. It is better to not
support user filters until the API is more stable.

This breaks audio filtering API and ABI in theory, but since it's
unusable right now this shouldn't be a problem.

The additional parameters are just complicating the function interface.

Assume that a requested samples buffer will *always* have the format
specified in the requested link.

This breaks audio filtering API and ABI in theory, but since it's
unusable right now this shouldn't be a problem.

Signed-off-by: Anton Khirnov <anton@khirnov.net>

Remove AVFilterBufferRefAudioProps.size, and use nb_samples in its place
everywhere.
This is required as the size in the audio buffer may be aligned, so it
may not contain a well defined number of samples.

Also remove the useless planar parameter, which can be deduced from the
sample format.

This is technically an API and ABI break, but since the audio part of
lavfi is not usable now, this should not be a problem in practice.

Signed-off-by: Anton Khirnov <anton@khirnov.net>

Signed-off-by: Anton Khirnov <anton@khirnov.net>

This is similar to what has previously been done in AVFrame to allow
dealing with more than 8 channels.

Based on a commit by Stefano Sabatini <stefano.sabatini-lala@poste.it>

A nontrivial public function such as this should most certainly NOT be
inline.

The call to the next filter_sample will likely unref the
current buffer, so it is not possible to read it afterwards.

Keep a heap of all sink links ordered by timestamps.

Signed-off-by: Stefano Sabatini <stefasab@gmail.com>

this way avfilter_free() can be called without NULL checks.

Signed-off-by: Michael Niedermayer <michaelni@gmx.at>

Signed-off-by: Michael Niedermayer <michaelni@gmx.at>

This should fix a memleak.

Signed-off-by: Michael Niedermayer <michaelni@gmx.at>

Avoid out-of-buffer data access when nb_channels is 8.

The traces end up not indented and ugly anyway, but with the additional
spaces are much more painful to grep/parse.

avfilter_copy_frame_props() avoids code duplication and increases
robustness.

Signed-off-by: Michael Niedermayer <michaelni@gmx.at>

It makes more sense for a bit mask to use an unsigned type.
The change should be source and binary compatible on all
supported systems, hence micro version bump.

Fixes a few invalid shifts.

Signed-off-by: Mans Rullgard <mans@mansr.com>

Issue an error and return a more meaningful error code in case the
maximum number of registered filters has been reached.
This is better than silently ignore the error, improve feedback.

Simplify expressions, improve readability.

The set value depends on the input link, or on the sample_rate value.
Avoids the need to explicitely set the time_base value.

Also consistent with AVCodecContext.sample_rate. Simplify/avoid
pointless type checks and conversions.

Breaks audio API/ABI.

The additional parameters were never used and are complicating the
function interface. Also, they were inconsistent with the way the
video API works.

So this assumes that a requested samples buffer will have *always* the
format specified in the requested link.

This breaks audio filtering API and ABI.

Found-by: Nicolas George
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>

Signed-off-by: Michael Niedermayer <michaelni@gmx.at>

Signed-off-by: Michael Niedermayer <michaelni@gmx.at>

Link properties have to be checked after config_props() is called to
make sure everything is sane, so the default config_props() for output
links was redundant.

Also remove channel_layout check as it is now negotiated.

Signed-off-by: Stefano Sabatini <stefano.sabatini-lala@poste.it>

Signed-off-by: Stefano Sabatini <stefano.sabatini-lala@poste.it>

This fix introduces a small memleak

Signed-off-by: Michael Niedermayer <michaelni@gmx.at>