| Author | SHA1 | Message | Date | 
|---|---|---|---|
| 
							
							
								 | 
						fc3a03fcf9 | 
							
							
								
								avfilter: take_samples: do not directly return frame when samples are skipped
							
							
							
							
							
							
								
							
							
							Modifying data pointer when skipping samples may make it unaligned.
Workaround for Ticket6349.
This should fix the crash of ticket's testcase and a crash/regression
with avxsynth (reported by Michael Niedermayer).
Also change frame->nb_samples < max to frame->nb_samples <= max.
This improves performance. Benchmark:
./ffmpeg -filter_complex "aevalsrc=0:n=1166,firequalizer=fixed=on" -f null null
old:
  25767 decicycles in take_samples,    1023 runs,      1 skips
  25422 decicycles in take_samples,    2047 runs,      1 skips
  25181 decicycles in take_samples,    4095 runs,      1 skips
  24904 decicycles in take_samples,    8191 runs,      1 skips
new:
    550 decicycles in take_samples,    1024 runs,      0 skips
    548 decicycles in take_samples,    2048 runs,      0 skips
    545 decicycles in take_samples,    4096 runs,      0 skips
    544 decicycles in take_samples,    8192 runs,      0 skips
Reviewed-by: Nicolas George <george@nsup.org>
Reviewed-by: Michael Niedermayer <michael@niedermayer.cc>
Reviewed-by: Paul B Mahol <onemda@gmail.com>
Signed-off-by: Muhammad Faiz <mfcc64@gmail.com>
							
						 | 
						8 years ago | 
| 
							
							
								 | 
						383057f8e7 | 
							
							
								
								lavfi: make ff_framequeue_skip_samples() more useful.
							
							
							
							
							
							
								
							
							
							Instead of just updating statistics and leaving the work to the call site, have it actually do the work. Also: skip the samples by updating the frame data pointers instead of moving the samples. More efficient and avoid writing into shared frames. Found-By: Muhammad Faiz <mfcc64@gmail.com>  | 
						8 years ago | 
| 
							
							
								 | 
						bec8ea20c8 | 
							
							
								
								lavfi/framequeue: avoid empty structs.
							
							
							
							
							
							
								
							
							
							Fix compilation on MSVC.  | 
						9 years ago | 
| 
							
							
								 | 
						62b11db0a0 | lavfi: add FFFrameQueue API. | 10 years ago |