Browse Source

Merge commit '60392480181f24ebf3ab48d8ac3614705de90152'

* commit '60392480181f24ebf3ab48d8ac3614705de90152':
  mem: fix pointer pointer aliasing violations

Conflicts:
	libavutil/mem.c

Merged-by: Michael Niedermayer <michaelni@gmx.at>
tags/n2.6
Michael Niedermayer 10 years ago
parent
commit
fa73358c9b
1 changed files with 18 additions and 11 deletions
  1. +18
    -11
      libavutil/mem.c

+ 18
- 11
libavutil/mem.c View File

@@ -184,21 +184,22 @@ void *av_realloc_f(void *ptr, size_t nelem, size_t elsize)


int av_reallocp(void *ptr, size_t size) int av_reallocp(void *ptr, size_t size)
{ {
void **ptrptr = ptr;
void *ret;
void *val;


if (!size) { if (!size) {
av_freep(ptr); av_freep(ptr);
return 0; return 0;
} }
ret = av_realloc(*ptrptr, size);


if (!ret) {
memcpy(&val, ptr, sizeof(val));
val = av_realloc(val, size);

if (!val) {
av_freep(ptr); av_freep(ptr);
return AVERROR(ENOMEM); return AVERROR(ENOMEM);
} }


*ptrptr = ret;
memcpy(ptr, &val, sizeof(val));
return 0; return 0;
} }


@@ -211,10 +212,14 @@ void *av_realloc_array(void *ptr, size_t nmemb, size_t size)


int av_reallocp_array(void *ptr, size_t nmemb, size_t size) int av_reallocp_array(void *ptr, size_t nmemb, size_t size)
{ {
void **ptrptr = ptr;
*ptrptr = av_realloc_f(*ptrptr, nmemb, size);
if (!*ptrptr && nmemb && size)
void *val;

memcpy(&val, ptr, sizeof(val));
val = av_realloc_f(val, nmemb, size);
memcpy(ptr, &val, sizeof(val));
if (!val && nmemb && size)
return AVERROR(ENOMEM); return AVERROR(ENOMEM);

return 0; return 0;
} }


@@ -235,9 +240,11 @@ void av_free(void *ptr)


void av_freep(void *arg) void av_freep(void *arg)
{ {
void **ptr = (void **)arg;
av_free(*ptr);
*ptr = NULL;
void *val;

memcpy(&val, arg, sizeof(val));
memcpy(arg, &(void *){ NULL }, sizeof(val));
av_free(val);
} }


void *av_mallocz(size_t size) void *av_mallocz(size_t size)


Loading…
Cancel
Save