Browse Source

aacenc_tns: fix out-of-bounds array access

Since the coefficients are stepped up to order + 1 it was possible
that it went over TNS_MAX_ORDER. Also just return in case the only
coefficient is less than the threshold.

Signed-off-by: Rostislav Pehlivanov <atomnuker@gmail.com>
tags/n2.8
Rostislav Pehlivanov 9 years ago
parent
commit
e924967fd5
1 changed files with 4 additions and 1 deletions
  1. +4
    -1
      libavcodec/aacenc_tns.c

+ 4
- 1
libavcodec/aacenc_tns.c View File

@@ -97,6 +97,10 @@ static void process_tns_coeffs(TemporalNoiseShaping *tns, double *coef_raw,
break;
}
}
order = av_clip(order, 0, TNS_MAX_ORDER - 1);
*order_p = order;
if (!order)
return;

/* Step up procedure, convert to LPC coeffs */
out[0] = 1.0f;
@@ -109,7 +113,6 @@ static void process_tns_coeffs(TemporalNoiseShaping *tns, double *coef_raw,
}
out[i] = lpc[i-1];
}
*order_p = order;
memcpy(lpc, out, TNS_MAX_ORDER*sizeof(float));
}



Loading…
Cancel
Save