Browse Source

avcodec/apedec: Fixes integer overflow of res+*data in do_apply_filter()

Fixes: signed integer overflow: 7400 + 2147482786 cannot be represented in type 'int'
Fixes: 18405/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APE_fuzzer-5708834760294400

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
tags/n4.3
Michael Niedermayer 5 years ago
parent
commit
dc3f327e74
1 changed files with 1 additions and 1 deletions
  1. +1
    -1
      libavcodec/apedec.c

+ 1
- 1
libavcodec/apedec.c View File

@@ -1272,7 +1272,7 @@ static void do_apply_filter(APEContext *ctx, int version, APEFilter *f,
f->adaptcoeffs - order, f->adaptcoeffs - order,
order, APESIGN(*data)); order, APESIGN(*data));
res = (int)(res + (1U << (fracbits - 1))) >> fracbits; res = (int)(res + (1U << (fracbits - 1))) >> fracbits;
res += *data;
res += (unsigned)*data;
*data++ = res; *data++ = res;


/* Update the output history */ /* Update the output history */


Loading…
Cancel
Save