Browse Source

vc1dec: wmv2dec: Validate ff_intrax8_common_init return value

tags/n3.1
Vittorio Giovara 9 years ago
parent
commit
d909f43b5c
2 changed files with 7 additions and 7 deletions
  1. +6
    -4
      libavcodec/vc1dec.c
  2. +1
    -3
      libavcodec/wmv2dec.c

+ 6
- 4
libavcodec/vc1dec.c View File

@@ -314,7 +314,7 @@ static void vc1_sprite_flush(AVCodecContext *avctx)
av_cold int ff_vc1_decode_init_alloc_tables(VC1Context *v) av_cold int ff_vc1_decode_init_alloc_tables(VC1Context *v)
{ {
MpegEncContext *s = &v->s; MpegEncContext *s = &v->s;
int i;
int i, ret = AVERROR(ENOMEM);
int mb_height = FFALIGN(s->mb_height, 2); int mb_height = FFALIGN(s->mb_height, 2);


/* Allocate mb bitplanes */ /* Allocate mb bitplanes */
@@ -371,8 +371,6 @@ av_cold int ff_vc1_decode_init_alloc_tables(VC1Context *v)
v->mv_f_next[0] = v->mv_f_next_base + s->b8_stride + 1; v->mv_f_next[0] = v->mv_f_next_base + s->b8_stride + 1;
v->mv_f_next[1] = v->mv_f_next[0] + (s->b8_stride * (mb_height * 2 + 1) + s->mb_stride * (mb_height + 1) * 2); v->mv_f_next[1] = v->mv_f_next[0] + (s->b8_stride * (mb_height * 2 + 1) + s->mb_stride * (mb_height + 1) * 2);


ff_intrax8_common_init(&v->x8,s);

if (s->avctx->codec_id == AV_CODEC_ID_WMV3IMAGE || s->avctx->codec_id == AV_CODEC_ID_VC1IMAGE) { if (s->avctx->codec_id == AV_CODEC_ID_WMV3IMAGE || s->avctx->codec_id == AV_CODEC_ID_VC1IMAGE) {
for (i = 0; i < 4; i++) { for (i = 0; i < 4; i++) {
v->sr_rows[i >> 1][i & 1] = av_malloc(v->output_width); v->sr_rows[i >> 1][i & 1] = av_malloc(v->output_width);
@@ -381,11 +379,15 @@ av_cold int ff_vc1_decode_init_alloc_tables(VC1Context *v)
} }
} }


ret = ff_intrax8_common_init(&v->x8, s);
if (ret < 0)
goto error;

return 0; return 0;


error: error:
ff_vc1_decode_end(s->avctx); ff_vc1_decode_end(s->avctx);
return AVERROR(ENOMEM);
return ret;
} }


av_cold void ff_vc1_init_transposed_scantables(VC1Context *v) av_cold void ff_vc1_init_transposed_scantables(VC1Context *v)


+ 1
- 3
libavcodec/wmv2dec.c View File

@@ -471,9 +471,7 @@ static av_cold int wmv2_decode_init(AVCodecContext *avctx)


ff_wmv2_common_init(w); ff_wmv2_common_init(w);


ff_intrax8_common_init(&w->x8, &w->s);

return 0;
return ff_intrax8_common_init(&w->x8, &w->s);
} }


static av_cold int wmv2_decode_end(AVCodecContext *avctx) static av_cold int wmv2_decode_end(AVCodecContext *avctx)


Loading…
Cancel
Save