Browse Source

smc: fix the bounds check

Fixes invalid writes when there are more blocks in a run than total
remaining blocks.

CC: libav-stable@libav.org
Bug-ID: CVE-2014-8548
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Anton Khirnov <anton@khirnov.net>
tags/n2.6
Michael Niedermayer Anton Khirnov 11 years ago
parent
commit
d423dd72be
1 changed files with 1 additions and 1 deletions
  1. +1
    -1
      libavcodec/smc.c

+ 1
- 1
libavcodec/smc.c View File

@@ -70,7 +70,7 @@ typedef struct SmcContext {
row_ptr += stride * 4; \
} \
total_blocks--; \
if (total_blocks < 0) \
if (total_blocks < !!n_blocks) \
{ \
av_log(s->avctx, AV_LOG_INFO, "warning: block counter just went negative (this should not happen)\n"); \
return; \


Loading…
Cancel
Save