Browse Source

h264: manually save/restore XMM registers for functions using INIT_MMX.

On Win64, these registers are callee-save, so not saving/restoring them
correctly is a violation of ABI and can lead to crashes or corrupt data.
tags/n0.11
Ronald S. Bultje 14 years ago
parent
commit
ce1e250ee9
2 changed files with 6 additions and 0 deletions
  1. +3
    -0
      libavcodec/x86/h264_idct.asm
  2. +3
    -0
      libavcodec/x86/h264_intrapred.asm

+ 3
- 0
libavcodec/x86/h264_idct.asm View File

@@ -968,6 +968,9 @@ cglobal h264_idct_add8_8_sse2, 5, 7, 8

%macro IDCT_DC_DEQUANT 2
cglobal h264_luma_dc_dequant_idct_%1, 3,4,%2
; manually spill XMM registers for Win64 because
; the code here is initialized with INIT_MMX
WIN64_SPILL_XMM %2
movq m3, [r1+24]
movq m2, [r1+16]
movq m1, [r1+ 8]


+ 3
- 0
libavcodec/x86/h264_intrapred.asm View File

@@ -1931,6 +1931,9 @@ cglobal pred8x8l_vertical_right_mmxext, 4,5

%macro PRED8x8L_VERTICAL_RIGHT 1
cglobal pred8x8l_vertical_right_%1, 4,5,7
; manually spill XMM registers for Win64 because
; the code here is initialized with INIT_MMX
WIN64_SPILL_XMM 7
sub r0, r3
lea r4, [r0+r3*2]
movq mm0, [r0+r3*1-8]


Loading…
Cancel
Save