Browse Source

avcodec/ffwavesynth: Simplify lcg_seek(), avoid negative case

Fixes: negation of -9223372036854775808 cannot be represented in type 'int64_t' (aka 'long'); cast to an unsigned type to negate this value to itself
Fixes: 15289/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FFWAVESYNTH_fuzzer-5709034499342336

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 8c02209935)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
tags/n4.0.5
Michael Niedermayer 6 years ago
parent
commit
cd256485da
1 changed files with 3 additions and 9 deletions
  1. +3
    -9
      libavcodec/ffwavesynth.c

+ 3
- 9
libavcodec/ffwavesynth.c View File

@@ -113,18 +113,12 @@ static uint32_t lcg_next(uint32_t *s)
return *s; return *s;
} }


static void lcg_seek(uint32_t *s, int64_t dt)
static void lcg_seek(uint32_t *s, uint32_t dt)
{ {
uint32_t a, c, t = *s; uint32_t a, c, t = *s;


if (dt >= 0) {
a = LCG_A;
c = LCG_C;
} else { /* coefficients for a step backward */
a = LCG_AI;
c = (uint32_t)(-LCG_AI * LCG_C);
dt = -dt;
}
a = LCG_A;
c = LCG_C;
while (dt) { while (dt) {
if (dt & 1) if (dt & 1)
t = a * t + c; t = a * t + c;


Loading…
Cancel
Save