Browse Source

Revert "decode: copy the output parameters from the last bsf in the chain back to the AVCodecContext"

This reverts commit 662558f985.

The avcodec_parameters_to_context() call was freeing and reallocating
AVCodecContext->extradata, essentially taking ownership of it, which according
to the doxy is user owned. This is an API break and has produces crashes in
some library users like Firefox.
Revert until a better solution is found to internally propagate the filtered
extradata back into the decoder context.

Signed-off-by: James Almer <jamrial@gmail.com>
tags/n4.2
James Almer 7 years ago
parent
commit
cacb62f9cb
1 changed files with 0 additions and 4 deletions
  1. +0
    -4
      libavcodec/decode.c

+ 0
- 4
libavcodec/decode.c View File

@@ -221,10 +221,6 @@ int ff_decode_bsfs_init(AVCodecContext *avctx)
goto fail;
}

ret = avcodec_parameters_to_context(avctx, s->bsfs[s->nb_bsfs - 1]->par_out);
if (ret < 0)
return ret;

return 0;
fail:
ff_decode_bsfs_uninit(avctx);


Loading…
Cancel
Save