Browse Source

avfilter/af_headphone: Fix leak of channel layouts list on error

In case the multichannel HRIR mode was enabled, an error could happen
between allocating a channel layouts list and attaching it to its target
destination. If an error happened, the list would leak. This is fixed by
attaching the list to its target directly after its allocation.

Reviewed-by: Paul B Mahol <onemda@gmail.com>
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
tags/n4.4
Andreas Rheinhardt 5 years ago
parent
commit
ca8e5dedc7
1 changed files with 3 additions and 4 deletions
  1. +3
    -4
      libavfilter/af_headphone.c

+ 3
- 4
libavfilter/af_headphone.c View File

@@ -703,6 +703,9 @@ static int query_formats(AVFilterContext *ctx)
return ret;

ret = ff_add_channel_layout(&stereo_layout, AV_CH_LAYOUT_STEREO);
if (ret)
return ret;
ret = ff_channel_layouts_ref(stereo_layout, &ctx->outputs[0]->in_channel_layouts);
if (ret)
return ret;

@@ -721,10 +724,6 @@ static int query_formats(AVFilterContext *ctx)
}
}

ret = ff_channel_layouts_ref(stereo_layout, &ctx->outputs[0]->in_channel_layouts);
if (ret)
return ret;

formats = ff_all_samplerates();
if (!formats)
return AVERROR(ENOMEM);


Loading…
Cancel
Save