Browse Source

avfilter: do not leak AVFrame on failed buffer allocation

Signed-off-by: Paul B Mahol <onemda@gmail.com>
tags/n3.4
Paul B Mahol 8 years ago
parent
commit
c90b88090c
8 changed files with 24 additions and 8 deletions
  1. +3
    -1
      libavfilter/af_aphaser.c
  2. +3
    -1
      libavfilter/af_aresample.c
  3. +3
    -1
      libavfilter/af_atempo.c
  4. +3
    -1
      libavfilter/af_bs2b.c
  5. +3
    -1
      libavfilter/af_pan.c
  6. +3
    -1
      libavfilter/af_volume.c
  7. +3
    -1
      libavfilter/vf_eq.c
  8. +3
    -1
      libavfilter/vf_fftfilt.c

+ 3
- 1
libavfilter/af_aphaser.c View File

@@ -248,8 +248,10 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *inbuf)
outbuf = inbuf;
} else {
outbuf = ff_get_audio_buffer(inlink, inbuf->nb_samples);
if (!outbuf)
if (!outbuf) {
av_frame_free(&inbuf);
return AVERROR(ENOMEM);
}
av_frame_copy_props(outbuf, inbuf);
}



+ 3
- 1
libavfilter/af_aresample.c View File

@@ -195,8 +195,10 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *insamplesref)

outsamplesref = ff_get_audio_buffer(outlink, n_out);

if(!outsamplesref)
if(!outsamplesref) {
av_frame_free(&insamplesref);
return AVERROR(ENOMEM);
}

av_frame_copy_props(outsamplesref, insamplesref);
outsamplesref->format = outlink->format;


+ 3
- 1
libavfilter/af_atempo.c View File

@@ -1090,8 +1090,10 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *src_buffer)
while (src < src_end) {
if (!atempo->dst_buffer) {
atempo->dst_buffer = ff_get_audio_buffer(outlink, n_out);
if (!atempo->dst_buffer)
if (!atempo->dst_buffer) {
av_frame_free(&src_buffer);
return AVERROR(ENOMEM);
}
av_frame_copy_props(atempo->dst_buffer, src_buffer);

atempo->dst = atempo->dst_buffer->data[0];


+ 3
- 1
libavfilter/af_bs2b.c View File

@@ -134,8 +134,10 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *frame)
out_frame = frame;
} else {
out_frame = ff_get_audio_buffer(inlink, frame->nb_samples);
if (!out_frame)
if (!out_frame) {
av_frame_free(&frame);
return AVERROR(ENOMEM);
}
av_frame_copy(out_frame, frame);
ret = av_frame_copy_props(out_frame, frame);
if (ret < 0) {


+ 3
- 1
libavfilter/af_pan.c View File

@@ -383,8 +383,10 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *insamples)
AVFrame *outsamples = ff_get_audio_buffer(outlink, n);
PanContext *pan = inlink->dst->priv;

if (!outsamples)
if (!outsamples) {
av_frame_free(&insamples);
return AVERROR(ENOMEM);
}
swr_convert(pan->swr, outsamples->extended_data, n,
(void *)insamples->extended_data, n);
av_frame_copy_props(outsamples, insamples);


+ 3
- 1
libavfilter/af_volume.c View File

@@ -411,8 +411,10 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *buf)
out_buf = buf;
} else {
out_buf = ff_get_audio_buffer(inlink, nb_samples);
if (!out_buf)
if (!out_buf) {
av_frame_free(&buf);
return AVERROR(ENOMEM);
}
ret = av_frame_copy_props(out_buf, buf);
if (ret < 0) {
av_frame_free(&out_buf);


+ 3
- 1
libavfilter/vf_eq.c View File

@@ -259,8 +259,10 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *in)
int i;

out = ff_get_video_buffer(outlink, inlink->w, inlink->h);
if (!out)
if (!out) {
av_frame_free(&in);
return AVERROR(ENOMEM);
}

av_frame_copy_props(out, in);
desc = av_pix_fmt_desc_get(inlink->format);


+ 3
- 1
libavfilter/vf_fftfilt.c View File

@@ -255,8 +255,10 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *in)
int i, j, plane;

out = ff_get_video_buffer(outlink, inlink->w, inlink->h);
if (!out)
if (!out) {
av_frame_free(&in);
return AVERROR(ENOMEM);
}

av_frame_copy_props(out, in);



Loading…
Cancel
Save