From b89c16e73eef30b7ce95bd455d9b419b383d9409 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Cl=C3=A9ment=20B=C5=93sch?= Date: Tue, 18 Sep 2012 18:49:09 +0200 Subject: [PATCH] lavfi/select: make sure avctx is set before closing it. This avoid a crash when the filter fails before config_input(), typically with a syntax error in the next filter: select=gt(scene\,.4),select=fail --- libavfilter/vf_select.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavfilter/vf_select.c b/libavfilter/vf_select.c index d47876bbba..72af50e646 100644 --- a/libavfilter/vf_select.c +++ b/libavfilter/vf_select.c @@ -383,8 +383,10 @@ static av_cold void uninit(AVFilterContext *ctx) if (select->do_scene_detect) { avfilter_unref_bufferp(&select->prev_picref); - avcodec_close(select->avctx); - av_freep(&select->avctx); + if (select->avctx) { + avcodec_close(select->avctx); + av_freep(&select->avctx); + } } }