Browse Source

pthread_frame: use atomics for frame progress

Merges Libav commit 59c70227.

Signed-off-by: wm4 <nfxjfg@googlemail.com>
tags/n3.3
Anton Khirnov wm4 9 years ago
parent
commit
b6587421c7
1 changed files with 17 additions and 10 deletions
  1. +17
    -10
      libavcodec/pthread_frame.c

+ 17
- 10
libavcodec/pthread_frame.c View File

@@ -486,9 +486,11 @@ int ff_thread_decode_frame(AVCodecContext *avctx,
void ff_thread_report_progress(ThreadFrame *f, int n, int field)
{
PerThreadContext *p;
volatile int *progress = f->progress ? (int*)f->progress->data : NULL;
atomic_int *progress = f->progress ? (atomic_int*)f->progress->data : NULL;

if (!progress || progress[field] >= n) return;
if (!progress ||
atomic_load_explicit(&progress[field], memory_order_acquire) >= n)
return;

p = f->owner->internal->thread_ctx;

@@ -496,7 +498,9 @@ void ff_thread_report_progress(ThreadFrame *f, int n, int field)
av_log(f->owner, AV_LOG_DEBUG, "%p finished %d field %d\n", progress, n, field);

pthread_mutex_lock(&p->progress_mutex);
progress[field] = n;

atomic_store(&progress[field], n);

pthread_cond_broadcast(&p->progress_cond);
pthread_mutex_unlock(&p->progress_mutex);
}
@@ -504,9 +508,11 @@ void ff_thread_report_progress(ThreadFrame *f, int n, int field)
void ff_thread_await_progress(ThreadFrame *f, int n, int field)
{
PerThreadContext *p;
volatile int *progress = f->progress ? (int*)f->progress->data : NULL;
atomic_int *progress = f->progress ? (atomic_int*)f->progress->data : NULL;

if (!progress || progress[field] >= n) return;
if (!progress ||
atomic_load_explicit(&progress[field], memory_order_acquire) >= n)
return;

p = f->owner->internal->thread_ctx;

@@ -514,7 +520,7 @@ void ff_thread_await_progress(ThreadFrame *f, int n, int field)
av_log(f->owner, AV_LOG_DEBUG, "thread awaiting %d field %d from %p\n", n, field, progress);

pthread_mutex_lock(&p->progress_mutex);
while (progress[field] < n)
while (atomic_load_explicit(&progress[field], memory_order_relaxed) < n)
pthread_cond_wait(&p->progress_cond, &p->progress_mutex);
pthread_mutex_unlock(&p->progress_mutex);
}
@@ -789,14 +795,15 @@ static int thread_get_buffer_internal(AVCodecContext *avctx, ThreadFrame *f, int
}

if (avctx->internal->allocate_progress) {
int *progress;
f->progress = av_buffer_alloc(2 * sizeof(int));
atomic_int *progress;
f->progress = av_buffer_alloc(2 * sizeof(*progress));
if (!f->progress) {
return AVERROR(ENOMEM);
}
progress = (int*)f->progress->data;
progress = (atomic_int*)f->progress->data;

progress[0] = progress[1] = -1;
atomic_store(&progress[0], -1);
atomic_store(&progress[1], -1);
}

pthread_mutex_lock(&p->parent->buffer_mutex);


Loading…
Cancel
Save