Browse Source

avformat/oggparsevorbis: free base64 encoded data immediately after decoding it

It has no use afterwards and freeing it before calling ff_flac_parse_picture()
may help prevent OOM issues on memory constrained scenarios.

Signed-off-by: James Almer <jamrial@gmail.com>
tags/n3.1
James Almer 9 years ago
parent
commit
afd04058bc
1 changed files with 3 additions and 2 deletions
  1. +3
    -2
      libavformat/oggparsevorbis.c

+ 3
- 2
libavformat/oggparsevorbis.c View File

@@ -161,10 +161,11 @@ int ff_vorbis_comment(AVFormatContext *as, AVDictionary **m,
av_freep(&ct);
continue;
}
if ((ret = av_base64_decode(pict, ct, len)) > 0)
ret = ff_flac_parse_picture(as, pict, ret);
ret = av_base64_decode(pict, ct, len);
av_freep(&tt);
av_freep(&ct);
if (ret > 0)
ret = ff_flac_parse_picture(as, pict, ret);
av_freep(&pict);
if (ret < 0) {
av_log(as, AV_LOG_WARNING, "Failed to parse cover art block.\n");


Loading…
Cancel
Save