Browse Source

Merge commit '94603feb1b3ad01a821a1a1cef1570b13f471821'

* commit '94603feb1b3ad01a821a1a1cef1570b13f471821':
  h264_ps: when parsing a VUI fails, only abort when explode is set

Merge only for metadata, ignoring invalid data can put the context
into an invalid state and can possibly be used for remote code
execution exploits.
Also we support all non standard VUIs that have been reported so
ignoring parsing failure makes no sense for us unless theres
some issue that has not been reported

Merged-by: Michael Niedermayer <michaelni@gmx.at>
tags/n2.2-rc1
Michael Niedermayer 12 years ago
parent
commit
ac3fa95e73
1 changed files with 4 additions and 2 deletions
  1. +4
    -2
      libavcodec/h264_ps.c

+ 4
- 2
libavcodec/h264_ps.c View File

@@ -520,9 +520,11 @@ int ff_h264_decode_seq_parameter_set(H264Context *h)
} }


sps->vui_parameters_present_flag = get_bits1(&h->gb); sps->vui_parameters_present_flag = get_bits1(&h->gb);
if (sps->vui_parameters_present_flag)
if (decode_vui_parameters(h, sps) < 0)
if (sps->vui_parameters_present_flag) {
int ret = decode_vui_parameters(h, sps);
if (ret < 0)
goto fail; goto fail;
}


if (!sps->sar.den) if (!sps->sar.den)
sps->sar.den = 1; sps->sar.den = 1;


Loading…
Cancel
Save