Browse Source

avformat/mp3dec: fix msan warning when verifying mpa header

MPEG Audio frame header must be 4 bytes. If we fail to read
4 bytes bail early to avoid Use-of-uninitialized-value msan error.
Reference https://crbug.com/666874.

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
tags/n3.3
Chris Cunningham Michael Niedermayer 9 years ago
parent
commit
ab87df9a47
1 changed files with 2 additions and 1 deletions
  1. +2
    -1
      libavformat/mp3dec.c

+ 2
- 1
libavformat/mp3dec.c View File

@@ -457,7 +457,8 @@ static int check(AVIOContext *pb, int64_t pos, uint32_t *ret_header)
return CHECK_SEEK_FAILED;

ret = avio_read(pb, &header_buf[0], 4);
if (ret < 0)
/* We should always find four bytes for a valid mpa header. */
if (ret < 4)
return CHECK_SEEK_FAILED;

header = AV_RB32(&header_buf[0]);


Loading…
Cancel
Save