Browse Source

avcodec/h264idct_template: Fix integer overflow in ff_h264_idct8_add

Fixes: signed integer overflow: 452986184 - -2113885312 cannot be represented in type 'int'
Fixes: 4196/clusterfuzz-testcase-minimized-5580648594014208

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 9cc926da7d)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
tags/n3.4.1
Michael Niedermayer 8 years ago
parent
commit
983d119c9b
1 changed files with 4 additions and 4 deletions
  1. +4
    -4
      libavcodec/h264idct_template.c

+ 4
- 4
libavcodec/h264idct_template.c View File

@@ -76,10 +76,10 @@ void FUNCC(ff_h264_idct8_add)(uint8_t *_dst, int16_t *_block, int stride){

for( i = 0; i < 8; i++ )
{
const unsigned int a0 = block[i+0*8] + block[i+4*8];
const unsigned int a2 = block[i+0*8] - block[i+4*8];
const unsigned int a4 = (block[i+2*8]>>1) - block[i+6*8];
const unsigned int a6 = (block[i+6*8]>>1) + block[i+2*8];
const unsigned int a0 = block[i+0*8] + (unsigned)block[i+4*8];
const unsigned int a2 = block[i+0*8] - (unsigned)block[i+4*8];
const unsigned int a4 = (block[i+2*8]>>1) - (unsigned)block[i+6*8];
const unsigned int a6 = (block[i+6*8]>>1) + (unsigned)block[i+2*8];

const unsigned int b0 = a0 + a6;
const unsigned int b2 = a2 + a4;


Loading…
Cancel
Save