Browse Source

avcodec/ivi: Move buffer/block end check to caller of ivi_dc_transform()

Fixes: assertion failure
Fixes: 14078/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_INDEO5_fuzzer-5760571284127744

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 110dce9633)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
tags/n2.8.16
Michael Niedermayer 6 years ago
parent
commit
89b9c72862
1 changed files with 5 additions and 6 deletions
  1. +5
    -6
      libavcodec/ivi.c

+ 5
- 6
libavcodec/ivi.c View File

@@ -487,12 +487,6 @@ static int ivi_dec_tile_data_size(GetBitContext *gb)
static int ivi_dc_transform(IVIBandDesc *band, int *prev_dc, int buf_offs,
int blk_size)
{
int buf_size = band->pitch * band->aheight - buf_offs;
int min_size = (blk_size - 1) * band->pitch + blk_size;

if (min_size > buf_size)
return AVERROR_INVALIDDATA;

band->dc_transform(prev_dc, band->buf + buf_offs,
band->pitch, blk_size);

@@ -723,6 +717,11 @@ static int ivi_decode_blocks(GetBitContext *gb, IVIBandDesc *band,
if (ret < 0)
return ret;
} else {
int buf_size = band->pitch * band->aheight - buf_offs;
int min_size = (blk_size - 1) * band->pitch + blk_size;

if (min_size > buf_size)
return AVERROR_INVALIDDATA;
/* block not coded */
/* for intra blocks apply the dc slant transform */
/* for inter - perform the motion compensation without delta */


Loading…
Cancel
Save