Browse Source

asv1dec: check extradatasize before reading.

Fixes null ptr dereference

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
tags/n0.11
Michael Niedermayer 14 years ago
parent
commit
605f2b6b00
1 changed files with 1 additions and 2 deletions
  1. +1
    -2
      libavcodec/asv1.c

+ 1
- 2
libavcodec/asv1.c View File

@@ -553,8 +553,7 @@ static av_cold int decode_init(AVCodecContext *avctx){
ff_init_scantable(a->dsp.idct_permutation, &a->scantable, scantab);
avctx->pix_fmt= PIX_FMT_YUV420P;

a->inv_qscale= avctx->extradata[0];
if(a->inv_qscale == 0){
if(avctx->extradata_size < 1 || (a->inv_qscale= avctx->extradata[0]) == 0){
av_log(avctx, AV_LOG_ERROR, "illegal qscale 0\n");
if(avctx->codec_id == CODEC_ID_ASV1)
a->inv_qscale= 6;


Loading…
Cancel
Save