Browse Source

yop: Do not keep a copy of parts of the returned packet

Fixes double free
Regression since the new buffer references, thus no FFmpeg
releases should be affected

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
tags/n2.0
Michael Niedermayer 12 years ago
parent
commit
551f683861
1 changed files with 1 additions and 2 deletions
  1. +1
    -2
      libavformat/yop.c

+ 1
- 2
libavformat/yop.c View File

@@ -135,8 +135,7 @@ static int yop_read_packet(AVFormatContext *s, AVPacket *pkt)


if (yop->video_packet.data) { if (yop->video_packet.data) {
*pkt = yop->video_packet; *pkt = yop->video_packet;
yop->video_packet.data = NULL;
yop->video_packet.size = 0;
memset(&yop->video_packet, 0, sizeof(yop->video_packet));
pkt->data[0] = yop->odd_frame; pkt->data[0] = yop->odd_frame;
pkt->flags |= AV_PKT_FLAG_KEY; pkt->flags |= AV_PKT_FLAG_KEY;
yop->odd_frame ^= 1; yop->odd_frame ^= 1;


Loading…
Cancel
Save