From 3fc8dc35896420385e265de676ea01ed1950d8bd Mon Sep 17 00:00:00 2001 From: Andreas Rheinhardt Date: Mon, 28 Sep 2020 18:05:44 +0200 Subject: [PATCH] avformat/movenc: Free old vos_data before overwriting it Otherwise the old data leaks whenever extradata needs to be rewritten (e.g. when encoding FLAC with our encoder that sends an updated extradata packet at the end). Signed-off-by: Andreas Rheinhardt (cherry picked from commit 432f291dffb0079bf447b1cdb8802a022298510f) --- libavformat/movenc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 31edb9399e..a1c1a44f04 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -6880,6 +6880,7 @@ static int mov_write_trailer(AVFormatContext *s) AVCodecParameters *par = track->par; track->vos_len = par->extradata_size; + av_freep(&track->vos_data); track->vos_data = av_malloc(track->vos_len + AV_INPUT_BUFFER_PADDING_SIZE); if (!track->vos_data) return AVERROR(ENOMEM);