Browse Source

vp9: remove another optimization branch in iadst16 which causes overflows.

See sample vp90-2-14-resize-fp-tiles-16-8.webm from the vp9 test vector
set to reproduce the issue.
tags/n2.7
Ronald S. Bultje Michael Niedermayer 10 years ago
parent
commit
3de13d5212
1 changed files with 3 additions and 1 deletions
  1. +3
    -1
      libavcodec/x86/vp9itxfm.asm

+ 3
- 1
libavcodec/x86/vp9itxfm.asm View File

@@ -1622,7 +1622,9 @@ VP9_IDCT_IDCT_16x16_ADD_XMM avx
PSIGNW m3, [pw_m1] ; m3=out1[w], m7=t10[w] PSIGNW m3, [pw_m1] ; m3=out1[w], m7=t10[w]
SUMSUB_BA w, 2, 6, 1 ; m2=out14[w], m6=t11[w] SUMSUB_BA w, 2, 6, 1 ; m2=out14[w], m6=t11[w]


%if cpuflag(ssse3)
; unfortunately, the code below overflows in some cases, e.g.
; http://downloads.webmproject.org/test_data/libvpx/vp90-2-14-resize-fp-tiles-16-8.webm
%if 0; cpuflag(ssse3)
SUMSUB_BA w, 7, 6, 1 SUMSUB_BA w, 7, 6, 1
pmulhrsw m7, [pw_11585x2] ; m7=out6[w] pmulhrsw m7, [pw_11585x2] ; m7=out6[w]
pmulhrsw m6, [pw_11585x2] ; m6=out9[w] pmulhrsw m6, [pw_11585x2] ; m6=out9[w]


Loading…
Cancel
Save