Browse Source

avformat/rmdec: Fix codecdata_length overflow check

Fixes: signed integer overflow: 2147483647 + 64 cannot be represented in type 'int'
Fixes: 28509/clusterfuzz-testcase-minimized-ffmpeg_dem_IVR_fuzzer-6310969680723968

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
tags/n4.4
Michael Niedermayer 4 years ago
parent
commit
3c41d0bfd6
1 changed files with 1 additions and 1 deletions
  1. +1
    -1
      libavformat/rmdec.c

+ 1
- 1
libavformat/rmdec.c View File

@@ -254,7 +254,7 @@ static int rm_read_audio_stream_info(AVFormatContext *s, AVIOContext *pb,
if (version == 5) if (version == 5)
avio_r8(pb); avio_r8(pb);
codecdata_length = avio_rb32(pb); codecdata_length = avio_rb32(pb);
if(codecdata_length + AV_INPUT_BUFFER_PADDING_SIZE <= (unsigned)codecdata_length){
if((unsigned)codecdata_length > INT_MAX - AV_INPUT_BUFFER_PADDING_SIZE){
av_log(s, AV_LOG_ERROR, "codecdata_length too large\n"); av_log(s, AV_LOG_ERROR, "codecdata_length too large\n");
return -1; return -1;
} }


Loading…
Cancel
Save