Browse Source

alac: Check that the channels fit at the given offset

The code tries to decode a number of channels at the
offset given by the ff_alac_channel_layout_offsets table.
Even if the number of channels decoded so far doesn't
exceed the total number of channels, we need to check that
we actually can decode that number of channels at this offset
as well.

Reported-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable@libav.org
Signed-off-by: Martin Storsjö <martin@martin.st>
tags/n2.1
Martin Storsjö 11 years ago
parent
commit
35cbc98b72
1 changed files with 2 additions and 1 deletions
  1. +2
    -1
      libavcodec/alac.c

+ 2
- 1
libavcodec/alac.c View File

@@ -418,7 +418,8 @@ static int alac_decode_frame(AVCodecContext *avctx, void *data,
} }


channels = (element == TYPE_CPE) ? 2 : 1; channels = (element == TYPE_CPE) ? 2 : 1;
if (ch + channels > alac->channels) {
if (ch + channels > alac->channels ||
ff_alac_channel_layout_offsets[alac->channels - 1][ch] + channels > alac->channels) {
av_log(avctx, AV_LOG_ERROR, "invalid element channel count\n"); av_log(avctx, AV_LOG_ERROR, "invalid element channel count\n");
return AVERROR_INVALIDDATA; return AVERROR_INVALIDDATA;
} }


Loading…
Cancel
Save